Fix loading indicator colors to match Figma design

Author: kidinov

RELEASE-NOTES.txt

@@ -2,6 +2,10 @@
 *** Use [*****] to indicate smoke tests of all critical flows should be run on the final APK before release (e.g. major library or targetSdk updates).
 *** For entries which are touching the Android Wear app's, start entry with `[WEAR]` too.
 
+23.9
+-----
+- [*][Woo POS] Fixed loading indicator colors to match the design [https://github.com/woocommerce/woocommerce-android/pull/15043]
+
 23.8
 -----
 - [*] Fixed system back button not working on Order Creation screen [https://github.com/woocommerce/woocommerce-android/pull/15016]

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/common/composeui/component/WooPosButtons.kt

@@ -34,7 +34,6 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.alpha
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.graphics.Color
-import androidx.compose.ui.graphics.compositeOver
 import androidx.compose.ui.graphics.vector.ImageVector
 import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.tooling.preview.PreviewFontScale
@@ -264,11 +263,8 @@ private fun Button(
 
 @Composable
 private fun ButtonsLoadingIndicator(size: Dp) {
-    WooPosCircularLoadingIndicator(
+    WooPosButtonLoadingIndicator(
         modifier = Modifier.size(size),
-        spinnerPrimaryColor = MaterialTheme.colorScheme.secondary,
-        spinnerSecondaryColor = Color.White.copy(alpha = 0.2f)
-            .compositeOver(MaterialTheme.colorScheme.primaryContainer),
     )
 }
 

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/common/composeui/component/WooPosCircularLoadingIndicator.kt renamed to WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/common/composeui/component/WooPosLoadingIndicators.kt

@@ -6,6 +6,7 @@ import androidx.compose.animation.core.infiniteRepeatable
 import androidx.compose.animation.core.rememberInfiniteTransition
 import androidx.compose.animation.core.tween
 import androidx.compose.foundation.Canvas
+import androidx.compose.foundation.background
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.size
@@ -27,8 +28,30 @@ import com.woocommerce.android.ui.woopos.common.composeui.designsystem.WooPosThe
 @Composable
 fun WooPosCircularLoadingIndicator(
     modifier: Modifier = Modifier,
-    spinnerPrimaryColor: Color = MaterialTheme.colorScheme.primary,
-    spinnerSecondaryColor: Color = MaterialTheme.colorScheme.secondary,
+) {
+    WooPosLoadingIndicatorInternal(
+        modifier = modifier,
+        spinnerPrimaryColor = MaterialTheme.colorScheme.primary,
+        spinnerSecondaryColor = MaterialTheme.colorScheme.secondary,
+    )
+}
+
+@Composable
+fun WooPosButtonLoadingIndicator(
+    modifier: Modifier = Modifier,
+) {
+    WooPosLoadingIndicatorInternal(
+        modifier = modifier,
+        spinnerPrimaryColor = MaterialTheme.colorScheme.onPrimary,
+        spinnerSecondaryColor = MaterialTheme.colorScheme.secondary,
+    )
+}
+
+@Composable
+private fun WooPosLoadingIndicatorInternal(
+    modifier: Modifier = Modifier,
+    spinnerPrimaryColor: Color,
+    spinnerSecondaryColor: Color,
 ) {
     val infiniteTransition = rememberInfiniteTransition(label = "RotationTransition")
     val animatedRotation by infiniteTransition.animateFloat(
@@ -73,7 +96,7 @@ fun WooPosCircularLoadingIndicator(
 
 @Composable
 @WooPosPreview
-fun PreviewCircularLoadingIndicatorBig() {
+fun PreviewWooPosCircularLoadingIndicator() {
     WooPosTheme {
         Box(
             modifier = Modifier.fillMaxSize(),
@@ -88,14 +111,16 @@ fun PreviewCircularLoadingIndicatorBig() {
 
 @Composable
 @WooPosPreview
-fun PreviewCircularLoadingIndicatorSmall() {
+fun PreviewWooPosButtonLoadingIndicator() {
     WooPosTheme {
         Box(
-            modifier = Modifier.fillMaxSize(),
+            modifier = Modifier
+                .fillMaxSize()
+                .background(MaterialTheme.colorScheme.primary),
             contentAlignment = Alignment.Center
         ) {
-            WooPosCircularLoadingIndicator(
-                modifier = Modifier.size(64.dp)
+            WooPosButtonLoadingIndicator(
+                modifier = Modifier.size(32.dp)
             )
         }
     }