Skip to content

Commit a8c552e

Browse files
authored
Merge pull request #10603 from woocommerce/fix/10563-duplicated-toolbar
Avoid displaying my store expanded toolbar on campaign preview screen
2 parents 31b91c4 + 6dadcd8 commit a8c552e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import com.woocommerce.android.ui.appwidgets.WidgetUpdater
6161
import com.woocommerce.android.ui.base.BaseFragment
6262
import com.woocommerce.android.ui.base.TopLevelFragment
6363
import com.woocommerce.android.ui.base.UIMessageResolver
64+
import com.woocommerce.android.ui.blaze.creation.preview.BlazeCampaignCreationPreviewFragment
6465
import com.woocommerce.android.ui.compose.theme.WooThemeWithBackground
6566
import com.woocommerce.android.ui.feedback.SurveyType
6667
import com.woocommerce.android.ui.login.LoginActivity
@@ -206,9 +207,12 @@ class MainActivity :
206207
override fun onFragmentViewCreated(fm: FragmentManager, f: Fragment, v: View, savedInstanceState: Bundle?) {
207208
if (f is DialogFragment) return
208209

210+
if (f is BlazeCampaignCreationPreviewFragment) // Context on why this is needed check GH issue #10563
211+
animatorHelper.cancelToolbarAnimation()
212+
209213
when (val appBarStatus = (f as? BaseFragment)?.activityAppBarStatus ?: AppBarStatus.Visible()) {
210214
is AppBarStatus.Visible -> {
211-
showToolbar(f is TopLevelFragment)
215+
showToolbar(animate = f is TopLevelFragment)
212216
// re-expand the AppBar when returning to top level fragment,
213217
// collapse it when entering a child fragment
214218
if (f is TopLevelFragment) {
@@ -327,6 +331,7 @@ class MainActivity :
327331
}
328332
)
329333
}
334+
330335
override fun hideProgressDialog() {
331336
progressDialog?.apply {
332337
if (isShowing) {

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainAnimatorHelper.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ class MainAnimatorHelper @Inject constructor(private val resourceProvider: Resou
5555
}
5656
}
5757

58+
fun cancelToolbarAnimation() {
59+
toolbarAnimator.cancel()
60+
}
61+
5862
private companion object {
5963
private const val COLLAPSING_ANIMATION_DURATION = 200L
6064
private const val TOOLBAR_ANIMATION_DURATION = 300L

0 commit comments

Comments
 (0)