Skip to content

Commit cd12bb0

Browse files
Merge pull request #14734 from woocommerce/issue/WOOMOB-1484_trash_product_in_split_view
Fix trash product button visibility on tablets
2 parents b864a56 + 8bb2dbd commit cd12bb0

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailFragment.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,11 @@ class ProductDetailFragment :
156156
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
157157
super.onViewCreated(view, savedInstanceState)
158158

159-
val isTrashEnabled =
159+
val productListInBackstack =
160160
findNavController().previousBackStackEntry?.destination?.id == BottomNavigationPosition.PRODUCTS.id
161+
val isInDetailPane =
162+
requireContext().isTwoPanesShouldBeUsed && (parentFragment?.id == R.id.detail_nav_container)
163+
val isTrashEnabled = productListInBackstack || isInDetailPane
161164
viewModel.setTrashActionPossible(isTrashEnabled)
162165

163166
blazeCampaignCreationDispatcher.attachFragment(this, BlazeFlowSource.PRODUCT_DETAIL_PROMOTE_BUTTON)

0 commit comments

Comments
 (0)