-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Show POS Menu with WooCommerce Upgrade description When WooCommerce Version is Outdated #13807
base: trunk
Are you sure you want to change the base?
[Woo POS] Show POS Menu with WooCommerce Upgrade description When WooCommerce Version is Outdated #13807
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13807 +/- ##
============================================
+ Coverage 38.10% 38.13% +0.02%
- Complexity 9207 9214 +7
============================================
Files 2070 2070
Lines 114100 114169 +69
Branches 14527 14539 +12
============================================
+ Hits 43478 43535 +57
- Misses 66673 66677 +4
- Partials 3949 3957 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes: #13497
Description
This PR updates the logic for displaying the POS menu option to ensure it is shown when POS meets all criteria except WooCommerce version. If WooPOS is unavailable for any other reason (e.g., site settings, currency, feature flag), the POS menu will remain hidden. This ensures merchants don't miss out on POS simply because they overlooked the version requirement.
Before this PR, we would hide the POS option if WooCommerce version was outdated.
After this PR, we display POS option with a description that says to upgrade WooCommerce version. When clicked, we display a simple toast that just asks merchants to update their WooCommerce version
Steps to reproduce
Store that meets all POS criteria but with WooCommerce version < 9.6.0
Store that meets all POS criteria with WooCommerce version > 9.6.0
The tests that have been performed
Tested above steps both on emulator and on real tablet device
Images/gif
pos_entry_point.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: