Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Woo POS] Play Cha-Ching sound on successful payment #13808

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

[Woo POS] Play Cha-Ching sound on successful payment #13808

wants to merge 5 commits into from

Conversation

AnirudhBhat
Copy link
Contributor

Closes: #13636

Description

This PR adds a Cha-Ching sound on successful payment on POS mode for both card and cash payment. Right now, there is no option to turn this setting off. It will be part of another PR.

Please read the discussion here to understand more on why we think Cha-Ching sound is important

Steps to reproduce

  1. Navigate to more menu -> POS
  2. Add items to cart and proceed to checkout
  3. Collect payment either by card or by cash
  4. Ensure you hear Cha-Ching sound on successful payment

The tests that have been performed

Tested the above steps on both emulator and on tablet device

Images/gif

cha_ching_sound.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: enhancement A request for an enhancement. feature: point of sale POS project labels Mar 19, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit188eb4e
Direct Downloadwoocommerce-wear-prototype-build-pr13808-188eb4e.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit188eb4e
Direct Downloadwoocommerce-prototype-build-pr13808-188eb4e.apk

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 38.10%. Comparing base (66f3ff5) to head (188eb4e).
Report is 31 commits behind head on trunk.

Files with missing lines Patch % Lines
...erce/android/ui/woopos/home/WooPosHomeViewModel.kt 42.85% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##              trunk   #13808   +/-   ##
=========================================
  Coverage     38.10%   38.10%           
- Complexity     9207     9208    +1     
=========================================
  Files          2070     2070           
  Lines        114100   114107    +7     
  Branches      14527    14527           
=========================================
+ Hits          43478    43481    +3     
- Misses        66673    66677    +4     
  Partials       3949     3949

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature: point of sale POS project type: enhancement A request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Woo POS] Play cha-ching sound after successful payment
4 participants
@AnirudhBhat @dangermattic @wpmobilebot @codecov-commenter