Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the maximum character count for the order badge #13825

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Mar 21, 2025

Closes: #13783

Description

This PR increases the maximum character count for the order badge from 3 to 4. Previously, counts above 99 were displayed as 99+. Now, counts above 999 will be displayed as 999+.

Steps to reproduce

The easiest method to reproduce is updating the code. You can update the count in ordersBadge.number = count in the MainBottomNavigationView line#129

The tests that have been performed

Images/gif

Before After After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added this to the 22.1 milestone Mar 21, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 21, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitef5228c
Direct Downloadwoocommerce-wear-prototype-build-pr13825-ef5228c.apk

@irfano irfano changed the title Issue/13783 update order count badge limit Update the maximum character count for the order badge Mar 21, 2025
@irfano irfano added the feature: dashboard Related to home screen project label Mar 21, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 21, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitef5228c
Direct Downloadwoocommerce-prototype-build-pr13825-ef5228c.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dashboard Related to home screen project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display higher order count instead showing "99+"
2 participants