[Jetpack Performance] App Passwords error handling #14552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
added
type: task
hichamboushaba
force-pushed
the
issue/WOOMOB-1126-app-passwords-network
branch
from
06cffda to
8ea3d7f
Compare
…or handler to use it
hichamboushaba
force-pushed
the
issue/WOOMOB-1180-app-passwords-error-handling
branch
from
1b1f337 to
464912e
Compare
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
hichamboushaba
force-pushed
the
issue/WOOMOB-1180-app-passwords-error-handling
branch
from
464912e to
c977e88
Compare
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## issue/WOOMOB-1126-app-passwords-network #14552 +/- ##
=============================================================================
+ Coverage 38.04% 38.05% +0.01%
- Complexity 9473 9487 +14
=============================================================================
Files 2045 2047 +2
Lines 114338 114371 +33
Branches 15153 15162 +9
=============================================================================
+ Hits 43501 43526 +25
- Misses 66853 66860 +7
- Partials 3984 3985 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hichamboushaba
force-pushed
the
issue/WOOMOB-1180-app-passwords-error-handling
branch
from
32c308d to
c977e88
Compare
Collaborator
|
Version |
Base automatically changed from
issue/WOOMOB-1126-app-passwords-network
to
trunk
September 5, 2025 22:12
JorgeMucientes
approved these changes
Sep 8, 2025
Contributor
JorgeMucientes
left a comment
JorgeMucientes
left a comment
There was a problem hiding this comment.
Outstanding work @hichamboushaba, really clear testing instructions and (life saving snippets code config) to be able to test all the different error handling for this project. Everything worked as expected and the code looks clear and easy to follow despite the complexity of dealing with the many different error scenarios 👏🏼 .
hichamboushaba
deleted the
issue/WOOMOB-1180-app-passwords-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1180
Description
This PR adds handling of errors in App Passwords flows according to what was decided in pe5sF9-4ye-p2#comment-4787.
For flagging websites as unsupported, I opted for using SharedPreferences, which makes the logic simpler, as fetching the site from the API won't override it.
Steps to reproduce
Test TC3, TC4 and TC5 from the testing plan pe5sF9-4Am-p2
Testing information
The tests that have been performed
The above.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.