-
Notifications
You must be signed in to change notification settings - Fork 136
Activate: Show "Share" CTA next to ellipsis menu if Save/Publish option is not shown there. #9084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate: Show "Share" CTA next to ellipsis menu if Save/Publish option is not shown there. #9084
Conversation
… not shown there.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/ProductDetailFragment.kt
Show resolved
Hide resolved
|
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code: |
Generated by 🚫 dangerJS |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## trunk #9084 +/- ##
============================================
- Coverage 43.48% 43.47% -0.01%
Complexity 4036 4036
============================================
Files 836 836
Lines 43946 43953 +7
Branches 5742 5742
============================================
+ Hits 19108 19109 +1
- Misses 23163 23169 +6
Partials 1675 1675
☔ View full report in Codecov by Sentry. |
|
Code looks good and works as expected! Nicely done. 🚢 |
Part of #9080
Ref: pe5sF9-1xq-p2/#show-the-share-cta-in-product-form
Description
As part of improving the product sharing experience, we're exposing the "Share" menu item at any times, next to the ellipsis button, assuming the product is published and do not currently has any edits. In other words, whenever the "Publish" or "Save" menu item is not currently exposed next to the ellipsis button.
This also adds analytics to check which one is more performant: the exposed menu item, or the hidden-in-dropdown menu item. This is done by adding a source
product_formormore_menuto the existingproduct_detail_share_button_tappedevent. This is done to match the tracking added in iOS here.Testing instructions
Display testing:
Analytics testing:
🔵 Tracked: product_detail_share_button_tapped, Properties: {"source":"product_form"🔵 Tracked: product_detail_share_button_tapped, Properties: {"source":"more_menu"