Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Global Styles - Product Rating - fix styles application #8663

Open
@kmanijak

Description

@kmanijak

Prerequisites

  • Make sure to have at least one product with and one product without rating

Steps to reproduce

  1. Go to Editor
  2. Add Products block
  3. Add Product Rating block as an inner block if not already included
  4. Open Global Styles and change following styles:

Typography

  • Font
    Expected: "Add review" changes the font
    Actual:"Add review" reacts in the editor, but not in the fronted

  • Size
    Expected: "Add review" should keep the chosen size and can have a different size than Stars
    Actual:"Add review" changes size in Editor, but on the frontend has the size of Stars

  • Line height
    Expected: "Add review" should keep the chosen line height and can have a different line height than Stars
    Actual:"Add review" doesn't react to line height changes

⚠️ Remember

  • Check all of the above in Editor and Frontend!
  • Styles composition may be fragile and the issue may evolve. Please check if block reacts to all the other Global Styles
  • For items we are inheriting from Gutenberg that seem inconsistent and/or have room for improvement, we should raise an upstream Issue or PR and avoid making localized changes that bring inconsistency with Gutenberg.
  • Reflect the newest state of styles support in the Spreadsheet after finishing this task

Note: Product Rating consists of

  • Stars if there's a rating
  • "Add review" link if there's no rating

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions