Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Global Styles - On Sale Badge - fix styles application #8665

Open
@kmanijak

Description

@kmanijak

Prerequisites:

  • Make sure to have at least one product on sale

Steps to reproduce

  1. Go to Editor
  2. Add Products block
  3. Add On Sale Badge block as an inner block if not already included
  4. Open Global Styles and change following styles:

Typography - Text

  • Appearance
    Expected: Font weight and italic are applied to "Sale" badge
    Actual: Only italic is applied, font weight doesn't change
  • Verify all the other properties work as expected

Colors

  • Text
    Expected: "Sale" badge changes color
    Actual: It doesn't react

⚠️ Remember

  • Check all of the above in Editor and Frontend!
  • Styles composition may be fragile and the issue may evolve. Please check if block reacts to all the other Global Styles
  • For items we are inheriting from Gutenberg that seem inconsistent and/or have room for improvement, we should raise an upstream Issue or PR and avoid making localized changes that bring inconsistency with Gutenberg.
  • Reflect the newest state of styles support in the Spreadsheet after finishing this task

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions