Skip to content

Commit 02ee256

Browse files
committed
Update MainTabBarControllerTests
1 parent 8565e0b commit 02ee256

File tree

2 files changed

+46
-14
lines changed

2 files changed

+46
-14
lines changed

WooCommerce/WooCommerceTests/ViewRelated/MainTabBarController+TabsTests.swift

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ final class MainTabBarController_TabsTests: XCTestCase {
2222
XCTAssertNotNil(tabBarController.view)
2323

2424
// Action
25-
storesManager.updateDefaultStore(storeID: 980)
25+
let siteID: Int64 = 980
26+
storesManager.updateDefaultStore(storeID: siteID)
27+
storesManager.updateDefaultStore(.fake().copy(siteID: siteID))
2628

2729
// Assert
2830
XCTAssertEqual(tabBarController.viewControllers?.count, 4)
@@ -58,7 +60,9 @@ final class MainTabBarController_TabsTests: XCTestCase {
5860
XCTAssertNotNil(tabBarController.view)
5961

6062
// When
61-
storesManager.updateDefaultStore(storeID: 314)
63+
let siteID: Int64 = 314
64+
storesManager.updateDefaultStore(storeID: siteID)
65+
storesManager.updateDefaultStore(.fake().copy(siteID: siteID))
6266

6367
// Then
6468
waitUntil {
@@ -98,7 +102,9 @@ final class MainTabBarController_TabsTests: XCTestCase {
98102
XCTAssertNotNil(tabBarController.view)
99103

100104
// When
101-
storesManager.updateDefaultStore(storeID: 707)
105+
let siteID: Int64 = 707
106+
storesManager.updateDefaultStore(storeID: siteID)
107+
storesManager.updateDefaultStore(.fake().copy(siteID: siteID))
102108

103109
// Then
104110
waitUntil {
@@ -136,7 +142,9 @@ final class MainTabBarController_TabsTests: XCTestCase {
136142
XCTAssertNotNil(tabBarController.view)
137143

138144
// When
139-
storesManager.updateDefaultStore(storeID: 303)
145+
let siteID: Int64 = 303
146+
storesManager.updateDefaultStore(storeID: siteID)
147+
storesManager.updateDefaultStore(.fake().copy(siteID: siteID))
140148

141149
// Then initial state
142150
waitUntil {
@@ -163,9 +171,14 @@ final class MainTabBarController_TabsTests: XCTestCase {
163171
XCTAssertNotNil(tabBarController.view)
164172

165173
// Action
166-
stores.updateDefaultStore(storeID: 134)
174+
let siteIDBefore: Int64 = 134
175+
stores.updateDefaultStore(storeID: siteIDBefore)
176+
stores.updateDefaultStore(.fake().copy(siteID: siteIDBefore))
167177
let viewControllersBeforeSiteChange = tabBarController.tabRootViewControllers
168-
stores.updateDefaultStore(storeID: 630)
178+
179+
let siteIDAfter: Int64 = 630
180+
stores.updateDefaultStore(storeID: siteIDAfter)
181+
stores.updateDefaultStore(.fake().copy(siteID: siteIDAfter))
169182
let viewControllersAfterSiteChange = tabBarController.tabRootViewControllers
170183

171184
// Assert
@@ -195,8 +208,11 @@ final class MainTabBarController_TabsTests: XCTestCase {
195208
// Action
196209
let siteID: Int64 = 610
197210
stores.updateDefaultStore(storeID: siteID)
211+
stores.updateDefaultStore(.fake().copy(siteID: siteID))
198212
let viewControllersBeforeSiteChange = try XCTUnwrap(tabBarController.viewControllers)
213+
199214
stores.updateDefaultStore(storeID: siteID)
215+
stores.updateDefaultStore(.fake().copy(siteID: siteID))
200216
let viewControllersAfterSiteChange = try XCTUnwrap(tabBarController.viewControllers)
201217

202218
// Assert

WooCommerce/WooCommerceTests/ViewRelated/MainTabBarControllerTests.swift

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,18 @@ final class MainTabBarControllerTests: XCTestCase {
5151
XCTAssertNotNil(tabBarController.view)
5252

5353
// Action
54-
stores.updateDefaultStore(storeID: 134)
54+
let siteIDBefore: Int64 = 134
55+
stores.updateDefaultStore(storeID: siteIDBefore)
56+
stores.updateDefaultStore(.fake().copy(siteID: siteIDBefore))
5557
waitFor { promise in
5658
tabBarController.navigateTo(.products) {
5759
promise(())
5860
}
5961
}
6062
let selectedTabIndexBeforeSiteChange = tabBarController.selectedIndex
61-
stores.updateDefaultStore(storeID: 630)
63+
let siteIDAfter: Int64 = 630
64+
stores.updateDefaultStore(storeID: siteIDAfter)
65+
stores.updateDefaultStore(.fake().copy(siteID: siteIDAfter))
6266
let selectedTabIndexAfterSiteChange = tabBarController.selectedIndex
6367

6468
// Assert
@@ -90,7 +94,9 @@ final class MainTabBarControllerTests: XCTestCase {
9094

9195
// Trigger `viewDidLoad`
9296
XCTAssertNotNil(tabBarController.view)
93-
storesManager.updateDefaultStore(storeID: 782)
97+
let siteID: Int64 = 782
98+
storesManager.updateDefaultStore(storeID: siteID)
99+
storesManager.updateDefaultStore(.fake().copy(siteID: siteID))
94100

95101
// Simulate successful state resetting after logging out from push notification store switching
96102
storesManager.whenReceivingAction(ofType: StatsActionV4.self) { action in
@@ -349,7 +355,9 @@ final class MainTabBarControllerTests: XCTestCase {
349355

350356
func test_navigateToTabWithNavigationController_returns_UIViewController_of_the_newly_selected_tab() throws {
351357
// Given
352-
stores.updateDefaultStore(storeID: 134)
358+
let siteID: Int64 = 134
359+
stores.updateDefaultStore(storeID: siteID)
360+
stores.updateDefaultStore(.fake().copy(siteID: siteID))
353361

354362
let tabBarController = try XCTUnwrap(UIStoryboard(name: "Main", bundle: nil).instantiateInitialViewController() as? MainTabBarController)
355363

@@ -372,6 +380,7 @@ final class MainTabBarControllerTests: XCTestCase {
372380
// Given
373381
let siteID: Int64 = 256
374382
stores.updateDefaultStore(storeID: siteID)
383+
stores.updateDefaultStore(.fake().copy(siteID: siteID))
375384

376385
let mockFeatureFlagService = MockFeatureFlagService()
377386
ServiceLocator.setFeatureFlagService(mockFeatureFlagService)
@@ -410,6 +419,7 @@ final class MainTabBarControllerTests: XCTestCase {
410419

411420
let siteID: Int64 = 256
412421
stores.updateDefaultStore(storeID: siteID)
422+
stores.updateDefaultStore(.fake().copy(siteID: siteID))
413423

414424
stores.whenReceivingAction(ofType: NotificationAction.self) { action in
415425
guard case let .synchronizeNotification(_, completion) = action else {
@@ -476,7 +486,9 @@ final class MainTabBarControllerTests: XCTestCase {
476486
XCTAssertNotNil(tabBarController.view)
477487

478488
// When POS tab initial visibility is set to true
479-
stores.updateDefaultStore(storeID: 1126)
489+
let siteID: Int64 = 1126
490+
stores.updateDefaultStore(storeID: siteID)
491+
stores.updateDefaultStore(.fake().copy(siteID: siteID))
480492

481493
// Then POS tab is visible before eligibility check is returned
482494
waitUntil {
@@ -537,15 +549,17 @@ final class MainTabBarControllerTests: XCTestCase {
537549
XCTAssertNotNil(tabBarController.view)
538550

539551
// When POS tab initial visibility is set to true
540-
stores.updateDefaultStore(storeID: 1216)
552+
let siteID: Int64 = 1216
553+
stores.updateDefaultStore(storeID: siteID)
554+
stores.updateDefaultStore(.fake().copy(siteID: siteID))
541555
mockPOSEligibilityChecker.setVisibilityResult(true)
542556

543557
waitUntil {
544558
tabBarController.tabRootViewControllers.count == 5
545559
}
546560

547561
// Then
548-
XCTAssertEqual(mockPOSEligibilityService.loadCachedPOSTabVisibility(siteID: 1216), true)
562+
XCTAssertEqual(mockPOSEligibilityService.loadCachedPOSTabVisibility(siteID: siteID), true)
549563
}
550564

551565
func test_event_is_tracked_after_eligibility_check() throws {
@@ -568,7 +582,9 @@ final class MainTabBarControllerTests: XCTestCase {
568582
XCTAssertNotNil(tabBarController.view)
569583

570584
// When
571-
storesManager.updateDefaultStore(storeID: 322)
585+
let siteID: Int64 = 322
586+
storesManager.updateDefaultStore(storeID: siteID)
587+
storesManager.updateDefaultStore(.fake().copy(siteID: siteID))
572588

573589
// Then
574590
waitUntil {

0 commit comments

Comments
 (0)