Skip to content

Commit 0788623

Browse files
committed
Use correct learn more event for manageCardReader
1 parent 0ee9d6f commit 0788623

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

WooCommerce/Classes/Analytics/WooAnalyticsEvent.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1894,6 +1894,7 @@ extension WooAnalyticsEvent {
18941894
case paymentsMenu
18951895
case paymentMethods
18961896
case tapToPaySummary
1897+
case manageCardReader
18971898

18981899
var trackingValue: String {
18991900
switch self {
@@ -1903,6 +1904,8 @@ extension WooAnalyticsEvent {
19031904
return "payment_methods"
19041905
case .tapToPaySummary:
19051906
return "tap_to_pay_summary"
1907+
case .manageCardReader:
1908+
return "manage_card_reader"
19061909
}
19071910
}
19081911
}

WooCommerce/Classes/Analytics/WooAnalyticsStat.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ public enum WooAnalyticsStat: String {
277277
case cardReaderDisconnectTapped = "card_reader_disconnect_tapped"
278278
case manageCardReadersBuiltInReaderAutoDisconnect = "manage_card_readers_automatic_disconnect_built_in_reader"
279279
case cardReaderAutomaticDisconnect = "card_reader_automatic_disconnect"
280-
case manageCardReaderLearnMoreTapped = "card_present_connection_learn_more_tapped"
281280

282281
// MARK: Card Reader Software Update Events
283282
//

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsSearchingViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ struct CardReaderSettingsSearchingView: View {
148148
.padding(.bottom, 8)
149149

150150
InPersonPaymentsLearnMore(viewModel: LearnMoreViewModel(
151-
tappedAnalyticEvent: WooAnalyticsEvent(statName: .manageCardReaderLearnMoreTapped, properties: [:])))
151+
tappedAnalyticEvent: WooAnalyticsEvent.InPersonPayments.learnMoreTapped(source: .manageCardReader)))
152152
.customOpenURL(action: { url in
153153
switch url {
154154
case LearnMoreViewModel.learnMoreURL:

0 commit comments

Comments
 (0)