Add description fields to POS entities

Author: joshheald

Modules/Sources/Fakes/Networking.generated.swift

@@ -753,6 +753,8 @@ extension Networking.POSProduct {
             productID: .fake(),
             name: .fake(),
             productTypeKey: .fake(),
+            fullDescription: .fake(),
+            shortDescription: .fake(),
             sku: .fake(),
             globalUniqueID: .fake(),
             price: .fake(),
@@ -776,6 +778,7 @@ extension Networking.POSProductVariation {
             productVariationID: .fake(),
             attributes: .fake(),
             image: .fake(),
+            fullDescription: .fake(),
             sku: .fake(),
             globalUniqueID: .fake(),
             price: .fake(),

Modules/Sources/Networking/Model/Copiable/Models+Copiable.generated.swift

@@ -1246,6 +1246,8 @@ extension Networking.POSProduct {
         productID: CopiableProp<Int64> = .copy,
         name: CopiableProp<String> = .copy,
         productTypeKey: CopiableProp<String> = .copy,
+        fullDescription: NullableCopiableProp<String> = .copy,
+        shortDescription: NullableCopiableProp<String> = .copy,
         sku: NullableCopiableProp<String> = .copy,
         globalUniqueID: NullableCopiableProp<String> = .copy,
         price: CopiableProp<String> = .copy,
@@ -1261,6 +1263,8 @@ extension Networking.POSProduct {
         let productID = productID ?? self.productID
         let name = name ?? self.name
         let productTypeKey = productTypeKey ?? self.productTypeKey
+        let fullDescription = fullDescription ?? self.fullDescription
+        let shortDescription = shortDescription ?? self.shortDescription
         let sku = sku ?? self.sku
         let globalUniqueID = globalUniqueID ?? self.globalUniqueID
         let price = price ?? self.price
@@ -1277,6 +1281,8 @@ extension Networking.POSProduct {
             productID: productID,
             name: name,
             productTypeKey: productTypeKey,
+            fullDescription: fullDescription,
+            shortDescription: shortDescription,
             sku: sku,
             globalUniqueID: globalUniqueID,
             price: price,
@@ -1298,6 +1304,7 @@ extension Networking.POSProductVariation {
         productVariationID: CopiableProp<Int64> = .copy,
         attributes: CopiableProp<[ProductVariationAttribute]> = .copy,
         image: NullableCopiableProp<ProductImage> = .copy,
+        fullDescription: NullableCopiableProp<String> = .copy,
         sku: NullableCopiableProp<String> = .copy,
         globalUniqueID: NullableCopiableProp<String> = .copy,
         price: CopiableProp<String> = .copy,
@@ -1311,6 +1318,7 @@ extension Networking.POSProductVariation {
         let productVariationID = productVariationID ?? self.productVariationID
         let attributes = attributes ?? self.attributes
         let image = image ?? self.image
+        let fullDescription = fullDescription ?? self.fullDescription
         let sku = sku ?? self.sku
         let globalUniqueID = globalUniqueID ?? self.globalUniqueID
         let price = price ?? self.price
@@ -1325,6 +1333,7 @@ extension Networking.POSProductVariation {
             productVariationID: productVariationID,
             attributes: attributes,
             image: image,
+            fullDescription: fullDescription,
             sku: sku,
             globalUniqueID: globalUniqueID,
             price: price,

Modules/Sources/Networking/Model/POSProduct.swift

@@ -12,6 +12,8 @@ public struct POSProduct: Codable, Equatable, GeneratedCopiable, GeneratedFakeab
     public let productID: Int64
     public let name: String
     public let productTypeKey: String
+    public let fullDescription: String?
+    public let shortDescription: String?
     public let sku: String?
     public let globalUniqueID: String?
 
@@ -44,6 +46,8 @@ public struct POSProduct: Codable, Equatable, GeneratedCopiable, GeneratedFakeab
                 productID: Int64,
                 name: String,
                 productTypeKey: String,
+                fullDescription: String?,
+                shortDescription: String?,
                 sku: String?,
                 globalUniqueID: String?,
                 price: String,
@@ -58,6 +62,8 @@ public struct POSProduct: Codable, Equatable, GeneratedCopiable, GeneratedFakeab
         self.productID = productID
         self.name = name
         self.productTypeKey = productTypeKey
+        self.fullDescription = fullDescription
+        self.shortDescription = shortDescription
         self.sku = sku
         self.globalUniqueID = globalUniqueID
 
@@ -92,6 +98,8 @@ public struct POSProduct: Codable, Equatable, GeneratedCopiable, GeneratedFakeab
         let productID = try container.decode(Int64.self, forKey: .productID)
         let name = try container.decode(String.self, forKey: .name)
         let productTypeKey = try container.decode(String.self, forKey: .productTypeKey)
+        let fullDescription = try container.decodeIfPresent(String.self, forKey: .fullDescription)
+        let shortDescription = try container.decodeIfPresent(String.self, forKey: .shortDescription)
         let sku = container.failsafeDecodeIfPresent(
             targetType: String.self,
             forKey: .sku,
@@ -119,6 +127,8 @@ public struct POSProduct: Codable, Equatable, GeneratedCopiable, GeneratedFakeab
                   productID: productID,
                   name: name,
                   productTypeKey: productTypeKey,
+                  fullDescription: fullDescription,
+                  shortDescription: shortDescription,
                   sku: sku,
                   globalUniqueID: globalUniqueID,
                   price: price,
@@ -149,6 +159,8 @@ private extension POSProduct {
         case productID = "id"
         case name
         case productTypeKey = "type"
+        case fullDescription = "description"
+        case shortDescription = "short_description"
         case sku
         case globalUniqueID = "global_unique_id"
         case price

Modules/Sources/Networking/Model/POSProductVariation.swift

@@ -17,6 +17,7 @@ public struct POSProductVariation: Codable, Equatable, GeneratedCopiable, Genera
     public let attributes: [ProductVariationAttribute]
     public let image: ProductImage?
 
+    public let fullDescription: String?
     public let sku: String?
     public let globalUniqueID: String?
 
@@ -36,6 +37,7 @@ public struct POSProductVariation: Codable, Equatable, GeneratedCopiable, Genera
                 productVariationID: Int64,
                 attributes: [ProductVariationAttribute],
                 image: ProductImage?,
+                fullDescription: String?,
                 sku: String?,
                 globalUniqueID: String?,
                 price: String,
@@ -48,6 +50,7 @@ public struct POSProductVariation: Codable, Equatable, GeneratedCopiable, Genera
         self.productVariationID = productVariationID
         self.attributes = attributes
         self.image = image
+        self.fullDescription = fullDescription
         self.sku = sku
         self.globalUniqueID = globalUniqueID
         self.price = price
@@ -71,6 +74,7 @@ public struct POSProductVariation: Codable, Equatable, GeneratedCopiable, Genera
         let productID = try container.decode(Int64.self, forKey: .productID)
         let attributes = try container.decode([ProductVariationAttribute].self, forKey: .attributes)
         let image = try container.decodeIfPresent(ProductImage.self, forKey: .image)
+        let fullDescription = try container.decodeIfPresent(String.self, forKey: .fullDescription)
         let sku = container.failsafeDecodeIfPresent(
             targetType: String.self,
             forKey: .sku,
@@ -103,6 +107,7 @@ public struct POSProductVariation: Codable, Equatable, GeneratedCopiable, Genera
                   productVariationID: productVariationID,
                   attributes: attributes,
                   image: image,
+                  fullDescription: fullDescription,
                   sku: sku,
                   globalUniqueID: globalUniqueID,
                   price: price,
@@ -133,6 +138,7 @@ private extension POSProductVariation {
         case attributes
         case image
         case price
+        case fullDescription = "description"
         case sku
         case globalUniqueID = "global_unique_id"
         case downloadable

Modules/Sources/Networking/Remote/POSCatalogSyncRemote.swift

@@ -189,6 +189,7 @@ private extension POSProduct {
             productVariationID: productID,
             attributes: variationAttributes,
             image: firstImage,
+            fullDescription: fullDescription,
             sku: sku,
             globalUniqueID: globalUniqueID,
             price: price,

Modules/Sources/Yosemite/PointOfSale/Items/POSProductOrVariationResolver.swift

@@ -83,6 +83,7 @@ private extension POSProduct {
                 productVariationID: productID,
                 attributes: try attributes.compactMap { try $0.toProductVariationAttribute() },
                 image: images.first,
+                fullDescription: fullDescription,
                 sku: sku,
                 globalUniqueID: globalUniqueID,
                 price: price,

Modules/Tests/NetworkingTests/Remote/POSCatalogSyncRemoteTests.swift

@@ -44,6 +44,8 @@ struct POSCatalogSyncRemoteTests {
         #expect(firstProduct.siteID == sampleSiteID)
         #expect(firstProduct.productID == 168)
         #expect(firstProduct.name == "Beanie")
+        #expect(firstProduct.fullDescription != nil)
+        #expect(firstProduct.shortDescription != nil)
     }
 
     @Test func loadProducts_relays_networking_error() async throws {
@@ -427,6 +429,7 @@ struct POSCatalogSyncRemoteTests {
         #expect(variation.sku == "")
         #expect(variation.globalUniqueID == "")
         #expect(variation.price == "330.34")
+        #expect(variation.fullDescription != nil)
         #expect(variation.attributes.count == 3)
         #expect(variation.image?.src == "https://example.com/wp-content/uploads/2025/08/img-quae.png")
         #expect(variation.attributes == [
@@ -471,4 +474,20 @@ struct POSCatalogSyncRemoteTests {
             try await remote.downloadCatalog(for: sampleSiteID, downloadURL: downloadURL)
         }
     }
+
+    @Test func posProductVariation_provides_field_names_for_request() {
+        let fieldNames = POSProductVariation.requestFields
+        #expect(fieldNames.contains("id"))
+        #expect(fieldNames.contains("parent_id"))
+        #expect(fieldNames.contains("attributes"))
+        #expect(fieldNames.contains("image"))
+        #expect(fieldNames.contains("price"))
+        #expect(fieldNames.contains("sku"))
+        #expect(fieldNames.contains("global_unique_id"))
+        #expect(fieldNames.contains("downloadable"))
+        #expect(fieldNames.contains("description"))
+        #expect(fieldNames.contains("manage_stock"))
+        #expect(fieldNames.contains("stock_quantity"))
+        #expect(fieldNames.contains("stock_status"))
+    }
 }

Modules/Tests/NetworkingTests/Remote/POSProductsNetworkingTests.swift

@@ -183,6 +183,8 @@ struct POSProductsNetworkingTests {
         #expect(fieldNames.contains("id"))
         #expect(fieldNames.contains("name"))
         #expect(fieldNames.contains("type"))
+        #expect(fieldNames.contains("description"))
+        #expect(fieldNames.contains("short_description"))
         #expect(fieldNames.contains("sku"))
         #expect(fieldNames.contains("global_unique_id"))
         #expect(fieldNames.contains("price"))
@@ -269,7 +271,7 @@ struct POSProductsNetworkingTests {
 
         // When
         network.simulateResponse(requestUrlSuffix: "products", filename: "pos-products")
-        let product = try await remote.loadPOSProductByGlobalUniqueIdentifier(for: sampleSiteID, globalUniqueID: globalUniqueID)
+        _ = try await remote.loadPOSProductByGlobalUniqueIdentifier(for: sampleSiteID, globalUniqueID: globalUniqueID)
 
         // Then
         let request = try #require(network.requestsForResponseData.first as? JetpackRequest)

Modules/Tests/NetworkingTests/Remote/ProductVariationsRemoteTests.swift

@@ -172,6 +172,7 @@ final class ProductVariationsRemoteTests: XCTestCase {
         }
         XCTAssertEqual(firstVariation.productVariationID, 1275)
         XCTAssertEqual(firstVariation.productID, 10275)
+        XCTAssertEqual(firstVariation.fullDescription, "<p>Nutty chocolate marble, 99% and organic.</p>\n")
         XCTAssertEqual(firstVariation.sku, "99%-nuts-marble")
         XCTAssertEqual(firstVariation.globalUniqueID, "12345")
 

Modules/Tests/NetworkingTests/Responses/products-load-pos.json

@@ -5,6 +5,8 @@
       "name": "Beanie",
       "type": "simple",
       "sku": "Woo-beanie",
+      "description": "",
+      "short_description": "",
       "price": "18",
       "regular_price": "20",
       "sale_price": "18",
@@ -48,6 +50,8 @@
       "name": "Latte",
       "type": "variable",
       "sku": "200815216",
+      "description": "",
+      "short_description": "",
       "price": "7",
       "regular_price": "",
       "sale_price": "",