Rename areFieldValuesEmpty to areFieldValuesIncomplete

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Package and Rate Selection/WooShippingAddCustomPackageViewModel.swift

@@ -43,10 +43,10 @@ final class WooShippingAddCustomPackageViewModel: ObservableObject {
         }
     }
 
-    // Field values are invalid if one of them is empty
+    // Field values are invalid if one of them is incomplete
     // - if we are saving template we check all field values
     // - if we are not saving template we check only dimensions
-    var areFieldValuesEmpty: Bool {
+    var areFieldValuesIncomplete: Bool {
         let keysToCheck: [WooShippingPackageUnitType] = showSaveTemplate ? WooShippingPackageUnitType.allCases : WooShippingPackageUnitType.dimensionUnits
 
         var validFieldsCount: Int = 0
@@ -147,7 +147,7 @@ final class WooShippingAddCustomPackageViewModel: ObservableObject {
     }
 
     func validateCustomPackageInputFields() -> Bool {
-        guard !areFieldValuesEmpty else {
+        if areFieldValuesIncomplete {
             return false
         }
         if showSaveTemplate {

WooCommerce/WooCommerceTests/ViewRelated/Shipping Label/WooShipping Create Shipping Labels/WooShippingAddCustomPackageViewModelTests.swift

@@ -29,7 +29,7 @@ final class WooShippingAddCustomPackageViewModelTests: XCTestCase {
 
         // Then
         XCTAssertEqual(viewModel.fieldValues.isEmpty, false)
-        XCTAssertEqual(viewModel.areFieldValuesEmpty, true)
+        XCTAssertEqual(viewModel.areFieldValuesIncomplete, true)
     }
 
     @MainActor
@@ -45,7 +45,7 @@ final class WooShippingAddCustomPackageViewModelTests: XCTestCase {
 
         // Then
         XCTAssertEqual(viewModel.fieldValues.isEmpty, false)
-        XCTAssertEqual(viewModel.areFieldValuesEmpty, false)
+        XCTAssertEqual(viewModel.areFieldValuesIncomplete, false)
     }
 
     @MainActor
@@ -62,7 +62,7 @@ final class WooShippingAddCustomPackageViewModelTests: XCTestCase {
 
         // Then
         XCTAssertEqual(viewModel.fieldValues.isEmpty, false)
-        XCTAssertEqual(viewModel.areFieldValuesEmpty, false)
+        XCTAssertEqual(viewModel.areFieldValuesIncomplete, false)
     }
 
     @MainActor
@@ -79,7 +79,7 @@ final class WooShippingAddCustomPackageViewModelTests: XCTestCase {
 
         // Then
         XCTAssertEqual(viewModel.fieldValues.isEmpty, false)
-        XCTAssertEqual(viewModel.areFieldValuesEmpty, true)
+        XCTAssertEqual(viewModel.areFieldValuesIncomplete, true)
     }
 
     @MainActor
@@ -96,7 +96,7 @@ final class WooShippingAddCustomPackageViewModelTests: XCTestCase {
         viewModel.fieldValues[.weight] = "1"
         // Then
         XCTAssertEqual(viewModel.fieldValues.isEmpty, false)
-        XCTAssertEqual(viewModel.areFieldValuesEmpty, false)
+        XCTAssertEqual(viewModel.areFieldValuesIncomplete, false)
     }
 
     @MainActor
@@ -390,6 +390,6 @@ extension WooShippingAddCustomPackageViewModel {
         XCTAssertEqual(packageType, WooShippingPackageType.box)
         XCTAssertEqual(showSaveTemplate, false)
         XCTAssertEqual(packageTemplateName, "")
-        XCTAssertEqual(areFieldValuesEmpty, true)
+        XCTAssertEqual(areFieldValuesIncomplete, true)
     }
 }