Fix crash on iOS 26 when converting some NSError instances to ErrorCode

staskus · staskus · commit 157cfc812956 · 2025-08-08T17:37:41.000+02:00
Some NSError values, when converted to ErrorCode using ErrorCode(_nsError:), cause a crash on iOS 26 — even if they represent known error codes like .SCPErrorCanceled.
This does not occur on iOS 18.5 (including simulators), where the same code executes without issue.
Crashes occur inconsistently across error codes and are triggered during logging or property access (e.g. print(errorCode.code)), with messages like:
Fatal error: Unknown error at SignalCompression/SignalEncoder.swift.

This commit avoids triggering such conversions/logging that may crash on iOS 26.
diff --git a/Modules/Sources/Hardware/CardReader/StripeCardReader/StripeCardReaderService.swift b/Modules/Sources/Hardware/CardReader/StripeCardReader/StripeCardReaderService.swift
@@ -1109,7 +1109,7 @@ private extension StripeCardReaderService {
             DDLogError("💳 Card Reader Config Error: \(error)")
         default:
             let errorCode = ErrorCode(_nsError: error as NSError)
-            DDLogError("💳 Stripe Error Code: \(errorCode.code)")
+            DDLogError("💳 Stripe Error Code: \(errorCode.errorCode)")
         }
         return UnderlyingError(with: error)
     }

Original file line number	Diff line number	Diff line change
`@@ -1109,7 +1109,7 @@ private extension StripeCardReaderService {`
`1109`	`1109`	`DDLogError("💳 Card Reader Config Error: \(error)")`
`1110`	`1110`	`default:`
`1111`	`1111`	`let errorCode = ErrorCode(_nsError: error as NSError)`
`1112`		`- DDLogError("💳 Stripe Error Code: \(errorCode.code)")`
	`1112`	`+ DDLogError("💳 Stripe Error Code: \(errorCode.errorCode)")`
`1113`	`1113`	`}`
`1114`	`1114`	`return UnderlyingError(with: error)`
`1115`	`1115`	`}`