Skip to content

Commit 165fdc4

Browse files
committed
Update tests
1 parent a728a0e commit 165fdc4

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

WooCommerce/WooCommerceTests/ViewRelated/Shipping Label/WooShipping Create Shipping Labels/WooShipping Customs/WooShippingCustomsItemViewModelTests.swift

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ final class WooShippingCustomsItemViewModelTests: XCTestCase {
110110
XCTAssertEqual(viewModel.hsTariffNumberTotalValue?.1, Decimal(string: viewModel.valuePerUnit)! * 2)
111111
}
112112

113-
func test_isNumberValid_withValidNumbers() {
113+
func test_isNumberValid_whenGivenValidTariffNumbers_shouldReturnTrue() {
114114
XCTAssertTrue(HSTariffNumberValidator.isNumberValid("123456"))
115115
XCTAssertTrue(HSTariffNumberValidator.isNumberValid("12.34.56"))
116116
XCTAssertTrue(HSTariffNumberValidator.isNumberValid("12.34.56.78"))
@@ -121,7 +121,7 @@ final class WooShippingCustomsItemViewModelTests: XCTestCase {
121121
XCTAssertTrue(HSTariffNumberValidator.isNumberValid("1.2.3.4.5.6"))
122122
}
123123

124-
func test_isNumberValid_withInvalidNumbers() {
124+
func test_isNumberValid_whenGivenInvalidTariffNumbers_shouldReturnFalse() {
125125
// Less than 6 digits
126126
XCTAssertFalse(HSTariffNumberValidator.isNumberValid("12345"))
127127
XCTAssertFalse(HSTariffNumberValidator.isNumberValid("12.34.5"))
@@ -138,4 +138,12 @@ final class WooShippingCustomsItemViewModelTests: XCTestCase {
138138
XCTAssertFalse(HSTariffNumberValidator.isNumberValid("12.34..56"))
139139
XCTAssertFalse(HSTariffNumberValidator.isNumberValid(".123456"))
140140
}
141+
142+
func test_hsTariffNumber_sanitize_whenGivenStringWithNonDigits_shouldReturnOnlyDigits() {
143+
XCTAssertEqual(HSTariffNumberValidator.sanitize("12.34.56"), "123456")
144+
XCTAssertEqual(HSTariffNumberValidator.sanitize("12a34b56c"), "123456")
145+
XCTAssertEqual(HSTariffNumberValidator.sanitize("...123---456..."), "123456")
146+
XCTAssertEqual(HSTariffNumberValidator.sanitize("123456"), "123456")
147+
XCTAssertEqual(HSTariffNumberValidator.sanitize(""), "")
148+
}
141149
}

0 commit comments

Comments
 (0)