Skip to content

Commit 1c75cb4

Browse files
itsmeichigoitsmeichigo
authored
Merge pull request #8531 from woocommerce/issue/8528-remove-wpcom-only-login
Simplified login: Remove A/B test
2 parents a1acb44 + 15b0cbb commit 1c75cb4

File tree

5 files changed

+11
-45
lines changed

5 files changed

+11
-45
lines changed

‎Experiments/Experiments/ABTest.swift‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ public enum ABTest: String, CaseIterable {
1515
/// Experiment ref: pbxNRc-1S0-p2
1616
case aaTestLoggedOut = "woocommerceios_explat_aa_test_logged_out_202212_v2"
1717

18-
/// A/B test to measure the sign-in success rate when only WPCom login is enabled.
19-
/// Experiment ref: pbxNRc-27s-p2
20-
///
21-
case abTestLoginWithWPComOnly = "woocommerceios_login_wpcom_only"
22-
2318
/// A/B test to measure the sign-in success rate when native Jetpack installation experience is enabled
2419
/// Experiment ref: pbxNRc-29W-p2
2520
///
@@ -37,7 +32,7 @@ public enum ABTest: String, CaseIterable {
3732
switch self {
3833
case .aaTestLoggedIn, .nativeJetpackSetupFlow:
3934
return .loggedIn
40-
case .aaTestLoggedOut, .abTestLoginWithWPComOnly:
35+
case .aaTestLoggedOut:
4136
return .loggedOut
4237
case .null:
4338
return .none

‎WooCommerce/Classes/Authentication/AuthenticationConstants.swift‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,6 @@ struct AuthenticationConstants {
2525
comment: "Sign in instructions on the 'log in using WordPress.com account' screen."
2626
)
2727

28-
/// Get started instructions when simplified login is enabled.
29-
///
30-
static let getStartedInstructionsForSimplifiedLogin = NSLocalizedString(
31-
"Enter your email address to get started.",
32-
comment: "Sign in instructions on the 'log in using WordPress.com account' screen."
33-
)
34-
3528
/// What is WordPress.com? link (Continue with WordPress.com)
3629
///
3730
static let whatIsWPComLinkTitle = NSLocalizedString(
@@ -65,13 +58,6 @@ struct AuthenticationConstants {
6558
comment: "Sign in instructions asking user to enter WordPress.com password to proceed with sign in using Apple process"
6659
)
6760

68-
/// Simplified Log In button
69-
///
70-
static let loginButtonTitle = NSLocalizedString(
71-
"Log In",
72-
comment: "Button title in the simplified login prologue screen. Takes the user to the login flow."
73-
)
74-
7561
/// Title of "Continue With WordPress.com" button in Login Prologue
7662
//
7763
static let continueWithWPButtonTitle = NSLocalizedString(

‎WooCommerce/Classes/Authentication/AuthenticationManager.swift‎

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ class AuthenticationManager: Authentication {
6969
func initialize(loggedOutAppSettings: LoggedOutAppSettingsProtocol) {
7070
let isWPComMagicLinkPreferredToPassword = featureFlagService.isFeatureFlagEnabled(.loginMagicLinkEmphasis)
7171
let isWPComMagicLinkShownAsSecondaryActionOnPasswordScreen = featureFlagService.isFeatureFlagEnabled(.loginMagicLinkEmphasisM2)
72-
let isSimplifiedLoginI1Enabled = ABTest.abTestLoginWithWPComOnly.variation != .control
7372
let isStoreCreationMVPEnabled = featureFlagService.isFeatureFlagEnabled(.storeCreationMVP)
7473
let isNativeJetpackSetupEnabled = ABTest.nativeJetpackSetupFlow.variation != .control
7574
let isWPComLoginRequiredForSiteCredentialsLogin = !featureFlagService.isFeatureFlagEnabled(.applicationPasswordAuthenticationForSiteCredentialLogin)
@@ -78,7 +77,7 @@ class AuthenticationManager: Authentication {
7877
wpcomScheme: ApiCredentials.dotcomAuthScheme,
7978
wpcomTermsOfServiceURL: WooConstants.URLs.termsOfService.rawValue,
8079
wpcomAPIBaseURL: Settings.wordpressApiBaseURL,
81-
whatIsWPComURL: isSimplifiedLoginI1Enabled ? nil : WooConstants.URLs.whatIsWPCom.rawValue,
80+
whatIsWPComURL: WooConstants.URLs.whatIsWPCom.rawValue,
8281
googleLoginClientId: ApiCredentials.googleClientId,
8382
googleLoginServerClientId: ApiCredentials.googleServerId,
8483
googleLoginScheme: ApiCredentials.googleAuthScheme,
@@ -94,9 +93,9 @@ class AuthenticationManager: Authentication {
9493
isWPComMagicLinkPreferredToPassword: isWPComMagicLinkPreferredToPassword,
9594
isWPComMagicLinkShownAsSecondaryActionOnPasswordScreen:
9695
isWPComMagicLinkShownAsSecondaryActionOnPasswordScreen,
97-
enableWPComLoginOnlyInPrologue: isSimplifiedLoginI1Enabled,
96+
enableWPComLoginOnlyInPrologue: false,
9897
enableSiteCreation: isStoreCreationMVPEnabled,
99-
enableSocialLogin: !isSimplifiedLoginI1Enabled,
98+
enableSocialLogin: true,
10099
emphasizeEmailForWPComPassword: true,
101100
wpcomPasswordInstructions:
102101
AuthenticationConstants.wpcomPasswordInstructions,
@@ -134,17 +133,11 @@ class AuthenticationManager: Authentication {
134133
LoginPrologueViewController(isFeatureCarouselShown: false),
135134
statusBarStyle: .default)
136135

137-
let getStartedInstructions = isSimplifiedLoginI1Enabled ?
138-
AuthenticationConstants.getStartedInstructionsForSimplifiedLogin :
139-
AuthenticationConstants.getStartedInstructions
136+
let getStartedInstructions = AuthenticationConstants.getStartedInstructions
140137

141-
let continueWithWPButtonTitle = isSimplifiedLoginI1Enabled ?
142-
AuthenticationConstants.loginButtonTitle :
143-
AuthenticationConstants.continueWithWPButtonTitle
138+
let continueWithWPButtonTitle = AuthenticationConstants.continueWithWPButtonTitle
144139

145-
let emailAddressPlaceholder = isSimplifiedLoginI1Enabled ?
146-
"[email protected]" :
147-
WordPressAuthenticatorDisplayStrings.defaultStrings.emailAddressPlaceholder
140+
let emailAddressPlaceholder = WordPressAuthenticatorDisplayStrings.defaultStrings.emailAddressPlaceholder
148141

149142
let displayStrings = WordPressAuthenticatorDisplayStrings(emailLoginInstructions: AuthenticationConstants.emailInstructions,
150143
getStartedInstructions: getStartedInstructions,

‎WooCommerce/Classes/Authentication/Prologue/LoginProloguePages.swift‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ enum LoginProloguePageType: CaseIterable {
1010
case products
1111
case reviews
1212
case getStarted
13-
case simplifiedLoginI1Intro
1413

1514
var title: String {
1615
switch self {
@@ -26,7 +25,7 @@ enum LoginProloguePageType: CaseIterable {
2625
case .reviews:
2726
return NSLocalizedString("Monitor and approve your product reviews",
2827
comment: "Caption displayed in promotional screens shown during the login flow.")
29-
case .getStarted, .simplifiedLoginI1Intro:
28+
case .getStarted:
3029
return NSLocalizedString("WooCommerce is a customizable, open-source eCommerce platform built on WordPress.",
3130
comment: "Caption displayed in the simplified prologue screen")
3231
}
@@ -58,7 +57,7 @@ enum LoginProloguePageType: CaseIterable {
5857
return UIImage.prologueProductsImage
5958
case .reviews:
6059
return UIImage.prologueReviewsImage
61-
case .getStarted, .simplifiedLoginI1Intro:
60+
case .getStarted:
6261
return UIImage.prologueWooMobileImage
6362
}
6463
}
@@ -144,7 +143,7 @@ private extension LoginProloguePageTypeViewController {
144143

145144
// Label style & layout
146145
titleLabel.font = {
147-
if pageType == .simplifiedLoginI1Intro || pageType == .getStarted {
146+
if pageType == .getStarted {
148147
return .headline
149148
} else if showsSubtitle {
150149
return .font(forStyle: .title2, weight: .semibold)

‎WooCommerce/Classes/Authentication/Prologue/LoginPrologueViewController.swift‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ final class LoginPrologueViewController: UIViewController {
1212
private let isFeatureCarouselShown: Bool
1313
private let analytics: Analytics
1414
private let featureFlagService: FeatureFlagService
15-
private let isSimplifiedLogin: Bool
1615

1716
/// Background View, to be placed surrounding the bottom area.
1817
///
@@ -45,7 +44,6 @@ final class LoginPrologueViewController: UIViewController {
4544
self.isFeatureCarouselShown = isFeatureCarouselShown
4645
self.analytics = analytics
4746
self.featureFlagService = featureFlagService
48-
self.isSimplifiedLogin = ABTest.abTestLoginWithWPComOnly.variation != .control
4947
super.init(nibName: nil, bundle: nil)
5048
}
5149

@@ -99,8 +97,6 @@ private extension LoginPrologueViewController {
9997
let pageTypes: [LoginProloguePageType] = {
10098
if isFeatureCarouselShown {
10199
return [.stats, .orderManagement, .products, .reviews]
102-
} else if isSimplifiedLogin {
103-
return [.simplifiedLoginI1Intro]
104100
} else {
105101
return [.getStarted]
106102
}
@@ -127,7 +123,7 @@ private extension LoginPrologueViewController {
127123
guard isNewToWooCommerceButtonShown else {
128124
return newToWooCommerceButton.isHidden = true
129125
}
130-
let title = isSimplifiedLogin ? Localization.learnMoreAboutWoo : Localization.newToWooCommerce
126+
let title = Localization.newToWooCommerce
131127
newToWooCommerceButton.setTitle(title, for: .normal)
132128
newToWooCommerceButton.applyLinkButtonStyle()
133129
newToWooCommerceButton.titleLabel?.numberOfLines = 0
@@ -155,8 +151,5 @@ private extension LoginPrologueViewController {
155151
enum Localization {
156152
static let newToWooCommerce = NSLocalizedString("New to WooCommerce?",
157153
comment: "Title of button in the login prologue screen for users who are new to WooCommerce.")
158-
static let learnMoreAboutWoo = NSLocalizedString("Learn more about WooCommerce",
159-
comment: "Title of button in the simplified login prologue screen " +
160-
"for learning more about WooCommerce.")
161154
}
162155
}

0 commit comments

Comments
 (0)