Move locale based POS tab visibility from FeatureFlagAction.isRemoteFeatureFlagEnabled to SettingAction.isFeatureEnabled because the remote feature flag still falls back to local feature flag which results in all locales seeing the POS tab.

Author: jaclync

Modules/Sources/Yosemite/Model/Mocks/ActionHandlers/MockSettingActionHandler.swift

@@ -28,8 +28,14 @@ struct MockSettingActionHandler: MockActionHandler {
         case .isFeatureEnabled(_, let feature, let onCompletion):
             switch feature {
             case .pointOfSale:
-                // One of the requirements for the POS tab to show up.
-                onCompletion(.success(true))
+                // Only enables POS feature for eligible locales (US and UK variants).
+                let locale = Locale.current
+                let localeIdentifier = locale.identifier
+                let isEligibleCountry = localeIdentifier.hasPrefix("en_US") ||
+                                       localeIdentifier.hasPrefix("en_GB") ||
+                                       localeIdentifier == "en-US" ||
+                                       localeIdentifier == "en-GB"
+                onCompletion(.success(isEligibleCountry))
             }
         default: unimplementedAction(action: action)
         }

Modules/Sources/Yosemite/Model/Mocks/MockStoresManager.swift

@@ -166,11 +166,7 @@ public class MockStoresManager: StoresManager {
         case let action as FeatureFlagAction:
             switch action {
             case let .isRemoteFeatureFlagEnabled(_, _, completion):
-                // Only enables POS feature for eligible countries from locale.
-                let locale = Locale.current
-                let countryCode = locale.region?.identifier ?? ""
-                let isEligibleCountry = countryCode == "US" || countryCode == "GB"
-                completion(isEligibleCountry)
+                completion(true)
             }
         default:
             fatalError("Unable to handle action: \(action.identifier) \(String(describing: action))")