Merge pull request #8699 from woocommerce/issue/8577-warn-about-variations

Bulk Editing: Warn about variations in price flow

Author: ealeksandrov

WooCommerce/Classes/ViewRelated/Products/PriceInputViewModel.swift

@@ -86,20 +86,29 @@ final class PriceInputViewModel {
     /// Returns the footer text to be displayed with information about the current bulk price and how many products will be updated.
     ///
     var footerText: String {
-        let numberOfProducts = productListViewModel.selectedProductsCount
-        let numberOfProductsText = String.pluralize(numberOfProducts,
-                                                      singular: Localization.productsNumberSingularFooter,
-                                                      plural: Localization.productsNumberPluralFooter)
+        var footerData: [String] = []
 
         switch productListViewModel.commonPriceForSelectedProducts {
         case .none:
-            return [Localization.currentPriceNoneFooter, numberOfProductsText].joined(separator: " ")
+            footerData.append(Localization.currentPriceNoneFooter)
         case .mixed:
-            return [Localization.currentPriceMixedFooter, numberOfProductsText].joined(separator: " ")
+            footerData.append(Localization.currentPriceMixedFooter)
         case let .value(price):
             let currentPriceText = String.localizedStringWithFormat(Localization.currentPriceFooter, formatPriceString(price))
-            return [currentPriceText, numberOfProductsText].joined(separator: " ")
+            footerData.append(currentPriceText)
+        }
+
+        if productListViewModel.selectedVariableProductsCount > 0 {
+            footerData.append(Localization.variationsWarning)
         }
+
+        let numberOfProducts = productListViewModel.selectedProductsCount - productListViewModel.selectedVariableProductsCount
+        let numberOfProductsText = String.pluralize(numberOfProducts,
+                                                    singular: Localization.productsNumberSingularFooter,
+                                                    plural: Localization.productsNumberPluralFooter)
+        footerData.append(numberOfProductsText)
+
+        return footerData.joined(separator: " ")
     }
 
     /// It formats a price `String` according to the current price settings.
@@ -134,5 +143,7 @@ private extension PriceInputViewModel {
         static let currentPriceNoneFooter = NSLocalizedString("Current price is not set.",
                                                               comment: "Message in the footer of bulk price setting screen, when none of the"
                                                               + " products have price value.")
+        static let variationsWarning = NSLocalizedString("Prices for variations won't be updated.",
+                                                         comment: "Message in the footer of bulk price setting screen, when variable products are selected")
     }
 }

WooCommerce/Classes/ViewRelated/Products/ProductsListViewModel.swift

@@ -23,6 +23,14 @@ class ProductListViewModel {
         selectedProducts.count
     }
 
+    var selectedVariableProductsCount: Int {
+        selectedProducts.filter({ $0.productType == .variable }).count
+    }
+
+    var onlyVariableProductsSelected: Bool {
+        selectedProducts.filter({ $0.productType != .variable }).isEmpty
+    }
+
     var bulkEditActionIsEnabled: Bool {
         !selectedProducts.isEmpty
     }

WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift

@@ -363,7 +363,9 @@ private extension ProductsViewController {
         let cancelAction = UIAlertAction(title: Localization.cancel, style: .cancel)
 
         actionSheet.addAction(updateStatus)
-        actionSheet.addAction(updatePrice)
+        if !viewModel.onlyVariableProductsSelected {
+            actionSheet.addAction(updatePrice)
+        }
         actionSheet.addAction(cancelAction)
 
         if let popoverController = actionSheet.popoverPresentationController {

WooCommerce/WooCommerceTests/ViewRelated/Products/ProductListViewModelTests.swift

@@ -139,6 +139,30 @@ final class ProductListViewModelTests: XCTestCase {
         XCTAssertEqual(viewModel.selectedProductsCount, 0)
     }
 
+    func test_variation_helpers_work_correctly() {
+        // Given
+        let viewModel = ProductListViewModel(siteID: sampleSiteID, stores: storesManager)
+        let sampleProduct1 = Product.fake().copy(productID: 1)
+        let sampleProduct2 = Product.fake().copy(productID: 2, productTypeKey: "variable")
+
+        // When
+        viewModel.selectProduct(sampleProduct1)
+        viewModel.selectProduct(sampleProduct2)
+
+        // Then
+        XCTAssertEqual(viewModel.selectedProductsCount, 2)
+        XCTAssertEqual(viewModel.selectedVariableProductsCount, 1)
+        XCTAssertFalse(viewModel.onlyVariableProductsSelected)
+
+        // When
+        viewModel.deselectProduct(sampleProduct1)
+
+        // Then
+        XCTAssertEqual(viewModel.selectedProductsCount, 1)
+        XCTAssertEqual(viewModel.selectedVariableProductsCount, 1)
+        XCTAssertTrue(viewModel.onlyVariableProductsSelected)
+    }
+
     func test_common_status_works_correctly() {
         // Given
         let viewModel = ProductListViewModel(siteID: sampleSiteID, stores: storesManager)