Dashboard: Fix workaround for stock card (#13648)

Author: itsmeichigo

RELEASE-NOTES.txt

@@ -24,6 +24,8 @@
 - [*] Payments: Fixed issue where new WooPayments accounts couldn't be used for In Person Payments while they were pending verification [https://github.com/woocommerce/woocommerce-ios/pull/13610]
 - [Internal] Custom Fields: Started effort to rename OrderMetaData to MetaData to share it with Products, starting with Networking layer. [https://github.com/woocommerce/woocommerce-ios/pull/13620]
 - [*] Login: Hid the site credential login option when entering a WPCom site address. [https://github.com/woocommerce/woocommerce-ios/pull/13623]
+- [Internal] Beta fix: Fixed unreliable states of the Inbox screen when navigated from the Hub Menu. [https://github.com/woocommerce/woocommerce-ios/pull/13645]
+- [Internal] Beta fix: Fixed navigation to variations in stock card for some stores. [https://github.com/woocommerce/woocommerce-ios/pull/13648]
 
 19.9
 -----

WooCommerce/Classes/ViewRelated/Dashboard/ProductStock/ProductStockDashboardCardViewModel.swift

@@ -169,9 +169,12 @@ private extension ProductStockDashboardCardViewModel {
                     return reports.map { report in
                         guard let variationID = report.variationID,
                               report.productID == 0,
-                              let parentID = stock.first(where: { $0.productID == variationID })?.productID else {
+                              let parentID = stock.first(where: { $0.productID == variationID })?.parentID else {
                             return report
                         }
+                        /// For some stores, the product ID is not found for variations returned from variation reports.
+                        /// We need to copy the parent ID from the stock report over to the variation reports
+                        /// to be able to show the details for the variation upon selection.
                         return report.copy(productID: parentID)
                     }
                 }

WooCommerce/WooCommerceTests/ViewRelated/Dashboard/ProductStockDashboardCardViewModelTests.swift

@@ -73,6 +73,43 @@ final class ProductStockDashboardCardViewModelTests: XCTestCase {
         XCTAssertEqual(viewModel.reports, [variationReport, productReport])
     }
 
+    @MainActor
+    func test_reloadData_updates_missing_parent_ids_for_variation_reports() async {
+        // Given
+        let siteID: Int64 = 123
+        let stores = MockStoresManager(sessionManager: .makeForTesting())
+        let viewModel = ProductStockDashboardCardViewModel(siteID: siteID, stores: stores)
+
+        let variation = ProductStock.fake().copy(siteID: siteID, productID: 44, parentID: 40)
+
+        let thumbnailURL = "https://example.com/image.jpg"
+        let variationReport = ProductReport.fake().copy(productID: 0, // missing product ID happens to some stores
+                                                        variationID: variation.productID,
+                                                        name: "Pizza - Large, Seafood, Spicy",
+                                                        imageURL: nil,
+                                                        itemsSold: 8,
+                                                        stockQuantity: 3)
+        XCTAssertTrue(viewModel.reports.isEmpty)
+
+        // When
+        stores.whenReceivingAction(ofType: ProductAction.self) { action in
+            switch action {
+            case let .fetchStockReport(_, _, _, _, _, completion):
+                completion(.success([variation]))
+            case let .fetchVariationReports(_, productIDs, variationIDs, _, _, _, _, _, _, _, completion):
+                XCTAssertEqual(productIDs, [variation.parentID])
+                XCTAssertEqual(variationIDs, [variation.productID])
+                completion(.success([variationReport]))
+            default:
+                break
+            }
+        }
+        await viewModel.reloadData()
+
+        // Then
+        XCTAssertEqual(viewModel.reports, [variationReport.copy(productID: variation.parentID)])
+    }
+
     @MainActor
     func test_reloadData_relays_error_when_one_of_the_requests_fail() async {
         // Given