Merge pull request #9818 from woocommerce/feat/9817-share-only-if-public-site

Enable "Share Product" only for public site

Author: selanthiraiyan

WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductCoordinator.swift

@@ -244,7 +244,8 @@ private extension AddProductCoordinator {
             guard let self else { return }
             self.onProductCreated(product)
             if self.isFirstProduct, let url = URL(string: product.permalink) {
-                self.showFirstProductCreatedView(productURL: url)
+                self.showFirstProductCreatedView(productURL: url,
+                                                 showShareProductButton: viewModel.canShareProduct())
             }
         }
         let viewController = ProductFormViewController(viewModel: viewModel,
@@ -303,8 +304,9 @@ private extension AddProductCoordinator {
 
     /// Presents the celebratory view for the first created product.
     ///
-    func showFirstProductCreatedView(productURL: URL) {
-        let viewController = FirstProductCreatedHostingController(productURL: productURL)
+    func showFirstProductCreatedView(productURL: URL, showShareProductButton: Bool) {
+        let viewController = FirstProductCreatedHostingController(productURL: productURL,
+                                                                  showShareProductButton: showShareProductButton)
         navigationController.present(UINavigationController(rootViewController: viewController), animated: true)
     }
 }

WooCommerce/Classes/ViewRelated/Products/Add Product/FirstProductCreatedView.swift

@@ -2,8 +2,9 @@ import ConfettiSwiftUI
 import SwiftUI
 
 final class FirstProductCreatedHostingController: UIHostingController<FirstProductCreatedView> {
-    init(productURL: URL) {
-        super.init(rootView: FirstProductCreatedView())
+    init(productURL: URL,
+         showShareProductButton: Bool) {
+        super.init(rootView: FirstProductCreatedView(showShareProductButton: showShareProductButton))
         rootView.onSharingProduct = { [weak self] in
             guard let self else { return }
             SharingHelper.shareURL(url: productURL, from: self.view, in: self)
@@ -38,6 +39,7 @@ private extension FirstProductCreatedHostingController {
 /// Celebratory screen after creating the first product 🎉
 ///
 struct FirstProductCreatedView: View {
+    let showShareProductButton: Bool
     var onSharingProduct: () -> Void = {}
     @State private var confettiCounter: Int = 0
 
@@ -51,10 +53,13 @@ struct FirstProductCreatedView: View {
                 Text(Localization.message)
                     .secondaryBodyStyle()
                     .multilineTextAlignment(.center)
+
                 Button(Localization.shareAction,
                        action: onSharingProduct)
-                    .buttonStyle(PrimaryButtonStyle())
-                    .padding(.horizontal)
+                .buttonStyle(PrimaryButtonStyle())
+                .padding(.horizontal)
+                .renderedIf(showShareProductButton)
+
                 Spacer()
             }
             .padding()
@@ -93,11 +98,14 @@ private extension FirstProductCreatedView {
 
 struct FirstProductCreatedView_Previews: PreviewProvider {
     static var previews: some View {
-        FirstProductCreatedView()
-        .environment(\.colorScheme, .light)
+        FirstProductCreatedView(showShareProductButton: true)
+            .environment(\.colorScheme, .light)
+
+        FirstProductCreatedView(showShareProductButton: false)
+            .environment(\.colorScheme, .light)
 
-        FirstProductCreatedView()
-        .environment(\.colorScheme, .dark)
-        .previewInterfaceOrientation(.landscapeLeft)
+        FirstProductCreatedView(showShareProductButton: false)
+            .environment(\.colorScheme, .dark)
+            .previewInterfaceOrientation(.landscapeLeft)
     }
 }

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewModel.swift

@@ -261,7 +261,7 @@ extension ProductFormViewModel {
     }
 
     func canShareProduct() -> Bool {
-        formType != .add
+        stores.sessionManager.defaultSite?.isPublic == true && formType != .add
     }
 
     func canDeleteProduct() -> Bool {

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductVariationFormViewModel.swift

@@ -167,7 +167,7 @@ extension ProductVariationFormViewModel {
     }
 
     func canShareProduct() -> Bool {
-        formType != .add
+        storesManager.sessionManager.defaultSite?.isPublic == true && formType != .add
     }
 
     func canDeleteProduct() -> Bool {

WooCommerce/WooCommerceTests/ViewRelated/Products/Edit Product/ProductFormViewModelTests.swift

@@ -82,7 +82,10 @@ final class ProductFormViewModelTests: XCTestCase {
     func test_edit_product_form_with_published_status_can_share_product() {
         // Arrange
         let product = Product.fake().copy(name: "Test", statusKey: ProductStatus.published.rawValue)
-        let viewModel = createViewModel(product: product, formType: .edit)
+        let sessionManager = SessionManager.makeForTesting()
+        sessionManager.defaultSite = Site.fake().copy(isPublic: true)
+        let stores = MockStoresManager(sessionManager: sessionManager)
+        let viewModel = createViewModel(product: product, formType: .edit, stores: stores)
 
         // Action
         let canShareProduct = viewModel.canShareProduct()
@@ -106,7 +109,10 @@ final class ProductFormViewModelTests: XCTestCase {
     func test_edit_product_form_with_non_published_status_can_share_product() {
         // Arrange
         let product = Product.fake().copy(name: "Test", statusKey: ProductStatus.pending.rawValue)
-        let viewModel = createViewModel(product: product, formType: .edit)
+        let sessionManager = SessionManager.makeForTesting()
+        sessionManager.defaultSite = Site.fake().copy(isPublic: true)
+        let stores = MockStoresManager(sessionManager: sessionManager)
+        let viewModel = createViewModel(product: product, formType: .edit, stores: stores)
 
         // Action
         let canShareProduct = viewModel.canShareProduct()
@@ -127,6 +133,21 @@ final class ProductFormViewModelTests: XCTestCase {
         XCTAssertFalse(canShareProduct)
     }
 
+    func test_edit_product_form_with_non_public_site_cannot_share_product() {
+        // Given
+        let product = Product.fake().copy(name: "Test", statusKey: ProductStatus.published.rawValue)
+        let sessionManager = SessionManager.makeForTesting()
+        sessionManager.defaultSite = Site.fake().copy(isPublic: false)
+        let stores = MockStoresManager(sessionManager: sessionManager)
+        let viewModel = createViewModel(product: product, formType: .edit, stores: stores)
+
+        // When
+        let canShareProduct = viewModel.canShareProduct()
+
+        // Then
+        XCTAssertFalse(canShareProduct)
+    }
+
     // MARK: `canDeleteProduct`
 
     func test_edit_product_form_with_published_status_can_delete_product() {
@@ -349,7 +370,7 @@ final class ProductFormViewModelTests: XCTestCase {
 
     func test_action_buttons_for_existing_published_product_and_no_pending_changes() {
         // Given
-        sessionManager.defaultSite = Site.fake().copy(frameNonce: "abc123")
+        sessionManager.defaultSite = Site.fake().copy(frameNonce: "abc123", isPublic: true)
         let product = Product.fake().copy(productID: 123, statusKey: ProductStatus.published.rawValue)
         let viewModel = createViewModel(product: product, formType: .edit, stores: stores)
 
@@ -416,7 +437,7 @@ final class ProductFormViewModelTests: XCTestCase {
 
     func test_action_buttons_for_any_product_in_read_only_mode() {
         // Given
-        sessionManager.defaultSite = Site.fake().copy(frameNonce: "abc123")
+        sessionManager.defaultSite = Site.fake().copy(frameNonce: "abc123", isPublic: true)
         let product = Product.fake().copy(productID: 123, statusKey: ProductStatus.published.rawValue)
         let viewModel = createViewModel(product: product, formType: .readonly, stores: stores)
         viewModel.updateName("new name")

WooCommerce/WooCommerceTests/ViewRelated/Products/Edit Product/ProductVariationFormViewModelTests.swift

@@ -60,7 +60,10 @@ final class ProductVariationFormViewModelTests: XCTestCase {
     func test_edit_product_variation_form_with_published_status_can_share_product() {
         // Given
         let product = ProductVariation.fake().copy(status: ProductStatus.published)
-        let viewModel = createViewModel(product: product, formType: .edit)
+        let sessionManager = SessionManager.makeForTesting()
+        sessionManager.defaultSite = Site.fake().copy(isPublic: true)
+        let stores = MockStoresManager(sessionManager: sessionManager)
+        let viewModel = createViewModel(product: product, formType: .edit, stores: stores)
 
         // When
         let canShareProduct = viewModel.canShareProduct()
@@ -84,7 +87,10 @@ final class ProductVariationFormViewModelTests: XCTestCase {
     func test_edit_product_variation_form_with_non_published_status_can_share_product() {
         // Given
         let product = ProductVariation.fake().copy(status: ProductStatus.pending)
-        let viewModel = createViewModel(product: product, formType: .edit)
+        let sessionManager = SessionManager.makeForTesting()
+        sessionManager.defaultSite = Site.fake().copy(isPublic: true)
+        let stores = MockStoresManager(sessionManager: sessionManager)
+        let viewModel = createViewModel(product: product, formType: .edit, stores: stores)
 
         // When
         let canShareProduct = viewModel.canShareProduct()
@@ -105,6 +111,20 @@ final class ProductVariationFormViewModelTests: XCTestCase {
         XCTAssertFalse(canShareProduct)
     }
 
+    func test_edit_product_form_with_non_public_site_cannot_share_product() {
+        // Given
+        let product = ProductVariation.fake().copy(status: ProductStatus.published)
+        let sessionManager = SessionManager.makeForTesting()
+        sessionManager.defaultSite = Site.fake().copy(isPublic: false)
+        let stores = MockStoresManager(sessionManager: sessionManager)
+        let viewModel = createViewModel(product: product, formType: .edit, stores: stores)
+
+        // When
+        let canShareProduct = viewModel.canShareProduct()
+
+        // Then
+        XCTAssertFalse(canShareProduct)
+    }
 }
 
 private extension ProductVariationFormViewModelTests {