Observe mocked item instead of storage item

Author: itsmeichigo

Modules/Sources/Networking/Model/Stats/TopEarnerStatsItem.swift

@@ -73,3 +73,91 @@ extension TopEarnerStatsItem: Identifiable {
         productID
     }
 }
+
+// MARK: - Helper to init Product
+//
+public extension Product {
+    init(siteID: Int64,
+         productID: Int64,
+         name: String,
+         images: [ProductImage]) {
+        self.init(siteID: siteID,
+                  productID: productID,
+                  name: name,
+                  slug: "",
+                  permalink: "",
+                  date: Date(),
+                  dateCreated: Date(),
+                  dateModified: nil,
+                  dateOnSaleStart: nil,
+                  dateOnSaleEnd: nil,
+                  productTypeKey: ProductType.simple.rawValue,
+                  statusKey: ProductStatus.draft.rawValue,
+                  featured: false,
+                  catalogVisibilityKey: ProductCatalogVisibility.visible.rawValue,
+                  fullDescription: "",
+                  shortDescription: "",
+                  sku: "",
+                  globalUniqueID: "",
+                  price: "",
+                  regularPrice: "",
+                  salePrice: "",
+                  onSale: false,
+                  purchasable: false,
+                  totalSales: 0,
+                  virtual: false,
+                  downloadable: false,
+                  downloads: [],
+                  downloadLimit: -1,
+                  downloadExpiry: -1,
+                  buttonText: "",
+                  externalURL: "",
+                  taxStatusKey: ProductTaxStatus.taxable.rawValue,
+                  taxClass: "",
+                  manageStock: false,
+                  stockQuantity: nil,
+                  stockStatusKey: ProductStockStatus.inStock.rawValue,
+                  backordersKey: ProductBackordersSetting.notAllowed.rawValue,
+                  backordersAllowed: false,
+                  backordered: false,
+                  soldIndividually: false,
+                  weight: "",
+                  dimensions: ProductDimensions(length: "", width: "", height: ""),
+                  shippingRequired: true,
+                  shippingTaxable: true,
+                  shippingClass: "",
+                  shippingClassID: 0,
+                  productShippingClass: nil,
+                  reviewsAllowed: true,
+                  averageRating: "",
+                  ratingCount: 0,
+                  relatedIDs: [],
+                  upsellIDs: [],
+                  crossSellIDs: [],
+                  parentID: 0,
+                  purchaseNote: "",
+                  categories: [],
+                  tags: [],
+                  images: images,
+                  attributes: [],
+                  defaultAttributes: [],
+                  variations: [],
+                  groupedProducts: [],
+                  menuOrder: 0,
+                  addOns: [],
+                  isSampleItem: false,
+                  bundleStockStatus: nil,
+                  bundleStockQuantity: nil,
+                  bundleMinSize: nil,
+                  bundleMaxSize: nil,
+                  bundledItems: [],
+                  password: nil,
+                  compositeComponents: [],
+                  subscription: nil,
+                  minAllowedQuantity: nil,
+                  maxAllowedQuantity: nil,
+                  groupOfQuantity: nil,
+                  combineVariationQuantities: nil,
+                  customFields: [])
+    }
+}

WooCommerce/Classes/ViewRelated/Dashboard/TopPerformers/TopPerformersDashboardViewModel.swift

@@ -232,19 +232,32 @@ private extension TopPerformersDashboardViewModel {
             .store(in: &subscriptions)
     }
 
-    func observeProducts(ids: [Int64]) {
+    func observeProducts(for items: [TopEarnerStatsItem]) {
+        let ids = items.map { $0.productID }
         entityListeners = entityListeners.filter { ids.contains($0.key) }
-        for id in ids {
-            if entityListeners[id] == nil, let listener = createProductEntityListener(id: id) {
-                entityListeners[id] = listener
+        for item in items {
+            if entityListeners[item.productID] == nil {
+                let listener = createProductEntityListener(for: item)
+                entityListeners[item.productID] = listener
             }
         }
     }
 
-    func createProductEntityListener(id: Int64) -> EntityListener<Product>? {
-        guard var product = storageManager.viewStorage.loadProduct(siteID: siteID, productID: id)?.toReadOnly() else {
-            return nil
-        }
+    func createProductEntityListener(for item: TopEarnerStatsItem) -> EntityListener<Product> {
+        /// Mock product item out of info from top start item
+        var product = Product(
+            siteID: siteID,
+            productID: item.productID,
+            name: item.productName ?? "",
+            images: [ProductImage(
+                imageID: -1,
+                dateCreated: Date(),
+                dateModified: nil,
+                src: item.imageUrl ?? "",
+                name: nil,
+                alt: nil)
+            ]
+        )
         let entityListener = EntityListener(storageManager: ServiceLocator.storageManager, readOnlyEntity: product)
         entityListener.onUpsert = { [weak self] updatedProduct in
             // reload stats if there are changes to product
@@ -306,10 +319,11 @@ private extension TopPerformersDashboardViewModel {
             return
         }
         guard let items = topEarnerStats?.items?.sorted(by: >), items.isNotEmpty else {
+            entityListeners = [:]
             return periodViewModel.update(state: .loaded(rows: []))
         }
         periodViewModel.update(state: .loaded(rows: items))
-        observeProducts(ids: items.map { $0.productID })
+        observeProducts(for: items)
     }
 
     func createResultsController(timeRange: StatsTimeRangeV4) -> ResultsController<StorageTopEarnerStats> {