Skip to content

Commit 25a2033

Browse files
authored
Shipping Labels: Display base rate on service card (#15916)
2 parents 21e9663 + e064558 commit 25a2033

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
-----
66
- [**] Order Details: Update Shipping Labels section for stores with Woo Shipping extension [https://github.com/woocommerce/woocommerce-ios/pull/15889]
77
- [*] Order List: New orders made through Point of Sale are now filterable via the Order List filters menu [https://github.com/woocommerce/woocommerce-ios/pull/15910]
8+
- [*] Shipping Labels: Display base rate on selected shipping service cards [https://github.com/woocommerce/woocommerce-ios/pull/15916]
89

910
22.8
1011
-----

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Package and Rate Selection/WooShippingServiceCardViewModel.swift

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -129,17 +129,7 @@ final class WooShippingServiceCardViewModel: Identifiable, ObservableObject {
129129
}
130130
}()
131131

132-
let rateLabel = {
133-
let selectedRate = WooShippingSelectedRate(
134-
rate: rate,
135-
signatureRate: signatureRequirement == .signatureRequired ? signatureRate : nil,
136-
adultSignatureRate: signatureRequirement == .adultSignatureRequired ? adultSignatureRate : nil,
137-
carbonNeutralRate: carbonNeutralSelected ? carbonNeutralRate : nil,
138-
saturdayDeliveryRate: saturdayDeliverySelected ? saturdayDeliveryRate : nil,
139-
additionalHandlingRate: additionalHandlingSelected ? additionalHandlingRate : nil
140-
)
141-
return currencyFormatter.formatAmount(Decimal(selectedRate.totalRate)) ?? ""
142-
}()
132+
let rateLabel = currencyFormatter.formatAmount(Decimal(rate.rate)) ?? ""
143133

144134
let daysToDeliveryLabel: String? = {
145135
guard let deliveryDays = rate.deliveryDays else {

WooCommerce/WooCommerceTests/ViewRelated/Shipping Label/WooShipping Create Shipping Labels/WooShippingServiceCardViewModelTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ final class WooShippingServiceCardViewModelTests: XCTestCase {
1919
XCTAssertEqual(viewModel.signatureRequirement, .signatureRequired)
2020
XCTAssertEqual(viewModel.title, "USPS - Parcel Select Mail")
2121
XCTAssertEqual(viewModel.daysToDeliveryLabel, "2 business days")
22-
XCTAssertEqual(viewModel.rateLabel, "$45.99")
22+
XCTAssertEqual(viewModel.rateLabel, "$40.33")
2323
XCTAssertEqual(viewModel.carrierLogo, UIImage(named: "shipping-label-usps-logo"))
2424
XCTAssertEqual(viewModel.trackingLabel, "Tracking")
2525
XCTAssertEqual(viewModel.insuranceLabel, "Insurance (up to $100.00)")
@@ -69,7 +69,7 @@ final class WooShippingServiceCardViewModelTests: XCTestCase {
6969
XCTAssertEqual(viewModel.signatureRequirement, .signatureRequired)
7070
XCTAssertEqual(viewModel.title, "USPS - Parcel Select Mail")
7171
XCTAssertEqual(viewModel.daysToDeliveryLabel, "2 business days")
72-
XCTAssertEqual(viewModel.rateLabel, "$65.58")
72+
XCTAssertEqual(viewModel.rateLabel, "$40.33")
7373
XCTAssertEqual(viewModel.carrierLogo, UIImage(named: "shipping-label-usps-logo"))
7474
XCTAssertEqual(viewModel.trackingLabel, "Tracking")
7575
XCTAssertEqual(viewModel.insuranceLabel, "Insurance (up to $100.00)")
@@ -102,7 +102,7 @@ final class WooShippingServiceCardViewModelTests: XCTestCase {
102102
XCTAssertEqual(viewModel.signatureRequirement, .signatureRequired)
103103
XCTAssertEqual(viewModel.title, "USPS - Parcel Select Mail")
104104
XCTAssertEqual(viewModel.daysToDeliveryLabel, "2 business days")
105-
XCTAssertEqual(viewModel.rateLabel, "$38.84")
105+
XCTAssertEqual(viewModel.rateLabel, "$25.95")
106106
XCTAssertEqual(viewModel.carrierLogo, UIImage(named: "shipping-label-usps-logo"))
107107
XCTAssertEqual(viewModel.trackingLabel, "Tracking")
108108
XCTAssertEqual(viewModel.insuranceLabel, "Insurance (up to $100.00)")

0 commit comments

Comments
 (0)