Type-erase WCSettingsWebView through externalViews

Author: staskus

WooCommerce/Classes/POS/Adaptors/POSServiceLocatorAdaptor.swift

@@ -115,4 +115,8 @@ private struct POSExternalViewAdaptor: POSExternalViewProviding {
             onSelection: onSelection
         ))
     }
+
+    func createWCWebView(adminUrl: URL, completion: @escaping () -> Void) -> AnyView {
+        AnyView(WCSettingsWebView(adminUrl: adminUrl, completion: completion))
+    }
 }

WooCommerce/Classes/POS/Presentation/CardReaderConnection/UI States/Connection Alerts/PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressView.swift

@@ -3,6 +3,7 @@ import SwiftUI
 struct PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressView: View {
     @StateObject var viewModel: PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressAlertViewModel
     let animation: POSCardPresentPaymentAlertAnimation
+    @Environment(\.posExternalViews) private var externalViews
 
     var body: some View {
         VStack(spacing: PointOfSaleReaderConnectionModalLayout.contentButtonSpacing) {
@@ -29,8 +30,8 @@ struct PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressView: View {
         .multilineTextAlignment(.center)
         .accessibilityElement(children: .contain)
         .posSheet(isPresented: $viewModel.shouldShowSettingsWebView) {
-            WCSettingsWebView(adminUrl: viewModel.settingsAdminUrl,
-                              completion: viewModel.settingsWebViewWasDismissed)
+            externalViews.createWCWebView(adminUrl: viewModel.settingsAdminUrl,
+                                          completion: viewModel.settingsWebViewWasDismissed)
         }
     }
 }

WooCommerce/Classes/POS/Protocols/POSDependencyProviding.swift

@@ -59,6 +59,7 @@ protocol POSExternalViewProviding {
                                           title: String,
                                           cancelButtonTitle: String,
                                           onSelection: @escaping (Coupon.DiscountType) -> Void) -> AnyView
+    func createWCWebView(adminUrl: URL, completion: @escaping () -> Void) -> AnyView
 }
 
 /// Main protocol that combines all POS dependency providers

WooCommerce/Classes/POS/Utils/POSEnvironmentKeys.swift

@@ -142,5 +142,8 @@ struct EmptyPOSExternalView: POSExternalViewProviding {
                                           onSelection: @escaping (Coupon.DiscountType) -> Void) -> AnyView {
         AnyView(EmptyView())
     }
+    func createWCWebView(adminUrl: URL, completion: @escaping () -> Void) -> AnyView {
+        AnyView(EmptyView())
+    }
     init() {}
 }