Add test cases for POSSettingsLocalCatalogViewModel.

jaclync · jaclync · commit 28f706ff35c9 · 2025-09-18T15:33:31.000+08:00
diff --git a/WooCommerce/Classes/POS/Presentation/Settings/POSSettingsLocalCatalogViewModel.swift b/WooCommerce/Classes/POS/Presentation/Settings/POSSettingsLocalCatalogViewModel.swift
@@ -69,10 +69,15 @@ private extension POSSettingsLocalCatalogViewModel {
     }
 
     func loadSyncDates() async -> (full: String, incremental: String) {
-        let syncDates = await catalogSettingsService.loadSyncDates(for: siteID)
-        let full = formatSyncDate(syncDates.lastFullSyncDate)
-        let incremental = formatSyncDate(syncDates.lastIncrementalSyncDate)
-        return (full, incremental)
+        do {
+            let syncDates = try await catalogSettingsService.loadSyncDates(for: siteID)
+            let full = formatSyncDate(syncDates.lastFullSyncDate)
+            let incremental = formatSyncDate(syncDates.lastIncrementalSyncDate)
+            return (full, incremental)
+        } catch {
+            DDLogError("⛔️ POSSettingsLocalCatalog: Error loading sync dates: \(error)")
+            return (Localization.syncDateUnavailable, Localization.syncDateUnavailable)
+        }
     }
 
     func formatSyncDate(_ date: Date?) -> String {
@@ -101,5 +106,11 @@ private extension POSSettingsLocalCatalogViewModel {
             value: "Not synced",
             comment: "Text shown when no sync has been performed yet."
         )
+
+        static let syncDateUnavailable = NSLocalizedString(
+            "posSettingsLocalCatalogViewModel.syncDateUnavailable",
+            value: "Sync date unavailable",
+            comment: "Text shown when sync date cannot be determined."
+        )
     }
 }
diff --git a/WooCommerce/WooCommerce.xcodeproj/project.pbxproj b/WooCommerce/WooCommerce.xcodeproj/project.pbxproj
@@ -606,6 +606,9 @@
 		02C34C752D50F4C3004BFB50 /* AddressMapPickerViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C34C742D50F4C3004BFB50 /* AddressMapPickerViewModel.swift */; };
 		02C3FACE282A93020095440A /* WooAnalyticsEvent+Dashboard.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C3FACD282A93020095440A /* WooAnalyticsEvent+Dashboard.swift */; };
 		02C3FDEA251091CE009569EE /* ProductFactoryTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C3FDE9251091CE009569EE /* ProductFactoryTests.swift */; };
+		02C470B62E7BDB7700F5F716 /* POSSettingsLocalCatalogViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C470B52E7BDB7700F5F716 /* POSSettingsLocalCatalogViewModelTests.swift */; };
+		02C470B82E7BDD9600F5F716 /* MockPOSCatalogSyncCoordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C470B72E7BDD9400F5F716 /* MockPOSCatalogSyncCoordinator.swift */; };
+		02C470BA2E7BDDD100F5F716 /* MockPOSCatalogSettingsService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C470B92E7BDDCF00F5F716 /* MockPOSCatalogSettingsService.swift */; };
 		02C7EE8A2B21B951008B7DF8 /* ProductWithQuantityStepperViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C7EE892B21B951008B7DF8 /* ProductWithQuantityStepperViewModel.swift */; };
 		02C7EE8C2B22B21D008B7DF8 /* CollapsibleProductRowCardViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C7EE8B2B22B21D008B7DF8 /* CollapsibleProductRowCardViewModel.swift */; };
 		02C7EE902B22EFB9008B7DF8 /* CollapsibleProductRowCardViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 02C7EE8F2B22EFB9008B7DF8 /* CollapsibleProductRowCardViewModelTests.swift */; };
@@ -3821,6 +3824,9 @@
 		02C34C742D50F4C3004BFB50 /* AddressMapPickerViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AddressMapPickerViewModel.swift; sourceTree = "<group>"; };
 		02C3FACD282A93020095440A /* WooAnalyticsEvent+Dashboard.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "WooAnalyticsEvent+Dashboard.swift"; sourceTree = "<group>"; };
 		02C3FDE9251091CE009569EE /* ProductFactoryTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProductFactoryTests.swift; sourceTree = "<group>"; };
+		02C470B52E7BDB7700F5F716 /* POSSettingsLocalCatalogViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = POSSettingsLocalCatalogViewModelTests.swift; sourceTree = "<group>"; };
+		02C470B72E7BDD9400F5F716 /* MockPOSCatalogSyncCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockPOSCatalogSyncCoordinator.swift; sourceTree = "<group>"; };
+		02C470B92E7BDDCF00F5F716 /* MockPOSCatalogSettingsService.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockPOSCatalogSettingsService.swift; sourceTree = "<group>"; };
 		02C7EE892B21B951008B7DF8 /* ProductWithQuantityStepperViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProductWithQuantityStepperViewModel.swift; sourceTree = "<group>"; };
 		02C7EE8B2B22B21D008B7DF8 /* CollapsibleProductRowCardViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CollapsibleProductRowCardViewModel.swift; sourceTree = "<group>"; };
 		02C7EE8F2B22EFB9008B7DF8 /* CollapsibleProductRowCardViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CollapsibleProductRowCardViewModelTests.swift; sourceTree = "<group>"; };
@@ -7396,6 +7402,7 @@
 				01AB2D112DDC7AD100AA67FD /* PointOfSaleItemListAnalyticsTrackerTests.swift */,
 				208628722D48E476003F45DC /* Payments Onboarding */,
 				026A502E2D2F8099002C42C2 /* Infinite Scroll */,
+				02C470B42E7BDB2D00F5F716 /* Settings */,
 				686A71B52DC9E5C10006E835 /* POSItemActionHandlerTests.swift */,
 				689F291B2DE45604004DF52B /* POSStockFormatterTests.swift */,
 			);
@@ -7793,6 +7800,14 @@
 			path = "Edit Shipping";
 			sourceTree = "<group>";
 		};
+		02C470B42E7BDB2D00F5F716 /* Settings */ = {
+			isa = PBXGroup;
+			children = (
+				02C470B52E7BDB7700F5F716 /* POSSettingsLocalCatalogViewModelTests.swift */,
+			);
+			path = Settings;
+			sourceTree = "<group>";
+		};
 		02C5CBD724A5D16A00860C64 /* Linked Products List Selector */ = {
 			isa = PBXGroup;
 			children = (
@@ -7839,6 +7854,8 @@
 		02CD3BFC2C35D01600E575C4 /* Mocks */ = {
 			isa = PBXGroup;
 			children = (
+				02C470B92E7BDDCF00F5F716 /* MockPOSCatalogSettingsService.swift */,
+				02C470B72E7BDD9400F5F716 /* MockPOSCatalogSyncCoordinator.swift */,
 				016582E12E787187001DBB6F /* MockOnboardingViewFactoryConfiguration.swift */,
 				01B7AFBF2E7080180004BE9D /* MockPOSOrderListController.swift */,
 				019460E12E70121A00FCB9AB /* MockPOSReceiptController.swift */,
@@ -17292,6 +17309,7 @@
 				EE2EDFE12987A189004E702B /* MockABTestVariationProvider.swift in Sources */,
 				0273707E24C0047800167204 /* SequenceHelpersTests.swift in Sources */,
 				012ACB762E5C83EC00A49458 /* POSOrderListControllerTests.swift in Sources */,
+				02C470B62E7BDB7700F5F716 /* POSSettingsLocalCatalogViewModelTests.swift in Sources */,
 				DE9A02A32A44441200193ABF /* RequirementsCheckerTests.swift in Sources */,
 				D802547326551D0F001B2CC1 /* CardPresentModalTapCardTests.swift in Sources */,
 				B55BC1F321A8790F0011A0C0 /* StringHTMLTests.swift in Sources */,
@@ -17621,6 +17639,7 @@
 				DE36E09C2A89EEA400B98496 /* StoreNameSetupViewModelTests.swift in Sources */,
 				57C2F6E624C27B3100131012 /* SwitchStoreNoticePresenterTests.swift in Sources */,
 				020BE77123B4A4C6007FE54C /* AztecHorizontalRulerFormatBarCommandTests.swift in Sources */,
+				02C470BA2E7BDDD100F5F716 /* MockPOSCatalogSettingsService.swift in Sources */,
 				B5C6CE612190D28E00515926 /* NSAttributedStringHelperTests.swift in Sources */,
 				CC07860526736B6500BA9AC1 /* ErrorTopBannerFactoryTests.swift in Sources */,
 				02490D1E284F3226002096EF /* ProductImagesSaverTests.swift in Sources */,
@@ -17798,6 +17817,7 @@
 				2D09E0D52E65C9B9005C26F3 /* ApplicationPasswordsExperimentStateTests.swift in Sources */,
 				D816DDBC22265DA300903E59 /* OrderTrackingTableViewCellTests.swift in Sources */,
 				579CDF01274D811D00E8903D /* StoreStatsUsageTracksEventEmitterTests.swift in Sources */,
+				02C470B82E7BDD9600F5F716 /* MockPOSCatalogSyncCoordinator.swift in Sources */,
 				CE4AFE482CD239B90013C52B /* WooShippingPostPurchaseViewModelTests.swift in Sources */,
 				EE3272A429A88F750015F8D0 /* StoreOnboardingViewModelTests.swift in Sources */,
 				262A2C2B2537A3330086C1BE /* MockRefunds.swift in Sources */,
diff --git a/WooCommerce/WooCommerceTests/POS/Controllers/PointOfSaleSettingsControllerTests.swift b/WooCommerce/WooCommerceTests/POS/Controllers/PointOfSaleSettingsControllerTests.swift
@@ -18,7 +18,9 @@ struct PointOfSaleSettingsControllerTests {
                                                 cardPresentPaymentService: mockCardPresentPaymentService,
                                                 pluginsService: mockPluginService,
                                                 defaultSiteName: "Test Store",
-                                                siteSettings: [])
+                                                siteSettings: [],
+                                                grdbManager: ServiceLocator.grdbManager,
+                                                catalogSyncCoordinator: ServiceLocator.posCatalogSyncCoordinator)
 
         // When
         let cardReader = sut.connectedCardReader
@@ -35,7 +37,9 @@ struct PointOfSaleSettingsControllerTests {
                                                 cardPresentPaymentService: mockService,
                                                 pluginsService: mockPluginService,
                                                 defaultSiteName: "Test Store",
-                                                siteSettings: [])
+                                                siteSettings: [],
+                                                grdbManager: ServiceLocator.grdbManager,
+                                                catalogSyncCoordinator: ServiceLocator.posCatalogSyncCoordinator)
 
         // Initially nil
         #expect(sut.connectedCardReader == nil)
@@ -76,4 +80,5 @@ final class MockPointOfSaleSettingsController: PointOfSaleSettingsControllerProt
                                                                               pluginsService: MockPluginsService(),
                                                                               defaultSiteName: "Sample Store",
                                                                               siteSettings: [])
+    var localCatalogViewModel: POSSettingsLocalCatalogViewModel?
 }
diff --git a/WooCommerce/WooCommerceTests/POS/Mocks/MockPOSCatalogSettingsService.swift b/WooCommerce/WooCommerceTests/POS/Mocks/MockPOSCatalogSettingsService.swift
@@ -0,0 +1,33 @@
+@testable import Yosemite
+
+final class MockPOSCatalogSettingsService: POSCatalogSettingsServiceProtocol {
+    var catalogStatisticsResult: Result<POSCatalogStatistics, Error> = .success(POSCatalogStatistics(productCount: 0, variationCount: 0))
+    var syncDatesResult: Result<POSSyncDates, Error> = .success(POSSyncDates(lastFullSyncDate: nil, lastIncrementalSyncDate: nil))
+    var shouldDelayResponse = false
+
+    func loadCatalogStatistics(for siteID: Int64) async throws -> POSCatalogStatistics {
+        if shouldDelayResponse {
+            try await Task.sleep(for: .milliseconds(100))
+        }
+
+        switch catalogStatisticsResult {
+        case .success(let statistics):
+            return statistics
+        case .failure(let error):
+            throw error
+        }
+    }
+
+    func loadSyncDates(for siteID: Int64) async throws -> POSSyncDates {
+        if shouldDelayResponse {
+            try await Task.sleep(for: .milliseconds(50))
+        }
+
+        switch syncDatesResult {
+        case .success(let dates):
+            return dates
+        case .failure(let error):
+            throw error
+        }
+    }
+}
diff --git a/WooCommerce/WooCommerceTests/POS/Mocks/MockPOSCatalogSyncCoordinator.swift b/WooCommerce/WooCommerceTests/POS/Mocks/MockPOSCatalogSyncCoordinator.swift
@@ -0,0 +1,31 @@
+import Foundation
+@testable import Yosemite
+
+final class MockPOSCatalogSyncCoordinator: POSCatalogSyncCoordinatorProtocol {
+    var performFullSyncInvocationCount = 0
+    var performFullSyncSiteID: Int64?
+    var performFullSyncResult: Result<Void, Error> = .success(())
+    var shouldDelayResponse = false
+
+    func shouldPerformFullSync(for siteID: Int64, maxAge: TimeInterval) async -> Bool {
+        true
+    }
+
+    func performFullSync(for siteID: Int64) async throws {
+        if shouldDelayResponse {
+            try await Task.sleep(for: .milliseconds(100))
+        }
+
+        performFullSyncInvocationCount += 1
+        performFullSyncSiteID = siteID
+
+        switch performFullSyncResult {
+        case .success:
+            return
+        case .failure(let error):
+            throw error
+        }
+    }
+
+    func performIncrementalSyncIfApplicable(for siteID: Int64, forceSync: Bool) async throws {}
+}
diff --git a/WooCommerce/WooCommerceTests/POS/Presentation/Settings/POSSettingsLocalCatalogViewModelTests.swift b/WooCommerce/WooCommerceTests/POS/Presentation/Settings/POSSettingsLocalCatalogViewModelTests.swift

Original file line number	Diff line number	Diff line change
`@@ -69,10 +69,15 @@ private extension POSSettingsLocalCatalogViewModel {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`func loadSyncDates() async -> (full: String, incremental: String) {`
`72`		`- let syncDates = await catalogSettingsService.loadSyncDates(for: siteID)`
`73`		`- let full = formatSyncDate(syncDates.lastFullSyncDate)`
`74`		`- let incremental = formatSyncDate(syncDates.lastIncrementalSyncDate)`
`75`		`- return (full, incremental)`
	`72`	`+ do {`
	`73`	`+ let syncDates = try await catalogSettingsService.loadSyncDates(for: siteID)`
	`74`	`+ let full = formatSyncDate(syncDates.lastFullSyncDate)`
	`75`	`+ let incremental = formatSyncDate(syncDates.lastIncrementalSyncDate)`
	`76`	`+ return (full, incremental)`
	`77`	`+ } catch {`
	`78`	`+ DDLogError("⛔️ POSSettingsLocalCatalog: Error loading sync dates: \(error)")`
	`79`	`+ return (Localization.syncDateUnavailable, Localization.syncDateUnavailable)`
	`80`	`+ }`
`76`	`81`	`}`
`77`	`82`
`78`	`83`	`func formatSyncDate(_ date: Date?) -> String {`
`@@ -101,5 +106,11 @@ private extension POSSettingsLocalCatalogViewModel {`
`101`	`106`	`value: "Not synced",`
`102`	`107`	`comment: "Text shown when no sync has been performed yet."`
`103`	`108`	`)`
	`109`	`+`
	`110`	`+ static let syncDateUnavailable = NSLocalizedString(`
	`111`	`+ "posSettingsLocalCatalogViewModel.syncDateUnavailable",`
	`112`	`+ value: "Sync date unavailable",`
	`113`	`+ comment: "Text shown when sync date cannot be determined."`
	`114`	`+ )`
`104`	`115`	`}`
`105`	`116`	`}`