Remove timeout from POSSettingsLocalCatalogViewModelTests (#16210)

Author: staskus

Modules/Tests/PointOfSaleTests/Mocks/MockPOSCatalogSettingsService.swift

@@ -4,12 +4,10 @@ final class MockPOSCatalogSettingsService: POSCatalogSettingsServiceProtocol {
     var catalogInfoResult: Result<POSCatalogInfo, Error> = .success(
         .init(productCount: 0, variationCount: 0, lastFullSyncDate: nil, lastIncrementalSyncDate: nil)
     )
-    var shouldDelayResponse = false
+    var onLoadCatalogInfoCalled: (() -> Void)?
 
     func loadCatalogInfo(for siteID: Int64) async throws -> POSCatalogInfo {
-        if shouldDelayResponse {
-            try await Task.sleep(for: .milliseconds(100))
-        }
+        onLoadCatalogInfoCalled?()
 
         switch catalogInfoResult {
         case .success(let info):

Modules/Tests/PointOfSaleTests/Mocks/MockPOSCatalogSyncCoordinator.swift

@@ -5,12 +5,11 @@ final class MockPOSCatalogSyncCoordinator: POSCatalogSyncCoordinatorProtocol {
     var performFullSyncInvocationCount = 0
     var performFullSyncSiteID: Int64?
     var performFullSyncResult: Result<Void, Error> = .success(())
-    var shouldDelayResponse = false
+
+    var onPerformFullSyncCalled: (() -> Void)?
 
     func performFullSyncIfApplicable(for siteID: Int64, maxAge: TimeInterval) async throws {
-        if shouldDelayResponse {
-            try await Task.sleep(for: .milliseconds(100))
-        }
+        onPerformFullSyncCalled?()
 
         performFullSyncInvocationCount += 1
         performFullSyncSiteID = siteID

Modules/Tests/PointOfSaleTests/Presentation/Settings/POSSettingsLocalCatalogViewModelTests.swift

@@ -91,20 +91,19 @@ struct POSSettingsLocalCatalogViewModelTests {
             lastFullSyncDate: nil,
             lastIncrementalSyncDate: nil
         ))
-        catalogSettingsService.shouldDelayResponse = true
 
-        // When
-        let loadTask = Task {
+        await confirmation() { confirmation in
+            catalogSettingsService.onLoadCatalogInfoCalled = {
+                // At the time loadCatalogInfo is called, loading is set to true
+                #expect(sut.isLoading == true)
+                confirmation()
+            }
+
+            // When
             await sut.loadCatalogData()
         }
 
         // Then
-        try await Task.sleep(for: .milliseconds(10))
-        #expect(sut.isLoading == true)
-
-        catalogSettingsService.shouldDelayResponse = false
-        await loadTask.value
-
         #expect(sut.isLoading == false)
     }
 
@@ -137,20 +136,19 @@ struct POSSettingsLocalCatalogViewModelTests {
             lastFullSyncDate: nil,
             lastIncrementalSyncDate: nil
         ))
-        catalogSyncCoordinator.shouldDelayResponse = true
 
-        // When
-        let refreshTask = Task {
+        await confirmation() { confirmation in
+            catalogSyncCoordinator.onPerformFullSyncCalled = {
+                // At the time performFullSyncCalled is called, isRefreshingCatalog is set to true
+                #expect(sut.isRefreshingCatalog == true)
+                confirmation()
+            }
+
+            // When
             await sut.refreshCatalog()
         }
 
         // Then
-        try await Task.sleep(for: .milliseconds(10))
-        #expect(sut.isRefreshingCatalog == true)
-
-        catalogSyncCoordinator.shouldDelayResponse = false
-        await refreshTask.value
-
         #expect(sut.isRefreshingCatalog == false)
     }