Adjust formatting operations for date ranges

Author: ThomazFB

Networking/Networking/Extensions/DateFormatter+Woo.swift

@@ -107,7 +107,7 @@ public extension DateFormatter {
         /// Date formatter used for creating the properly-formatted date range info. Typically
         /// used when setting the end date on `AnalyticsHubTimeRangeGenerator`.
         ///
-        public static func createAnalyticsHubDayMonthYearFormatter(timezone: TimeZone) -> DateFormatter {
+        public static func createDayMonthYearFormatter(timezone: TimeZone) -> DateFormatter {
             let formatter = DateFormatter()
             formatter.timeZone = timezone
             formatter.dateFormat = "MMM d, yyyy"
@@ -117,7 +117,7 @@ public extension DateFormatter {
         /// Date formatter used for creating the properly-formatted date range info. Typically
         /// used when setting the end date of a same-month range on `AnalyticsHubTimeRangeGenerator`.
         ///
-        public static func createAnalyticsHubDayYearFormatter(timezone: TimeZone) -> DateFormatter {
+        public static func createDayYearFormatter(timezone: TimeZone) -> DateFormatter {
             let formatter = DateFormatter()
             formatter.timeZone = timezone
             formatter.dateFormat = "d, yyyy"
@@ -127,7 +127,7 @@ public extension DateFormatter {
         /// Date formatter used for creating the properly-formatted date range info. Typically
         /// used when setting the start date on `AnalyticsHubTimeRangeGenerator`.
         ///
-        public static func createAnalyticsHubDayMonthFormatter(timezone: TimeZone) -> DateFormatter {
+        public static func createDayMonthFormatter(timezone: TimeZone) -> DateFormatter {
             let formatter = DateFormatter()
             formatter.timeZone = timezone
             formatter.dateFormat = "MMM d"

WooCommerce/Classes/Extensions/Date+Woo.swift

@@ -76,22 +76,22 @@ extension Date {
     /// returns: Jan 1, 2022
     ///
     func formatAsRange(with other: Date? = nil, timezone: TimeZone, calendar: Calendar) -> String {
-        guard let other = other else {
-            return DateFormatter.Stats.createAnalyticsHubDayMonthYearFormatter(timezone: timezone).string(from: self)
+        guard let other else {
+            return DateFormatter.Stats.createDayMonthYearFormatter(timezone: timezone).string(from: self)
         }
 
         let formattedStart: String
         if self.isSameYear(as: other, using: calendar) {
-            formattedStart = DateFormatter.Stats.createAnalyticsHubDayMonthFormatter(timezone: timezone).string(from: self)
+            formattedStart = DateFormatter.Stats.createDayMonthFormatter(timezone: timezone).string(from: self)
         } else {
-            formattedStart = DateFormatter.Stats.createAnalyticsHubDayMonthYearFormatter(timezone: timezone).string(from: self)
+            formattedStart = DateFormatter.Stats.createDayMonthYearFormatter(timezone: timezone).string(from: self)
         }
 
         let formattedEnd: String
         if self.isSameMonth(as: other, using: calendar) {
-            formattedEnd = DateFormatter.Stats.createAnalyticsHubDayYearFormatter(timezone: timezone).string(from: other)
+            formattedEnd = DateFormatter.Stats.createDayYearFormatter(timezone: timezone).string(from: other)
         } else {
-            formattedEnd = DateFormatter.Stats.createAnalyticsHubDayMonthYearFormatter(timezone: timezone).string(from: other)
+            formattedEnd = DateFormatter.Stats.createDayMonthYearFormatter(timezone: timezone).string(from: other)
         }
 
         return "\(formattedStart) - \(formattedEnd)"