Use app setting instead of feature flag

Author: RafaelKayumov

Modules/Sources/Yosemite/Actions/AppSettingsAction.swift

@@ -356,4 +356,14 @@ public enum AppSettingsAction: Action {
     /// Loads the favorite products.
     ///
     case loadFavoriteProductIDs(siteID: Int64, onCompletion: ([Int64]) -> Void)
+
+    // MARK: - Application passwords Experiment feature
+
+    /// Sets the dismiss state for the Custom Fields top banner
+    ///
+    case setAppPasswordsExperimentSwitchState(isOn: Bool, onCompletion: (Result<Void, Error>) -> Void)
+
+    /// Loads the dismiss state of the Custom Fields top banner
+    ///
+    case getAppPasswordsExperimentSwitchState(onCompletion: (Bool) -> Void)
 }

Modules/Sources/Yosemite/Stores/AppSettingsStore.swift

@@ -289,6 +289,10 @@ public class AppSettingsStore: Store {
             dismissCustomFieldsTopBanner(onCompletion: onCompletion)
         case .loadCustomFieldsTopBannerDismissState(let onCompletion):
             loadCustomFieldsTopBannerDismissState(onCompletion: onCompletion)
+        case .setAppPasswordsExperimentSwitchState(let value, let onCompletion):
+            setAppPasswordsExperimentSwitchEnabled(isOn: value, onCompletion: onCompletion)
+        case .getAppPasswordsExperimentSwitchState(let onCompletion):
+            getAppPasswordsExperimentSwitchEnabled(onCompletion: onCompletion)
         }
     }
 }
@@ -1269,6 +1273,24 @@ private extension AppSettingsStore {
     }
 }
 
+// MARK: - Application Passwords Experiment Feature
+//
+private extension AppSettingsStore {
+    func setAppPasswordsExperimentSwitchEnabled(isOn: Bool, onCompletion: (Result<Void, Error>) -> Void) {
+        do {
+            try generalAppSettings.setValue(isOn, for: \.isApplicationPasswordsSwitchEnabled)
+            onCompletion(.success(()))
+        } catch {
+            onCompletion(.failure(error))
+        }
+    }
+
+    func getAppPasswordsExperimentSwitchEnabled(onCompletion: (Bool) -> Void) {
+        onCompletion(generalAppSettings.value(for: \.isApplicationPasswordsSwitchEnabled))
+    }
+}
+
+
 // MARK: - Errors
 
 /// Errors

WooCommerce/Classes/Yosemite/AuthenticatedState.swift

@@ -137,7 +137,10 @@ class AuthenticatedState: StoresManagerState {
         trackEventRequestNotificationHandler = TrackEventRequestNotificationHandler()
 
         startListeningToNotifications()
-        checkApplicationPasswordExperimentFeatureFlag()
+
+        DispatchQueue.main.async {
+            self.checkApplicationPasswordExperimentFeatureState()
+        }
     }
 
     /// Convenience Initializer
@@ -192,11 +195,11 @@ private extension AuthenticatedState {
         ServiceLocator.analytics.track(.jetpackTunnelTimeout)
     }
 
-    /// Uses local feature flag for development phase.
-    /// TODO: Switch to remote feature flag before release.
-    func checkApplicationPasswordExperimentFeatureFlag() {
-        let enabled = ServiceLocator.featureFlagService.isFeatureFlagEnabled(.applicationPasswordExperiment)
-        network.updateAppPasswordSwitching(enabled: enabled)
+    func checkApplicationPasswordExperimentFeatureState() {
+        let action = AppSettingsAction.getAppPasswordsExperimentSwitchState { [weak self] isOn in
+            self?.network.updateAppPasswordSwitching(enabled: isOn)
+        }
+        ServiceLocator.stores.dispatch(action)
     }
 }