Update POSSettingsLocalCatalogViewModelTests to remove timeout usage

Instead of using timeouts in tests we:

- Call async method
- Verify intermediate state
- Manually continue the mocked async method
- Verify the finished state

Author: staskus

WooCommerce/WooCommerceTests/POS/Presentation/Settings/POSSettingsLocalCatalogViewModelTests.swift

@@ -91,20 +91,19 @@ struct POSSettingsLocalCatalogViewModelTests {
             lastFullSyncDate: nil,
             lastIncrementalSyncDate: nil
         ))
-        catalogSettingsService.shouldDelayResponse = true
 
-        // When
-        let loadTask = Task {
-            await sut.loadCatalogData()
-        }
+        catalogSettingsService.onLoadCatalogInfoCalled = { continuation in
+            // When loadCatalogInfo is called, loading is set to true
+            #expect(sut.isLoading == true)
 
-        // Then
-        try await Task.sleep(for: .milliseconds(10))
-        #expect(sut.isLoading == true)
+            // Finsh loadCatalogInfo
+            continuation.resume()
+        }
 
-        catalogSettingsService.shouldDelayResponse = false
-        await loadTask.value
+        // When
+        await sut.loadCatalogData()
 
+        // Then
         #expect(sut.isLoading == false)
     }
 
@@ -137,20 +136,19 @@ struct POSSettingsLocalCatalogViewModelTests {
             lastFullSyncDate: nil,
             lastIncrementalSyncDate: nil
         ))
-        catalogSyncCoordinator.shouldDelayResponse = true
 
-        // When
-        let refreshTask = Task {
-            await sut.refreshCatalog()
-        }
+        catalogSyncCoordinator.onPerformFullSyncCalled = { continuation in
+            // When performFullSyncCalled is called, isRefreshingCatalog is set to true
+            #expect(sut.isRefreshingCatalog == true)
 
-        // Then
-        try await Task.sleep(for: .milliseconds(10))
-        #expect(sut.isRefreshingCatalog == true)
+            // Finsh performFullSync
+            continuation.resume()
+        }
 
-        catalogSyncCoordinator.shouldDelayResponse = false
-        await refreshTask.value
+        // When
+        await sut.refreshCatalog()
 
+        // Then
         #expect(sut.isRefreshingCatalog == false)
     }