move setHasPOSBeenOpenedAtLeastOnce to the correct place

Author: iamgabrielma

WooCommerce/Classes/POS/TabBar/POSTabCoordinator.swift

@@ -116,11 +116,19 @@ final class POSTabCoordinator {
     }
 
     func onTabSelected() {
+        setPOSHasBeenOpened()
         presentPOSView(siteID: siteID)
     }
 }
 
 private extension POSTabCoordinator {
+    func setPOSHasBeenOpened() {
+        Task { @MainActor in
+            let action = AppSettingsAction.setHasPOSBeenOpenedAtLeastOnce { _ in }
+            storesManager.dispatch(action)
+        }
+    }
+
     func presentPOSView(siteID: Int64) {
         Task { @MainActor [weak self] in
             guard let self else { return }

WooCommerce/Classes/ViewRelated/AppCoordinator.swift

@@ -107,9 +107,6 @@ private extension AppCoordinator {
     func schedulePOSSurveyNotificationIfNeeded() {
         Task { @MainActor in
             await POSNotificationScheduler(stores: stores).scheduleLocalNotificationIfEligible(for: .currentMerchant)
-
-            let action = AppSettingsAction.setHasPOSBeenOpenedAtLeastOnce { _ in }
-            stores.dispatch(action)
         }
     }
 }