HACK Week: Load and update site settings (#15386)

Author: itsmeichigo

Experiments/Experiments/DefaultFeatureFlagService.swift

@@ -96,7 +96,7 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
         case .backgroundProductImageUpload:
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .notificationSettings:
-            return buildConfig == .localDeveloper || buildConfig == .alpha
+            return true
         default:
             return true
         }

Networking/Networking/Model/Copiable/Models+Copiable.generated.swift

@@ -1311,6 +1311,51 @@ extension Networking.NoteRange {
     }
 }
 
+extension Networking.NotificationSettings {
+    public func copy(
+        blogs: CopiableProp<[NotificationSettings.Blog]> = .copy
+    ) -> Networking.NotificationSettings {
+        let blogs = blogs ?? self.blogs
+
+        return Networking.NotificationSettings(
+            blogs: blogs
+        )
+    }
+}
+
+extension Networking.NotificationSettings.Blog {
+    public func copy(
+        blogID: CopiableProp<Int64> = .copy,
+        devices: CopiableProp<[NotificationSettings.Device]> = .copy
+    ) -> Networking.NotificationSettings.Blog {
+        let blogID = blogID ?? self.blogID
+        let devices = devices ?? self.devices
+
+        return Networking.NotificationSettings.Blog(
+            blogID: blogID,
+            devices: devices
+        )
+    }
+}
+
+extension Networking.NotificationSettings.Device {
+    public func copy(
+        deviceID: CopiableProp<Int64> = .copy,
+        newComment: CopiableProp<Bool> = .copy,
+        storeOrder: CopiableProp<Bool> = .copy
+    ) -> Networking.NotificationSettings.Device {
+        let deviceID = deviceID ?? self.deviceID
+        let newComment = newComment ?? self.newComment
+        let storeOrder = storeOrder ?? self.storeOrder
+
+        return Networking.NotificationSettings.Device(
+            deviceID: deviceID,
+            newComment: newComment,
+            storeOrder: storeOrder
+        )
+    }
+}
+
 extension Networking.Order {
     public func copy(
         siteID: CopiableProp<Int64> = .copy,

Networking/Networking/Model/NotificationSettings.swift

@@ -1,8 +1,9 @@
 import Foundation
+import Codegen
 
 /// Notification settings for a user
 ///
-public struct NotificationSettings: Equatable, Codable {
+public struct NotificationSettings: Equatable, Codable, GeneratedCopiable {
 
     /// Settings for different blogs connected to the user.
     public let blogs: [Blog]
@@ -36,7 +37,7 @@ public struct NotificationSettings: Equatable, Codable {
 
 public extension NotificationSettings {
     /// Notification settings for a blog
-    struct Blog: Equatable, Codable {
+    struct Blog: Equatable, Codable, GeneratedCopiable {
         /// ID of the blog
         public let blogID: Int64
 
@@ -75,7 +76,8 @@ public extension NotificationSettings {
     }
 
     /// Notification settings for a device
-    struct Device: Equatable, Codable {
+    struct Device: Equatable, Codable, GeneratedCopiable {
+
         /// Unique ID of the device
         public let deviceID: Int64
 
@@ -85,6 +87,12 @@ public extension NotificationSettings {
         /// Whether a notification should be sent when there is a new order on the store.
         public let storeOrder: Bool
 
+        public init(deviceID: Int64, newComment: Bool, storeOrder: Bool) {
+            self.deviceID = deviceID
+            self.newComment = newComment
+            self.storeOrder = storeOrder
+        }
+
         enum CodingKeys: String, CodingKey {
             case deviceID = "device_id"
             case newComment = "new_comment"

RELEASE-NOTES.txt

@@ -10,6 +10,7 @@
 - [*] Added an entry point to Troubleshoot Connection from the Settings screen. [https://github.com/woocommerce/woocommerce-ios/pull/15391]
 - [**] Filters in Orders and Products lists are now persisted. [https://github.com/woocommerce/woocommerce-ios/issues/14791]
 - [internal] Add site related properties to crowdsignal surveys. [https://github.com/woocommerce/woocommerce-ios/pull/15353]
+- [**] Notification settings are now available for configuring notifications for each store. [https://github.com/woocommerce/woocommerce-ios/pull/15386]
 
 21.9
 -----

WooCommerce/Classes/Analytics/WooAnalyticsStat.swift

@@ -336,11 +336,19 @@ enum WooAnalyticsStat: String {
     case settingsThirdPartyLearnMoreTapped = "privacy_settings_third_party_tracking_info_link_tapped"
     case settingsLicensesLinkTapped = "settings_about_open_source_licenses_link_tapped"
     case settingsAboutLinkTapped = "settings_about_woocommerce_link_tapped"
+    case settingsNotificationSettingsTapped = "settings_notification_settings_tapped"
 
     case settingsLogoutTapped = "settings_logout_button_tapped"
     case settingsLogoutConfirmation = "settings_logout_confirmation_dialog_result"
     case settingsWereHiringTapped = "settings_we_are_hiring_button_tapped"
 
+    // MARK: Notification Settings
+    //
+    case notificationSettingsUpdateButtonTapped = "notification_settings_update_button_tapped"
+    case notificationSettingsSaveButtonTapped = "notification_settings_save_button_tapped"
+    case notificationSettingsSavingSuccess = "notification_settings_saving_success"
+    case notificationSettingsSavingFailed = "notification_settings_saving_failed"
+
     // MARK: Domain Settings
     //
     case domainSettingsStep = "custom_domains_step"

WooCommerce/Classes/ViewRelated/Dashboard/Settings/NotificationSettings/NotificationSettingsView.swift

@@ -1,5 +1,6 @@
 import SwiftUI
 import struct Yosemite.Site
+import struct Yosemite.NotificationSettings
 
 final class NotificationSettingsHostingController: UIHostingController<NotificationSettingsView> {
     init() {
@@ -36,13 +37,54 @@ struct NotificationSettingsView: View {
             }
         }
         .navigationTitle(Localization.title)
+        .toolbar {
+            ToolbarItem(placement: .confirmationAction) {
+                Button {
+                    saveSettings()
+                } label: {
+                    if viewModel.isSavingSettings {
+                        ProgressView().progressViewStyle(.circular)
+                    } else {
+                        Text(Localization.save)
+                    }
+                }
+                .disabled(viewModel.hasSiteSettingsChanges == false)
+            }
+        }
         .task {
             await viewModel.checkNotificationPermission()
-            await viewModel.synchronizeSites()
+            if viewModel.currentDeviceID != nil {
+                await viewModel.retrieveNotificationSettings()
+                await viewModel.synchronizeSites()
+            }
         }
         .sheet(item: $selectedSite) { site in
-            SiteNotificationSettingsView(siteTitle: site.name)
+            if let settings = viewModel.loadSettings(for: site) {
+                SiteNotificationSettingsView(siteTitle: site.name,
+                                             ordersNotificationsEnabled: settings.storeOrder,
+                                             productReviewsNotificationsEnabled: settings.newComment,
+                                             completionHandler: { newOrder, productReviews in
+                    viewModel.updateSettings(siteID: site.siteID,
+                                             ordersNotificationsEnabled: newOrder,
+                                             productReviewsNotificationsEnabled: productReviews)
+                })
+            }
+        }
+        .alert(Localization.errorSavingSiteSettings, isPresented: $viewModel.savingSiteSettingsFailed) {
+            Button(Localization.cancel, role: .cancel) {}
+            Button(Localization.retry) {
+                saveSettings()
+            }
         }
+        .alert(Localization.errorLoadingSiteSettings, isPresented: $viewModel.loadingSiteSettingsFailed) {
+            Button(Localization.cancel, role: .cancel) {}
+            Button(Localization.retry) {
+                Task {
+                    await viewModel.retrieveNotificationSettings()
+                }
+            }
+        }
+        .notice($viewModel.notice)
     }
 }
 
@@ -88,14 +130,20 @@ private extension NotificationSettingsView {
             }
 
             Section {
-                ForEach(viewModel.sites) { site in
-                    detailRow(for: site)
+                if viewModel.isLoadingSiteSettings {
+                    ActivityIndicator(isAnimating: .constant(true), style: .medium)
+                        .frame(maxWidth: .infinity)
+                } else if viewModel.siteSettings != nil {
+                    ForEach(viewModel.sites) { site in
+                        detailRow(for: site)
+                    }
                 }
             } header: {
                 Text(Localization.storeListSectionHeader)
             } footer: {
                 Text(Localization.storeListSectionFooter)
             }
+            .renderedIf(viewModel.shouldShowSiteList)
         }
     }
 
@@ -107,9 +155,11 @@ private extension NotificationSettingsView {
                 VStack(alignment: .leading) {
                     Text(site.name)
                         .bodyStyle()
-                    Text(site.url)
-                        .foregroundStyle(Color.secondary)
-                        .captionStyle()
+                    if let settings = viewModel.loadSettings(for: site) {
+                        Text(description(for: settings))
+                            .foregroundStyle(Color.secondary)
+                            .captionStyle()
+                    }
                 }
                 .multilineTextAlignment(.leading)
 
@@ -130,6 +180,25 @@ private extension NotificationSettingsView {
         // Ask the system to open that URL.
         await UIApplication.shared.open(url)
     }
+
+    func saveSettings() {
+        Task {
+            await viewModel.saveSettings()
+        }
+    }
+
+    func description(for settings: NotificationSettings.Device) -> String {
+        switch (settings.storeOrder, settings.newComment) {
+        case (true, true):
+            [Localization.newOrders, Localization.productReviews].joined(separator: ", ")
+        case (true, false):
+            Localization.newOrders
+        case (false, true):
+            Localization.productReviews
+        case (false, false):
+            Localization.off
+        }
+    }
 }
 
 extension NotificationSettingsView {
@@ -179,6 +248,46 @@ extension NotificationSettingsView {
             value: "Customize your notification preferences for each store.",
             comment: "Footer of the store list section on the notification settings view"
         )
+        static let errorLoadingSiteSettings = NSLocalizedString(
+            "notificationSettingsView.errorLoadingSiteSettings",
+            value: "Unable to load notification settings for your stores.",
+            comment: "Error message when loading site settings fails on the notification settings view"
+        )
+        static let retry = NSLocalizedString(
+            "notificationSettingsView.retry",
+            value: "Try again",
+            comment: "Button to reload site settings on the notification settings view"
+        )
+        static let save = NSLocalizedString(
+            "notificationSettingsView.save",
+            value: "Save",
+            comment: "Button to save site settings on the notification settings view"
+        )
+        static let cancel = NSLocalizedString(
+            "notificationSettingsView.cancel",
+            value: "Cancel",
+            comment: "Button to cancel saving site settings on the notification settings view"
+        )
+        static let errorSavingSiteSettings = NSLocalizedString(
+            "notificationSettingsView.errorSavingSiteSettings",
+            value: "Unable to save notification settings",
+            comment: "Error message when saving site settings fails on the notification settings view"
+        )
+        static let newOrders = NSLocalizedString(
+            "notificationSettingsView.newOrders",
+            value: "New orders",
+            comment: "Label indicating that new orders notifications are enabled for a site on the notification settings view"
+        )
+        static let productReviews = NSLocalizedString(
+            "notificationSettingsView.productReviews",
+            value: "Product reviews",
+            comment: "Label indicating that product reviews notifications are enabled for a site on the notification settings view"
+        )
+        static let off = NSLocalizedString(
+            "notificationSettingsView.off",
+            value: "Off",
+            comment: "Label indicating that notifications are disabled for a site on the notification settings view"
+        )
     }
 }