Reduce code duplication for syncing shipping labels

Author: itsmeichigo

WooCommerce/Classes/ViewModels/Order Details/OrderDetailsViewModel.swift

@@ -952,56 +952,44 @@ private extension OrderDetailsViewModel {
 
     @MainActor func syncShippingLabelsForWooShipping() async -> [ShippingLabel] {
         await withCheckedContinuation { continuation in
-            stores.dispatch(WooShippingAction.syncShippingLabels(siteID: order.siteID, orderID: order.orderID) { result in
-                switch result {
-                case .success(let shippingLabels):
-                    ServiceLocator.analytics.track(event: .shippingLabelsAPIRequest(
-                        result: .success,
-                        isRevampedFlow: true
-                    ))
-                    continuation.resume(returning: shippingLabels)
-                case .failure(let error):
-                    ServiceLocator.analytics.track(event: .shippingLabelsAPIRequest(
-                        result: .failed(error: error),
-                        isRevampedFlow: true
-                    ))
-                    if error as? DotcomError == .noRestRoute {
-                        DDLogError("⚠️ Endpoint for synchronizing shipping labels is unreachable. WC Shipping plugin may be missing.")
-                    } else {
-                        DDLogError("⛔️ Error synchronizing shipping labels: \(error)")
-                    }
-                    continuation.resume(returning: [])
-                }
+            stores.dispatch(WooShippingAction.syncShippingLabels(siteID: order.siteID, orderID: order.orderID) { [weak self] result in
+                let labels = self?.handleShippingLabelSyncingResult(result: result, isRevampedFlow: true) ?? []
+                continuation.resume(returning: labels)
             })
         }
     }
 
     @MainActor func syncShippingLabelsForLegacyPlugin(isRevampedFlow: Bool) async -> [ShippingLabel] {
         await withCheckedContinuation { continuation in
-            stores.dispatch(ShippingLabelAction.synchronizeShippingLabels(siteID: order.siteID, orderID: order.orderID) { result in
-                switch result {
-                case .success(let shippingLabels):
-                    ServiceLocator.analytics.track(event: .shippingLabelsAPIRequest(
-                        result: .success,
-                        isRevampedFlow: isRevampedFlow
-                    ))
-                    continuation.resume(returning: shippingLabels)
-                case .failure(let error):
-                    ServiceLocator.analytics.track(event: .shippingLabelsAPIRequest(
-                        result: .failed(error: error),
-                        isRevampedFlow: isRevampedFlow
-                    ))
-                    if error as? DotcomError == .noRestRoute {
-                        DDLogError("⚠️ Endpoint for synchronizing shipping labels is unreachable. WC Shipping plugin may be missing.")
-                    } else {
-                        DDLogError("⛔️ Error synchronizing shipping labels: \(error)")
-                    }
-                    continuation.resume(returning: [])
-                }
+            stores.dispatch(ShippingLabelAction.synchronizeShippingLabels(siteID: order.siteID, orderID: order.orderID) { [weak self] result in
+                let labels = self?.handleShippingLabelSyncingResult(result: result, isRevampedFlow: isRevampedFlow) ?? []
+                continuation.resume(returning: labels)
             })
         }
     }
 
+    func handleShippingLabelSyncingResult(result: Result<[ShippingLabel], Error>, isRevampedFlow: Bool) -> [ShippingLabel] {
+        switch result {
+        case .success(let shippingLabels):
+            ServiceLocator.analytics.track(event: .shippingLabelsAPIRequest(
+                result: .success,
+                isRevampedFlow: isRevampedFlow
+            ))
+            return shippingLabels
+        case .failure(let error):
+            ServiceLocator.analytics.track(event: .shippingLabelsAPIRequest(
+                result: .failed(error: error),
+                isRevampedFlow: isRevampedFlow
+            ))
+            if error as? DotcomError == .noRestRoute {
+                DDLogError("⚠️ Endpoint for synchronizing shipping labels is unreachable. WC Shipping plugin may be missing.")
+            } else {
+                DDLogError("⛔️ Error synchronizing shipping labels: \(error)")
+            }
+            return []
+        }
+    }
+
     @MainActor
     func isPluginActive(_ plugin: String) async -> Bool {
         return await isPluginActive([plugin])