Review findings

Author: adborbas

WooCommerce/Classes/Bookings/BookingList/BookingListContainerViewModel.swift

@@ -101,11 +101,11 @@ final class BookingListContainerViewModel: ObservableObject {
     func listViewModel(for tab: BookingListTab) -> BookingListViewModel {
         switch tab {
         case .today:
-            return todayListViewModel
+            todayListViewModel
         case .upcoming:
-            return upcomingListViewModel
+            upcomingListViewModel
         case .all:
-            return allListViewModel
+            allListViewModel
         }
     }
 
@@ -204,7 +204,7 @@ extension BookingListContainerViewModel: BookingListsRefreshCoordinating {
         await withTaskGroup(of: Void.self) { group in
             for viewModel in allTabViewModels {
                 group.addTask { @MainActor in
-                    await viewModel.onRefreshSelfAction(
+                    await viewModel.reloadData(
                         reason: BookingListViewModel.siblingRefreshReason
                     )
                 }

WooCommerce/Classes/Bookings/BookingList/BookingListViewModel.swift

@@ -109,9 +109,9 @@ final class BookingListViewModel: ObservableObject {
     }
 
     @MainActor
-    func onRefreshSelfAction(reason: String? = nil) async {
+    func reloadData(reason: String = BookingListViewModel.refreshCacheReason) async {
         await withCheckedContinuation { continuation in
-            paginationTracker.resync(reason: reason ?? Self.refreshCacheReason) {
+            paginationTracker.resync(reason: reason) {
                 continuation.resume(returning: ())
             }
         }

WooCommerce/Classes/Bookings/BookingList/BookingSearchViewModel.swift

@@ -59,7 +59,7 @@ final class BookingSearchViewModel: ObservableObject {
 
     /// Called when the user pulls down the list to refresh.
     @MainActor
-    func onRefreshAction(reason: String? = nil) async {
+    func onRefreshAction() async {
         await withCheckedContinuation { continuation in
             searchPaginationTracker.resync(reason: nil) {
                 continuation.resume(returning: ())

WooCommerce/WooCommerceTests/ViewRelated/Bookings/BookingListViewModelTests.swift

@@ -307,7 +307,7 @@ struct BookingListViewModelTests {
         let viewModel = BookingListViewModel(siteID: sampleSiteID, type: .all, stores: stores)
 
         // When
-        await viewModel.onRefreshSelfAction()
+        await viewModel.reloadData()
 
         // Then
         #expect(skip == 0)