Only clean up files in the docs directory

Author: joshheald

Modules/Sources/Networking/Remote/POSCatalogSyncRemote.swift

@@ -214,14 +214,13 @@ public class POSCatalogSyncRemote: Remote, POSCatalogSyncRemoteProtocol {
     ///   - fileURL: Local file URL of the downloaded catalog.
     ///   - siteID: Site ID for proper mapping.
     /// - Returns: Parsed POS catalog.
-    private func parseDownloadedCatalog(from fileURL: URL, siteID: Int64) async throws -> POSCatalogResponse {
+    func parseDownloadedCatalog(from fileURL: URL, siteID: Int64) async throws -> POSCatalogResponse {
         let data = try Data(contentsOf: fileURL)
 
-        // Clean up the downloaded file after reading.
-        // Background downloads are moved to temporary directory by BackgroundDownloadService,
-        // so we always clean them up after parsing.
+        // Clean up downloaded files, but only if they're in our Documents directory.
+        // Files in iOS temporary directories should be left for iOS to clean up automatically.
         defer {
-            try? fileManager.removeItem(at: fileURL)
+            cleanupDownloadedFileIfNeeded(at: fileURL)
         }
 
         let mapper = ListMapper<POSProduct>(siteID: siteID)
@@ -233,6 +232,21 @@ public class POSCatalogSyncRemote: Remote, POSCatalogSyncRemoteProtocol {
         return POSCatalogResponse(products: products, variations: variations)
     }
 
+    /// Cleans up the downloaded catalog file if it's in our Documents directory.
+    /// Files in temporary directories are left for iOS to clean up automatically.
+    private func cleanupDownloadedFileIfNeeded(at fileURL: URL) {
+        // Only clean up files in our Documents directory
+        // Temporary files should be left for iOS to handle
+        let documentsURLs = fileManager.urls(for: .documentDirectory, in: .userDomainMask)
+        guard let documentsURL = documentsURLs.first,
+              fileURL.path.hasPrefix(documentsURL.path),
+              fileManager.fileExists(atPath: fileURL.path) else {
+            return
+        }
+
+        try? fileManager.removeItem(at: fileURL)
+    }
+
     /// Loads POS products for full sync.
     ///
     /// - Parameters: