Revert redundant changes

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/ListSelector/PaginatedListSelectorViewController.swift

@@ -8,7 +8,7 @@ import class AutomatticTracks.CrashLogging
 /// A generic data source for the paginated list selector UI `PaginatedListSelectorViewController`.
 ///
 protocol PaginatedListSelectorDataSource {
-    associatedtype StorageModel: ResultsControllerMutableType & ReadOnlyConvertible
+    associatedtype StorageModel: ResultsControllerMutableType
     associatedtype Cell: UITableViewCell
 
     /// Optional custom sorting strategy for storage models in the paginated list. Default is `nil`.
@@ -55,10 +55,7 @@ extension PaginatedListSelectorDataSource {
 ///
 final class PaginatedListSelectorViewController<DataSource: PaginatedListSelectorDataSource, Model, StorageModel, Cell>: UIViewController,
     UITableViewDataSource, UITableViewDelegate, UITableViewDragDelegate, PaginationTrackerDelegate, GhostableViewController
-where DataSource.StorageModel == StorageModel,
-      Model == DataSource.StorageModel.ReadOnlyType,
-      Model: Equatable,
-      DataSource.Cell == Cell {
+where DataSource.StorageModel == StorageModel, Model == DataSource.StorageModel.ReadOnlyType, Model: Equatable, DataSource.Cell == Cell {
     private let viewProperties: PaginatedListSelectorViewProperties
     private var dataSource: DataSource
     private let onDismiss: (_ selected: Model?) -> Void

WooCommerce/Classes/ViewRelated/Products/Edit Product/Linked Products List Selector/ProductListSelector/ProductListMultiSelectorDataSource.swift

@@ -4,8 +4,6 @@ import Yosemite
 
 /// Enables the user to select multiple products from a paginated list.
 final class ProductListMultiSelectorDataSource: PaginatedListSelectorDataSource {
-    var customResultsSortOrder: ((Product, Product) -> Bool)?
-
     typealias StorageModel = StorageProduct
 
     // Observable list of the latest product IDs

WooCommerce/Classes/ViewRelated/Search/SearchUICommand.swift

@@ -4,7 +4,7 @@ import Yosemite
 
 /// An interface for search UI associated with a generic model and cell view model.
 protocol SearchUICommand {
-    associatedtype Model // model to send to selection closure
+    associatedtype Model
     associatedtype CellViewModel
     associatedtype EmptyStateViewControllerType: UIViewController = EmptyStateViewController
 
@@ -43,8 +43,7 @@ protocol SearchUICommand {
     /// Set externally to enable resyncing the models when needed. Otherwise, an empty closure can be set by default.
     var resynchronizeModels: (() -> Void) { get set }
 
-    associatedtype ResultsControllerModel: ResultsControllerMutableType & ReadOnlyConvertible where
-    ResultsControllerModel.ReadOnlyType == Model
+    associatedtype ResultsControllerModel: ResultsControllerMutableType & ReadOnlyConvertible where ResultsControllerModel.ReadOnlyType == Model
     /// Creates a results controller for the search results. The result model's readonly type matches the search result model.
     func createResultsController() -> ResultsController<ResultsControllerModel>
 
@@ -97,7 +96,7 @@ protocol SearchUICommand {
 
     /// Creates a view model for the search result cell.
     ///
-    /// - Parameter model: search result model used to display on list items.
+    /// - Parameter model: search result model.
     /// - Returns: a view model based on the search result model.
     func createCellViewModel(model: Model) -> CellViewModel