Relay Networking.CreateCartError to Yosemite.CreateCartError.

Author: jaclync

Yosemite/Yosemite/Actions/PaymentAction.swift

@@ -12,7 +12,8 @@ public enum PaymentAction: Action {
 
     /// Creates a cart with a WPCOM plan.
     /// - Parameters:
-    ///   - productID: The ID of the WPCOM plan product.
+    ///   - productID: The ID of the WPCOM plan product. It is of string type to integrate with `InAppPurchasesForWPComPlansProtocol`.
+    ///                If the value is not a string of integer value, an error `CreateCartError.invalidProductID` is returned.
     ///   - siteID: The site ID for the WPCOM plan to be attached to.
     ///   - completion: The result of cart creation.
     case createCart(productID: String,

Yosemite/Yosemite/Stores/PaymentStore.swift

@@ -70,7 +70,15 @@ private extension PaymentStore {
                 _ = try await remote.createCart(siteID: siteID, productID: productID)
                 completion(.success(()))
             } catch {
-                completion(.failure(error))
+                switch error {
+                case let networkError as Networking.CreateCartError:
+                    switch networkError {
+                    case .productNotInCart:
+                        completion(.failure(CreateCartError.productNotInCart))
+                    }
+                default:
+                    completion(.failure(error))
+                }
             }
         }
     }
@@ -80,4 +88,6 @@ private extension PaymentStore {
 public enum CreateCartError: Error, Equatable {
     /// Product ID is not in the correct format for WPCOM plans.
     case invalidProductID
+    /// The expected product is not in the created cart.
+    case productNotInCart
 }

Yosemite/YosemiteTests/Stores/PaymentStoreTests.swift

@@ -104,6 +104,23 @@ final class PaymentStoreTests: XCTestCase {
         XCTAssertEqual(error as? Yosemite.CreateCartError, .invalidProductID)
     }
 
+    func test_createCart_relays_networking_CreateCartError_failure() throws {
+        // Given
+        remote.whenCreatingCart(thenReturn: .failure(Networking.CreateCartError.productNotInCart))
+
+        // When
+        let result = waitFor { promise in
+            self.store.onAction(PaymentAction.createCart(productID: "12", siteID: 62) { result in
+                promise(result)
+            })
+        }
+
+        // Then
+        XCTAssertTrue(result.isFailure)
+        let error = try XCTUnwrap(result.failure)
+        XCTAssertEqual(error as? Yosemite.CreateCartError, .productNotInCart)
+    }
+
     func test_createCart_returns_failure_on_error() throws {
         // Given
         remote.whenCreatingCart(thenReturn: .failure(NetworkError.timeout))