Skip to content

Commit 41c1aeb

Browse files
Alter unit test to ensure JSON encoding is not used.
1 parent 166f1d0 commit 41c1aeb

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

Networking/NetworkingTests/Requests/RESTRequestTests.swift

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ final class RESTRequestTests: XCTestCase {
2727

2828
func test_it_uses_JSON_encoding_for_post_method() throws {
2929
// Given
30-
let request = RESTRequest(siteURL: sampleSiteAddress, wooApiVersion: sampleWooApiVersion, method: .post, path: sampleRPC)
30+
let request = RESTRequest(siteURL: sampleSiteAddress, wooApiVersion: sampleWooApiVersion, method: .post, path: sampleRPC, parameters: sampleParameters)
3131

3232
// When
3333
let urlRequest = try request.asURLRequest()
@@ -38,7 +38,7 @@ final class RESTRequestTests: XCTestCase {
3838

3939
func test_it_uses_JSON_encoding_for_put_method() throws {
4040
// Given
41-
let request = RESTRequest(siteURL: sampleSiteAddress, wooApiVersion: sampleWooApiVersion, method: .put, path: sampleRPC)
41+
let request = RESTRequest(siteURL: sampleSiteAddress, wooApiVersion: sampleWooApiVersion, method: .put, path: sampleRPC, parameters: sampleParameters)
4242

4343
// When
4444
let urlRequest = try request.asURLRequest()
@@ -47,17 +47,21 @@ final class RESTRequestTests: XCTestCase {
4747
XCTAssertEqual(urlRequest.value(forHTTPHeaderField: "Content-Type"), "application/json")
4848
}
4949

50-
func test_it_uses_URL_encoding_for_methods_other_than_post_and_put() throws {
50+
func test_it_does_not_use_JSON_encoding_for_methods_other_than_post_and_put() throws {
5151
// Given
5252
let methods: [HTTPMethod] = [.options, .get, .head, .patch, .delete, .trace, .connect]
5353
for method in methods {
54-
let request = RESTRequest(siteURL: sampleSiteAddress, wooApiVersion: sampleWooApiVersion, method: method, path: sampleRPC)
54+
let request = RESTRequest(siteURL: sampleSiteAddress,
55+
wooApiVersion: sampleWooApiVersion,
56+
method: method,
57+
path: sampleRPC,
58+
parameters: sampleParameters)
5559

5660
// When
5761
let urlRequest = try request.asURLRequest()
5862

5963
// Then
60-
XCTAssertEqual(urlRequest.value(forHTTPHeaderField: "Content-Type"), "application/x-www-form-urlencoded; charset=utf-8")
64+
XCTAssertNotEqual(urlRequest.value(forHTTPHeaderField: "Content-Type"), "application/json")
6165
}
6266
}
6367
}

0 commit comments

Comments
 (0)