Replace DomainSelectorViewModel.placeholderImage with searchTerm check to show a placeholder image.

Author: jaclync

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Domains/DomainSelectorView.swift

@@ -108,12 +108,11 @@ struct DomainSelectorView: View {
                         .bodyStyle()
                         .padding(.horizontal, Layout.defaultHorizontalPadding)
 
-                    // Domain results.
-                    if let placeholderImage = viewModel.placeholderImage {
+                    if viewModel.searchTerm.isEmpty {
                         // Placeholder image when search query is empty.
                         HStack {
                             Spacer()
-                            Image(uiImage: placeholderImage)
+                            Image(uiImage: .domainSearchPlaceholderImage)
                             Spacer()
                         }
                     } else if viewModel.isLoadingDomainSuggestions {

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Domains/DomainSelectorViewModel.swift

@@ -18,9 +18,6 @@ final class DomainSelectorViewModel: ObservableObject {
     /// Whether domain suggestions are being loaded.
     @Published private(set) var isLoadingDomainSuggestions: Bool = false
 
-    /// Placeholder image is set when the search term is empty. Otherwise, the placeholder image is `nil`.
-    @Published private(set) var placeholderImage: UIImage?
-
     /// Subscription for search query changes for domain search.
     private var searchQuerySubscription: AnyCancellable?
 
@@ -44,19 +41,15 @@ final class DomainSelectorViewModel: ObservableObject {
 
 private extension DomainSelectorViewModel {
     func observeDomainQuery() {
-        let searchTermPublisher = $searchTerm
+        searchQuerySubscription = $searchTerm
             .map { $0.trimmingCharacters(in: .whitespacesAndNewlines) }
             .debounce(for: .seconds(debounceDuration), scheduler: DispatchQueue.main)
-            .share()
-
-        searchQuerySubscription = searchTermPublisher
             .filter { $0.isNotEmpty }
             .removeDuplicates()
             .sink { [weak self] searchTerm in
                 guard let self = self else { return }
                 Task { @MainActor in
                     self.errorMessage = nil
-                    self.placeholderImage = nil
                     self.isLoadingDomainSuggestions = true
                     let result = await self.loadFreeDomainSuggestions(query: searchTerm)
                     self.isLoadingDomainSuggestions = false
@@ -69,12 +62,6 @@ private extension DomainSelectorViewModel {
                     }
                 }
             }
-
-        searchTermPublisher
-            .map {
-                $0.isEmpty ? UIImage.domainSearchPlaceholderImage: nil
-            }
-            .assign(to: &$placeholderImage)
     }
 
     @MainActor

WooCommerce/WooCommerceTests/ViewModels/Domains/DomainSelectorViewModelTests.swift

@@ -113,33 +113,6 @@ final class DomainSelectorViewModelTests: XCTestCase {
         }
     }
 
-    // MARK: - `placeholderImage`
-
-    func test_placeholderImage_is_not_nil_when_searchTerm_is_empty_initially() {
-        // Then
-        waitUntil {
-            self.viewModel.placeholderImage != nil
-        }
-    }
-
-    func test_placeholderImage_is_nil_when_searchTerm_is_not_empty() {
-        // When the search term is not empty
-        viewModel.searchTerm = "woo"
-
-        // Then placeholder image is nil
-        waitUntil {
-            self.viewModel.placeholderImage == nil
-        }
-
-        // When setting the search term to empty spaces
-        viewModel.searchTerm = "  "
-
-        // Then placeholder image is not nil
-        waitUntil {
-            self.viewModel.placeholderImage != nil
-        }
-    }
-
     // MARK: `isLoadingDomainSuggestions`
 
     func test_isLoadingDomainSuggestions_is_toggled_when_loading_suggestions() {