Merge pull request #8042 from woocommerce/issue/8020-fix-push-deeplink

Ecarrion · web-flow · commit 4b78b1087e0c · 2022-11-04T15:39:32.000-05:00
Fix order notification deeplink
diff --git a/WooCommerce/Classes/Notifications/PushNotificationsManager.swift b/WooCommerce/Classes/Notifications/PushNotificationsManager.swift
@@ -477,6 +477,7 @@ private extension PushNotificationsManager {
     /// Handles a remote notification while the app is inactive.
     ///
     /// - Parameter notification: Push notification content from a remote notification.
+    @MainActor
     func handleInactiveRemoteNotification(notification: PushNotification) async {
         guard applicationState == .inactive else {
             return
diff --git a/WooCommerce/Classes/ViewRelated/MainTabBarController.swift b/WooCommerce/Classes/ViewRelated/MainTabBarController.swift
@@ -337,10 +337,8 @@ extension MainTabBarController {
             }
             let siteID = Int64(note.meta.identifier(forKey: .site) ?? Int.min)
 
-            switchToStore(with: siteID, onCompletion: { siteChanged in
-                if siteChanged {
-                    presentNotificationDetails(for: note)
-                }
+            switchToStore(with: siteID, onCompletion: { _ in
+                presentNotificationDetails(for: note)
             })
         }
         ServiceLocator.stores.dispatch(action)

Original file line number	Diff line number	Diff line change
`@@ -337,10 +337,8 @@ extension MainTabBarController {`
`337`	`337`	`}`
`338`	`338`	`let siteID = Int64(note.meta.identifier(forKey: .site) ?? Int.min)`
`339`	`339`
`340`		`- switchToStore(with: siteID, onCompletion: { siteChanged in`
`341`		`- if siteChanged {`
`342`		`- presentNotificationDetails(for: note)`
`343`		`- }`
	`340`	`+ switchToStore(with: siteID, onCompletion: { _ in`
	`341`	`+ presentNotificationDetails(for: note)`
`344`	`342`	`})`
`345`	`343`	`}`
`346`	`344`	`ServiceLocator.stores.dispatch(action)`