[Woo POS][Historical Orders] Order List and Details Split view layout (#16031)

Author: staskus

Modules/Tests/YosemiteTests/PointOfSale/POSSearchHistoryServiceTests.swift

@@ -43,7 +43,6 @@ struct POSSearchHistoryServiceTests {
         #expect(history[2] == "first")
     }
 
-    @available(iOS 17.0, *)
     @Test func saveSuccessfulSearch_removes_duplicates() throws {
         // Given
         let itemType: POSItemType = .product

WooCommerce/Classes/POS/Controllers/POSEntryPointController.swift

@@ -1,7 +1,6 @@
 import SwiftUI
 import protocol Experiments.FeatureFlagService
 
-@available(iOS 17.0, *)
 @Observable final class POSEntryPointController {
     private(set) var eligibilityState: POSEligibilityState?
     private let posEligibilityChecker: POSEntryPointEligibilityCheckerProtocol

WooCommerce/Classes/POS/Controllers/PointOfSaleCouponsController.swift

@@ -6,14 +6,12 @@ import protocol Yosemite.PointOfSaleCouponServiceProtocol
 import struct Yosemite.PointOfSaleCouponFetchStrategyFactory
 import protocol Yosemite.PointOfSaleCouponFetchStrategy
 
-@available(iOS 17.0, *)
 protocol PointOfSaleCouponsControllerProtocol: PointOfSaleSearchingItemsControllerProtocol {
     /// Enables coupons in store settings
     /// Returns true if coupons enabled
     func enableCoupons() async
 }
 
-@available(iOS 17.0, *)
 @Observable final class PointOfSaleCouponsController: PointOfSaleCouponsControllerProtocol {
     var itemsViewState: ItemsViewState = ItemsViewState(containerState: .content,
                                                         itemsStack: ItemsStackState(root: .loading([]),
@@ -94,7 +92,6 @@ protocol PointOfSaleCouponsControllerProtocol: PointOfSaleSearchingItemsControll
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleCouponsController {
     /// Loads the first page by attempting to load the first page from local storage
     /// then syncs from the remote regardless the result
@@ -140,7 +137,6 @@ private extension PointOfSaleCouponsController {
 
 // MARK: - View state helpers
 //
-@available(iOS 17.0, *)
 private extension PointOfSaleCouponsController {
     func setSearchingState() {
         itemsViewState.itemsStack.root = .loading([])

WooCommerce/Classes/POS/Controllers/PointOfSaleItemsController.swift

@@ -11,7 +11,6 @@ import class Yosemite.Store
 import enum Yosemite.POSItemType
 
 
-@available(iOS 17.0, *)
 protocol PointOfSaleItemsControllerProtocol {
     ///
     var itemsViewState: ItemsViewState { get }
@@ -23,15 +22,13 @@ protocol PointOfSaleItemsControllerProtocol {
     func loadNextItems(base: ItemListBaseItem) async
 }
 
-@available(iOS 17.0, *)
 protocol PointOfSaleSearchingItemsControllerProtocol: PointOfSaleItemsControllerProtocol {
     /// Searches for items
     func searchItems(searchTerm: String, baseItem: ItemListBaseItem) async
     func clearSearchItems(baseItem: ItemListBaseItem)
 }
 
 
-@available(iOS 17.0, *)
 @Observable final class PointOfSaleItemsController: PointOfSaleSearchingItemsControllerProtocol {
     var itemsViewState: ItemsViewState
     private let paginationTracker: AsyncPaginationTracker
@@ -198,7 +195,6 @@ protocol PointOfSaleSearchingItemsControllerProtocol: PointOfSaleItemsController
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleItemsController {
     func setLoadingState(base: ItemListBaseItem) {
         switch base {
@@ -241,7 +237,6 @@ private extension PointOfSaleItemsController {
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleItemsController {
     /// Fetches items given a page number and appends new unique items to the `allItems` array.
     /// - Parameter pageNumber: Page number to fetch items from.
@@ -309,7 +304,6 @@ private extension PointOfSaleItemsController {
 }
 
 // MARK: - ItemsViewState Updates
-@available(iOS 17.0, *)
 private extension PointOfSaleItemsController {
     func updateState(for parent: POSItem, to state: ItemListState) {
         let viewState = itemsViewState

WooCommerce/Classes/POS/Controllers/PointOfSaleOrderController.swift

@@ -39,7 +39,6 @@ protocol PointOfSaleOrderControllerProtocol {
     func collectCashPayment(changeDueAmount: String?) async throws
 }
 
-@available(iOS 17.0, *)
 @Observable final class PointOfSaleOrderController: PointOfSaleOrderControllerProtocol {
     init(orderService: POSOrderServiceProtocol,
          receiptService: POSReceiptServiceProtocol,
@@ -168,7 +167,6 @@ protocol PointOfSaleOrderControllerProtocol {
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleOrderController {
     func totals(for order: Order) -> PointOfSaleOrderTotals {
         let totalsCalculator = OrderTotalsCalculator(for: order,
@@ -210,7 +208,6 @@ private extension PointOfSaleOrderController {
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleOrderController {
     @MainActor
     func isPluginSupported(_ plugin: Plugin, minimumVersion: String, siteID: Int64) -> Bool {
@@ -231,7 +228,6 @@ private extension PointOfSaleOrderController {
 
 // MARK: - Error Handling
 
-@available(iOS 17.0, *)
 private extension PointOfSaleOrderController {
     func orderStateError(from error: Error) -> PointOfSaleOrderState.OrderStateError {
         if let couponsError = CouponsError(underlyingError: error) {
@@ -244,7 +240,6 @@ private extension PointOfSaleOrderController {
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleOrderController {
     enum POSReceiptEligibilityConstants {
         static let wcPluginMinimumVersion = "10.0.0"
@@ -300,7 +295,6 @@ extension PointOfSaleInternalOrderState: Equatable {
     }
 }
 
-@available(iOS 17.0, *)
 extension PointOfSaleOrderController {
     enum PointOfSaleOrderControllerError: Error {
         case noSiteID
@@ -309,7 +303,6 @@ extension PointOfSaleOrderController {
 }
 
 
-@available(iOS 17.0, *)
 private extension PointOfSaleOrderController {
     func trackOrderCreationFailed(error: Error) {
         var errorType: WooAnalyticsEvent.Orders.OrderCreationErrorType?

WooCommerce/Classes/POS/Models/ItemsStackState.swift

@@ -2,7 +2,6 @@ import Foundation
 import enum Yosemite.POSItem
 import Observation
 
-@available(iOS 17.0, *)
 @Observable final class ItemsStackState {
     var root: ItemListState
     var itemStates: [POSItem: ItemListState]
@@ -13,7 +12,6 @@ import Observation
     }
 }
 
-@available(iOS 17.0, *)
 extension ItemsStackState: Equatable {
     static func == (lhs: ItemsStackState, rhs: ItemsStackState) -> Bool {
         return lhs.root == rhs.root

WooCommerce/Classes/POS/Models/ItemsViewState.swift

@@ -1,7 +1,6 @@
 import Foundation
 import Observation
 
-@available(iOS 17.0, *)
 @Observable class ItemsViewState {
     var containerState: ItemsContainerState
     var itemsStack: ItemsStackState
@@ -12,7 +11,6 @@ import Observation
     }
 }
 
-@available(iOS 17.0, *)
 extension ItemsViewState: Equatable {
     static func == (lhs: ItemsViewState, rhs: ItemsViewState) -> Bool {
         return lhs.containerState == rhs.containerState

WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift

@@ -14,7 +14,6 @@ import enum Yosemite.POSItemType
 import protocol Yosemite.PointOfSaleBarcodeScanServiceProtocol
 import enum Yosemite.PointOfSaleBarcodeScanError
 
-@available(iOS 17.0, *)
 protocol PointOfSaleAggregateModelProtocol {
     var orderStage: PointOfSaleOrderStage { get }
 
@@ -50,7 +49,6 @@ protocol PointOfSaleAggregateModelProtocol {
     func pointOfSaleClosed()
 }
 
-@available(iOS 17.0, *)
 @Observable final class PointOfSaleAggregateModel: PointOfSaleAggregateModelProtocol {
     private(set) var orderStage: PointOfSaleOrderStage = .building
 
@@ -136,7 +134,6 @@ protocol PointOfSaleAggregateModelProtocol {
 }
 
 // MARK: - Cart
-@available(iOS 17.0, *)
 extension PointOfSaleAggregateModel {
     func addToCart(_ item: POSItem) {
         trackCustomerInteractionStarted()
@@ -186,7 +183,6 @@ extension PointOfSaleAggregateModel {
 }
 
 // MARK: - Barcode Scanning
-@available(iOS 17.0, *)
 extension PointOfSaleAggregateModel {
     func barcodeScanned(_ result: Result<String, HIDBarcodeParserError>) {
         Task { @MainActor [weak self] in
@@ -263,7 +259,6 @@ extension PointOfSaleAggregateModel {
 }
 
 // MARK: - Search
-@available(iOS 17.0, *)
 extension PointOfSaleAggregateModel {
     func saveSearchTerm(_ term: String, for itemType: POSItemType) {
         searchHistoryService.saveSuccessfulSearch(term: term, for: itemType)
@@ -275,7 +270,6 @@ extension PointOfSaleAggregateModel {
 }
 
 // MARK: - Track events
-@available(iOS 17.0, *)
 private extension PointOfSaleAggregateModel {
     func trackCustomerInteractionStarted() {
         // At the moment we're assumming that an interaction starts simply when the cart is zero
@@ -303,7 +297,6 @@ private extension PointOfSaleAggregateModel {
 }
 
 // MARK: - Card payments
-@available(iOS 17.0, *)
 extension PointOfSaleAggregateModel {
     private func publishCardReaderConnectionStatus() {
         cardPresentPaymentService.readerConnectionStatusPublisher
@@ -476,7 +469,6 @@ extension PointOfSaleAggregateModel {
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleAggregateModel {
     func publishPaymentMessages() {
         cardPresentPaymentService.paymentEventPublisher
@@ -594,7 +586,6 @@ private extension PointOfSaleAggregateModel {
 }
 
 // MARK: - Order syncing
-@available(iOS 17.0, *)
 extension PointOfSaleAggregateModel {
     @MainActor
     func checkOut() async {
@@ -609,7 +600,6 @@ extension PointOfSaleAggregateModel {
 }
 
 // MARK: - Lifecycle
-@available(iOS 17.0, *)
 extension PointOfSaleAggregateModel {
     func pointOfSaleClosed() {
         // We cancel any payment to prevent the reader from remaining live and awaiting a card tap. Otherwise, it would
@@ -630,7 +620,6 @@ extension PointOfSaleAggregateModel {
     }
 }
 
-@available(iOS 17.0, *)
 private extension PointOfSaleAggregateModel {
     enum Constants {
         static let initialPage: Int = 1

WooCommerce/Classes/POS/Models/PointOfSaleViewStateCoordinator.swift

@@ -1,6 +1,5 @@
 import Foundation
 
-@available(iOS 17.0, *)
 protocol PointOfSaleViewStateResettable {
     /// Resets all view state to its default values.
     /// This should be called when starting a new cart to ensure the UI returns to its initial state.
@@ -10,7 +9,6 @@ protocol PointOfSaleViewStateResettable {
 /// Coordinates view-specific state for the Point of Sale interface.
 /// This coordinator manages UI state that needs to persist across the POS experience
 /// but should be reset when starting a new cart/order.
-@available(iOS 17.0, *)
 @Observable final class PointOfSaleViewStateCoordinator: PointOfSaleViewStateResettable {
     /// The currently selected item list type, shown when building the cart.
     /// When we reset, the non-searched products list is shown for the new cart.

WooCommerce/Classes/POS/Presentation/Barcode Scanner Setup/PointOfSaleBarcodeScannerSetup.swift

@@ -1,6 +1,5 @@
 import SwiftUI
 
-@available(iOS 17.0, *)
 struct PointOfSaleBarcodeScannerSetup: View {
     @Binding var isPresented: Bool
     @State private var flowManager: PointOfSaleBarcodeScannerSetupFlowManager
@@ -91,7 +90,6 @@ private enum Constants {
 }
 
 // MARK: - Private Localization Extension
-@available(iOS 17.0, *)
 private extension PointOfSaleBarcodeScannerSetup {
     enum Localization {
         static let starBSH20BTitle = NSLocalizedString(
@@ -119,7 +117,6 @@ private extension PointOfSaleBarcodeScannerSetup {
 
 // MARK: - Previews
 
-@available(iOS 17.0, *)
 #Preview {
     PointOfSaleBarcodeScannerSetup(isPresented: .constant(true))
 }
@@ -131,7 +128,6 @@ private extension PointOfSaleBarcodeScannerSetup {
 /// - On content change: fades out old content, replaces it, then fades in new content.
 /// - Handles height changes with a spring animation.
 ///
-@available(iOS 17.0, *)
 private struct AnimatedTransitionContainer<Content: View, ID: Equatable>: View {
     let maxWidth: CGFloat
     let maxHeight: CGFloat