Move pointOfSaleLoaded (pos_loaded) event tracking from PointOfSaleLoadingView (which can be shown anytime within POS) to PointOfSaleDashboardView.

Author: jaclync

WooCommerce/Classes/POS/Presentation/CardReaderConnection/UI States/PointOfSaleLoadingView.swift

@@ -1,8 +1,6 @@
 import SwiftUI
 
 struct PointOfSaleLoadingView: View {
-    @State private var waitingTimeTracker: WaitingTimeTracker?
-
     var body: some View {
         HStack(alignment: .center) {
             Spacer()
@@ -15,28 +13,10 @@ struct PointOfSaleLoadingView: View {
             .multilineTextAlignment(.center)
             Spacer()
         }
-        .onAppear {
-            trackTimeOnAppear()
-        }
-        .onDisappear {
-            trackElapsedTimeOnDisappear()
-        }
         .background(Color.posSurface)
     }
 }
 
-private extension PointOfSaleLoadingView {
-    func trackTimeOnAppear() {
-        waitingTimeTracker = WaitingTimeTracker(trackScenario: .pointOfSaleLoaded)
-    }
-
-    func trackElapsedTimeOnDisappear() {
-        if let waitingTimeTracker = waitingTimeTracker {
-            waitingTimeTracker.end(using: .milliseconds)
-        }
-    }
-}
-
 #Preview {
     PointOfSaleLoadingView()
 }

WooCommerce/Classes/POS/Presentation/PointOfSaleDashboardView.swift

@@ -8,6 +8,7 @@ struct PointOfSaleDashboardView: View {
     @State private var showExitPOSModal: Bool = false
     @State private var showSupport: Bool = false
     @State private var showDocumentation: Bool = false
+    @State private var waitingTimeTracker: WaitingTimeTracker?
 
     @State private var floatingSize: CGSize = .zero
 
@@ -138,6 +139,14 @@ struct PointOfSaleDashboardView: View {
             }
         }
         .ignoresSafeArea(.keyboard)
+        .onAppear {
+            trackTimeForInitialLoadingState()
+        }
+        .onChange(of: viewState) { oldValue, newValue in
+            if newValue == .content && oldValue != newValue {
+                trackElapsedTimeForInitialLoadingState()
+            }
+        }
     }
 
     private var contentView: some View {
@@ -210,6 +219,20 @@ private extension PointOfSaleDashboardView {
     }
 }
 
+@available(iOS 17.0, *)
+private extension PointOfSaleDashboardView {
+    func trackTimeForInitialLoadingState() {
+        waitingTimeTracker = WaitingTimeTracker(trackScenario: .pointOfSaleLoaded)
+    }
+
+    func trackElapsedTimeForInitialLoadingState() {
+        if let waitingTimeTracker {
+            waitingTimeTracker.end(using: .milliseconds)
+            self.waitingTimeTracker = nil
+        }
+    }
+}
+
 struct FloatingControlAreaSizeKey: EnvironmentKey {
     static let defaultValue = CGSize.zero
 }