Fix another round of straightforward Periphery warnings.

Author: jaclync

WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift

@@ -15,36 +15,10 @@ import protocol Yosemite.PointOfSaleBarcodeScanServiceProtocol
 import enum Yosemite.PointOfSaleBarcodeScanError
 
 protocol PointOfSaleAggregateModelProtocol {
-    var orderStage: PointOfSaleOrderStage { get }
-
-    var cardReaderConnectionStatus: CardPresentPaymentReaderConnectionStatus { get }
-    func connectCardReader()
-    func disconnectCardReader()
-    var paymentState: PointOfSalePaymentState { get }
-    var cardPresentPaymentAlertViewModel: PointOfSaleCardPresentPaymentAlertType? { get set }
-    var cardPresentPaymentInlineMessage: PointOfSaleCardPresentPaymentMessageType? { get }
-    func cancelCardPaymentsOnboarding()
-    func trackCardPaymentsOnboardingShown()
-
-    var purchasableItemsController: PointOfSaleItemsControllerProtocol { get }
-    var purchasableItemsSearchController: PointOfSaleSearchingItemsControllerProtocol { get }
-    var couponsController: PointOfSaleCouponsControllerProtocol { get }
-    var couponsSearchController: PointOfSaleSearchingItemsControllerProtocol { get }
-
     var cart: Cart { get }
-    func barcodeScanned(_ result: Result<String, HIDBarcodeParserError>)
     func addToCart(_ item: POSItem)
-    func remove(cartItem: CartItem)
-    func removeAllItemsFromCart(types: [CartItemType])
-    func addMoreToCart()
-    func startNewCart()
 
     func saveSearchTerm(_ term: String, for itemType: POSItemType)
-
-    var orderState: PointOfSaleOrderState { get }
-    func checkOut() async
-
-    func pointOfSaleClosed()
 }
 
 @Observable final class PointOfSaleAggregateModel: PointOfSaleAggregateModelProtocol {

WooCommerce/Classes/POS/Presentation/Item Selector/ItemList.swift

@@ -151,7 +151,6 @@ struct ItemListRow: View {
     let item: POSItem
     let itemActionHandler: POSItemActionHandler
     @Binding var activeNavigationItem: POSItem?
-    @Environment(PointOfSaleAggregateModel.self) private var posModel
 
     var body: some View {
         switch item {

WooCommerce/Classes/POS/Utils/POSEnvironmentKeys.swift

@@ -11,10 +11,6 @@ struct SiteTimezoneKey: EnvironmentKey {
     static let defaultValue: TimeZone = .current
 }
 
-struct POSDependenciesKey: EnvironmentKey {
-    static let defaultValue: POSDependencyProviding? = nil
-}
-
 extension EnvironmentValues {
     var siteTimezone: TimeZone {
         get { self[SiteTimezoneKey.self] }

WooCommerce/Classes/POS/Utils/PreviewHelpers.swift

@@ -82,17 +82,11 @@ final class PointOfSalePreviewItemService: PointOfSaleItemServiceProtocol {
         .init(items: mockVariationItems, hasMorePages: true, totalItems: nil)
     }
 
-    func providePointOfSaleItems() -> [POSItem] {
-        return mockItems
-    }
-
     func providePointOfSaleItem() -> POSOrderableItem {
         POSProductPreview(id: UUID(),
                           name: "Product 1",
                           formattedPrice: "$1.00")
     }
-
-    var fetchStrategy: PointOfSalePurchasableItemFetchStrategy = PointOfSalePreviewPurchasableItemFetchStrategy()
 }
 
 struct PointOfSalePreviewPurchasableItemFetchStrategy: PointOfSalePurchasableItemFetchStrategy {
@@ -121,15 +115,14 @@ final class PointOfSalePreviewItemsController: PointOfSaleSearchingItemsControll
     @Published var itemsViewState: ItemsViewState = ItemsViewState(containerState: .loading,
                                                                    itemsStack: ItemsStackState(root: .loading([]),
                                                                                                itemStates: [:]))
-    var itemsViewStatePublisher: any Publisher<ItemsViewState, Never> { $itemsViewState }
 
     func loadItems(base: ItemListBaseItem) async {
         switch base {
         case .root:
             itemsViewState = ItemsViewState(containerState: .content, itemsStack: ItemsStackState(root: .loaded(mockItems, hasMoreItems: true),
                                                                                                   itemStates: [:]))
-        case .parent(let parent):
-            await loadInitialChildItems(for: parent)
+        case .parent:
+            break
         }
     }
 
@@ -145,10 +138,6 @@ final class PointOfSalePreviewItemsController: PointOfSaleSearchingItemsControll
         itemsViewState = ItemsViewState(containerState: .content, itemsStack: ItemsStackState(root: .loading(mockItems),
                                                                                               itemStates: [:]))
     }
-
-    private func loadInitialChildItems(for parent: POSItem) async {
-        // Set `itemsViewState` instead.
-    }
 }
 
 final class PointOfSalePreviewItemActionHandler: POSItemActionHandler {
@@ -214,13 +203,6 @@ private var mockVariationItems: [POSItem] {
     ]
 }
 
-final class POSConnectivityObserverPreview: ConnectivityObserver {
-    @Published private(set) var currentStatus: ConnectivityStatus = .unknown
-    var statusPublisher: AnyPublisher<ConnectivityStatus, Never> {
-        $currentStatus.eraseToAnyPublisher()
-    }
-}
-
 struct POSPreviewHelpers {
     static func makePreviewAggregateModel(
         itemsController: PointOfSaleItemsControllerProtocol = PointOfSalePreviewItemsController(),

WooCommerce/WooCommerceTests/POS/Mocks/MockPointOfSaleAggregateModel.swift

@@ -5,88 +5,9 @@ import protocol Yosemite.POSOrderableItem
 import enum Yosemite.POSItemType
 
 final class MockPointOfSaleAggregateModel: PointOfSaleAggregateModelProtocol {
-    var cardReaderConnectionStatus: CardPresentPaymentReaderConnectionStatus
-
-    func connectCardReader() { }
-
-    func disconnectCardReader() { }
-
-    var paymentState: WooCommerce.PointOfSalePaymentState
-
-    var cardPresentPaymentAlertViewModel: WooCommerce.PointOfSaleCardPresentPaymentAlertType?
-
-    var cardPresentPaymentInlineMessage: WooCommerce.PointOfSaleCardPresentPaymentMessageType?
-
-    var cardPresentPaymentOnboardingViewContainer: WooCommerce.CardPresentPaymentOnboardingViewContainer?
-
-    func cancelCardPaymentsOnboarding() { }
-
-    func trackCardPaymentsOnboardingShown() { }
-
-    var orderStage: PointOfSaleOrderStage
-
-    var orderState: WooCommerce.PointOfSaleOrderState
-
-    var purchasableItemsController: any WooCommerce.PointOfSaleItemsControllerProtocol
-
-    var purchasableItemsSearchController: any WooCommerce.PointOfSaleSearchingItemsControllerProtocol
-
-    var couponsController: any WooCommerce.PointOfSaleCouponsControllerProtocol
-
-    var couponsSearchController: any WooCommerce.PointOfSaleSearchingItemsControllerProtocol
-
-    var blockReturnToItemSelection: Bool = false
-
-    init(cardReaderConnectionStatus: CardPresentPaymentReaderConnectionStatus = .disconnected,
-         purchasableItemsController: PointOfSaleItemsControllerProtocol = MockPointOfSaleItemsController(),
-         purchasableItemsSearchController: PointOfSaleSearchingItemsControllerProtocol = MockPointOfSalePurchasableItemsSearchController(),
-         couponsController: PointOfSaleCouponsControllerProtocol = MockPointOfSaleCouponsController(),
-         couponsSearchController: PointOfSaleSearchingItemsControllerProtocol = MockPointOfSaleCouponsController(),
-         orderStage: PointOfSaleOrderStage = .building,
-         orderState: PointOfSaleOrderState = .idle,
-         paymentState: PointOfSalePaymentState = .idle) {
-        self.cardReaderConnectionStatus = cardReaderConnectionStatus
-        self.purchasableItemsController = purchasableItemsController
-        self.purchasableItemsSearchController = purchasableItemsSearchController
-        self.couponsController = couponsController
-        self.couponsSearchController = couponsSearchController
-        self.orderStage = orderStage
-        self.orderState = orderState
-        self.paymentState = paymentState
-    }
-
-    func loadItems(base: ItemListBaseItem) async { }
-
-    func loadNextItems(base: ItemListBaseItem) async { }
-
     var cart: Cart = .init()
 
-    func barcodeScanned(_ result: Result<String, HIDBarcodeParserError>) { }
-
     func addToCart(_ item: POSItem) { }
 
-    func remove(cartItem: CartItem) { }
-
-    var removeAllItemsFromCartCalled = false
-    func removeAllItemsFromCart() {
-        removeAllItemsFromCartCalled = true
-    }
-
-    func removeAllItemsFromCart(types: [CartItemType]) { }
-
-    func checkOut() async { }
-
-    func addMoreToCart() { }
-
-    func startNewCart() { }
-
-    func pointOfSaleClosed() { }
-
     func saveSearchTerm(_ term: String, for itemType: POSItemType) { }
-
-    func searchHistory(for itemType: Yosemite.POSItemType) -> [String] {
-        return []
-    }
-
-    func loadPopularItems(type: Yosemite.POSItemType) async { }
 }