Skip to content

Commit 55df457

Browse files
committed
Rename SelectableShipmentRow to SelectableShipmentItemRow
1 parent 3cb5b6c commit 55df457

File tree

4 files changed

+26
-26
lines changed

4 files changed

+26
-26
lines changed

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Split Shipments/CollapsibleShipmentCard.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ struct CollapsibleShipmentCard: View {
2626
VStack(spacing: 0) {
2727
Divider()
2828

29-
SelectableShipmentRow(viewModel: item)
29+
SelectableShipmentItemRow(viewModel: item)
3030
.padding(.leading, Layout.horizontalPadding * 2)
3131
.padding(.trailing, Layout.horizontalPadding)
3232
.padding(.vertical, Layout.verticalPadding)
@@ -45,15 +45,15 @@ private extension CollapsibleShipmentCard {
4545
@ViewBuilder
4646
var mainShipmentRow: some View {
4747
if viewModel.childItemRows.isEmpty {
48-
SelectableShipmentRow(viewModel: viewModel.mainItemRow)
48+
SelectableShipmentItemRow(viewModel: viewModel.mainItemRow)
4949
} else {
5050
Button(action: {
5151
withAnimation {
5252
isCollapsed.toggle()
5353
}
5454
}, label: {
5555
ZStack(alignment: .topTrailing) {
56-
SelectableShipmentRow(viewModel: viewModel.mainItemRow)
56+
SelectableShipmentItemRow(viewModel: viewModel.mainItemRow)
5757
.contentShape(Rectangle())
5858

5959
Image(uiImage: isCollapsed ? .chevronDownImage : .chevronUpImage)

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Split Shipments/CollapsibleShipmentCardViewModel.swift

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ final class CollapsibleShipmentCardViewModel: ObservableObject, Identifiable {
3737
let childShippingItem = WooShippingItemRowViewModel(item: ShippingLabelPackageItem(copy: item, quantity: 1.0),
3838
currency: currency)
3939

40-
self.mainItemRow = SelectableShipmentItemRowViewModel(shipmentId: parentShipmentId,
41-
isSelectable: true,
42-
item: mainShippingItem,
43-
showQuantity: true)
40+
self.mainItemRow = SelectableShipmentItemRowViewModel(itemID: parentShipmentId,
41+
isSelectable: true,
42+
item: mainShippingItem,
43+
showQuantity: true)
4444
self.childItemRows = childShipmentIds.map({
45-
SelectableShipmentItemRowViewModel(shipmentId: $0,
46-
isSelectable: true,
47-
item: childShippingItem,
48-
showQuantity: false)
45+
SelectableShipmentItemRowViewModel(itemID: $0,
46+
isSelectable: true,
47+
item: childShippingItem,
48+
showQuantity: false)
4949
})
5050

5151
observeSelection()
Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Yosemite
22
import SwiftUI
33

44
/// Row for a selectable shipment item to ship with the Woo Shipping extension.
5-
struct SelectableShipmentRow: View {
5+
struct SelectableShipmentItemRow: View {
66
@ObservedObject private var viewModel: SelectableShipmentItemRowViewModel
77

88
init(viewModel: SelectableShipmentItemRowViewModel) {
@@ -53,7 +53,7 @@ struct SelectableShipmentRow: View {
5353
}
5454
}
5555

56-
private extension SelectableShipmentRow {
56+
private extension SelectableShipmentItemRow {
5757
@ViewBuilder
5858
func selectionCircle(selected: Bool) -> some View {
5959
if selected {
@@ -75,7 +75,7 @@ private extension SelectableShipmentRow {
7575
}
7676
}
7777

78-
private extension SelectableShipmentRow {
78+
private extension SelectableShipmentItemRow {
7979
enum Layout {
8080
static let horizontalSpacing: CGFloat = 16
8181
static let imageSize: CGFloat = 56.0
@@ -85,12 +85,12 @@ private extension SelectableShipmentRow {
8585
}
8686

8787
#Preview {
88-
SelectableShipmentRow(viewModel: SelectableShipmentItemRowViewModel(itemID: "123",
89-
isSelectable: false,
90-
item: WooShippingItemRowViewModel(imageUrl: nil,
91-
quantityLabel: "3",
92-
name: "Little Nap Brazil 250g",
93-
detailsLabel: "15×10×8cm • Espresso",
94-
weightLabel: "275g",
95-
priceLabel: "$60.00")))
88+
SelectableShipmentItemRow(viewModel: SelectableShipmentItemRowViewModel(itemID: "123",
89+
isSelectable: false,
90+
item: WooShippingItemRowViewModel(imageUrl: nil,
91+
quantityLabel: "3",
92+
name: "Little Nap Brazil 250g",
93+
detailsLabel: "15×10×8cm • Espresso",
94+
weightLabel: "275g",
95+
priceLabel: "$60.00")))
9696
}

WooCommerce/WooCommerce.xcodeproj/project.pbxproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3037,7 +3037,7 @@
30373037
EEBA02A52ADD606D001FE8E4 /* BlazeCampaignDashboardViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBA02A42ADD606D001FE8E4 /* BlazeCampaignDashboardViewModel.swift */; };
30383038
EEBB816F2D8C082B008D6CE5 /* CollapsibleShipmentCardViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBB816E2D8C0821008D6CE5 /* CollapsibleShipmentCardViewModel.swift */; };
30393039
EEBB81712D8C0839008D6CE5 /* CollapsibleShipmentCard.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBB81702D8C0834008D6CE5 /* CollapsibleShipmentCard.swift */; };
3040-
EEBB9B3B2D8E5071008D6CE5 /* SelectableShipmentRow.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBB9B3A2D8E5058008D6CE5 /* SelectableShipmentRow.swift */; };
3040+
EEBB9B3B2D8E5071008D6CE5 /* SelectableShipmentItemRow.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBB9B3A2D8E5058008D6CE5 /* SelectableShipmentItemRow.swift */; };
30413041
EEBB9B3D2D8E5099008D6CE5 /* SelectableShipmentItemRowViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBB9B3C2D8E508E008D6CE5 /* SelectableShipmentItemRowViewModel.swift */; };
30423042
EEBB9B402D8FE5B6008D6CE5 /* WooShippingSplitShipmentsViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBB9B3F2D8FE5B4008D6CE5 /* WooShippingSplitShipmentsViewModelTests.swift */; };
30433043
EEBBC3BC2D92A1E0008D6CE5 /* MoveToShipmentNotice.swift in Sources */ = {isa = PBXBuildFile; fileRef = EEBBC3BB2D92A1C6008D6CE5 /* MoveToShipmentNotice.swift */; };
@@ -6255,7 +6255,7 @@
62556255
EEBA02A42ADD606D001FE8E4 /* BlazeCampaignDashboardViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BlazeCampaignDashboardViewModel.swift; sourceTree = "<group>"; };
62566256
EEBB816E2D8C0821008D6CE5 /* CollapsibleShipmentCardViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CollapsibleShipmentCardViewModel.swift; sourceTree = "<group>"; };
62576257
EEBB81702D8C0834008D6CE5 /* CollapsibleShipmentCard.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CollapsibleShipmentCard.swift; sourceTree = "<group>"; };
6258-
EEBB9B3A2D8E5058008D6CE5 /* SelectableShipmentRow.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SelectableShipmentRow.swift; sourceTree = "<group>"; };
6258+
EEBB9B3A2D8E5058008D6CE5 /* SelectableShipmentItemRow.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SelectableShipmentItemRow.swift; sourceTree = "<group>"; };
62596259
EEBB9B3C2D8E508E008D6CE5 /* SelectableShipmentItemRowViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SelectableShipmentItemRowViewModel.swift; sourceTree = "<group>"; };
62606260
EEBB9B3F2D8FE5B4008D6CE5 /* WooShippingSplitShipmentsViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WooShippingSplitShipmentsViewModelTests.swift; sourceTree = "<group>"; };
62616261
EEBBC3BB2D92A1C6008D6CE5 /* MoveToShipmentNotice.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MoveToShipmentNotice.swift; sourceTree = "<group>"; };
@@ -14028,7 +14028,7 @@
1402814028
children = (
1402914029
EEBBC3BB2D92A1C6008D6CE5 /* MoveToShipmentNotice.swift */,
1403014030
EEBB9B3C2D8E508E008D6CE5 /* SelectableShipmentItemRowViewModel.swift */,
14031-
EEBB9B3A2D8E5058008D6CE5 /* SelectableShipmentRow.swift */,
14031+
EEBB9B3A2D8E5058008D6CE5 /* SelectableShipmentItemRow.swift */,
1403214032
EEBB81702D8C0834008D6CE5 /* CollapsibleShipmentCard.swift */,
1403314033
EEBB816E2D8C0821008D6CE5 /* CollapsibleShipmentCardViewModel.swift */,
1403414034
EE7E75AB2D84080A00E6FF5B /* WooShippingSplitShipmentsViewModel.swift */,
@@ -16570,7 +16570,7 @@
1657016570
02DE39D92968647100BB31D4 /* DomainSettingsViewModel.swift in Sources */,
1657116571
576EA39225264C7400AFC0B3 /* RefundConfirmationViewController.swift in Sources */,
1657216572
DE36E0982A8634FF00B98496 /* StoreNameSetupView.swift in Sources */,
16573-
EEBB9B3B2D8E5071008D6CE5 /* SelectableShipmentRow.swift in Sources */,
16573+
EEBB9B3B2D8E5071008D6CE5 /* SelectableShipmentItemRow.swift in Sources */,
1657416574
2688641B25D3202B00821BA5 /* EditAttributesViewController.swift in Sources */,
1657516575
7E6A01972725B811001668D5 /* FilterProductCategoryListViewController.swift in Sources */,
1657616576
E10DFC7A2673595A0083AFF2 /* ShareSheet.swift in Sources */,

0 commit comments

Comments
 (0)