Skip to content

Commit 56cffaf

Browse files
authored
Optimize extensions SPM setup and symbols removal (#15884)
2 parents 07919b7 + 3e2b347 commit 56cffaf

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

Modules/Package.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,14 +344,12 @@ enum XcodeSupport {
344344
dependencies: [
345345
"Networking",
346346
"WooFoundation",
347-
"Yosemite",
348347
.product(name: "KeychainAccess", package: "KeychainAccess"),
349348
]
350349
),
351350
.xcodeTarget(
352351
XcodeTargetNames.storeWidgetsExtension,
353352
dependencies: [
354-
"Experiments",
355353
"Networking",
356354
"WooFoundation",
357355
.product(name: "KeychainAccess", package: "KeychainAccess"),

WooCommerce/Classes/Model/MarkOrderAsReadUseCase.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Networking
66
import NetworkingCore
77
#endif
88

9-
#if canImport(Yosemite)
9+
#if canImport(Yosemite) && !NOTIFICATION_EXTENSION
1010
import Yosemite
1111
#endif
1212

@@ -19,7 +19,7 @@ struct MarkOrderAsReadUseCase {
1919
case noNeedToMarkAsRead
2020
}
2121

22-
#if canImport(Yosemite)
22+
#if canImport(Yosemite) && !NOTIFICATION_EXTENSION
2323
/// Async method that marks the order note as read if it is the notification for the last order.
2424
/// We do it in a way that first we syncronize notification to get the remote `Note`
2525
/// and then we compare local `orderID` with the one from remote `Note`.

WooCommerce/WooCommerce.xcodeproj/project.pbxproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17760,7 +17760,6 @@
1776017760
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
1776117761
CLANG_WARN_UNREACHABLE_CODE = YES;
1776217762
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
17763-
COPY_PHASE_STRIP = NO;
1776417763
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
1776517764
ENABLE_NS_ASSERTIONS = NO;
1776617765
ENABLE_STRICT_OBJC_MSGSEND = YES;
@@ -17865,6 +17864,7 @@
1786517864
PRODUCT_NAME = "$(TARGET_NAME)";
1786617865
PROVISIONING_PROFILE_SPECIFIER = "WooCommerce Notification Content Exten Development";
1786717866
SKIP_INSTALL = YES;
17867+
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) NOTIFICATION_EXTENSION";
1786817868
SWIFT_EMIT_LOC_STRINGS = YES;
1786917869
SWIFT_VERSION = 5.0;
1787017870
TARGETED_DEVICE_FAMILY = "1,2";
@@ -17892,6 +17892,7 @@
1789217892
PRODUCT_NAME = "$(TARGET_NAME)";
1789317893
PROVISIONING_PROFILE_SPECIFIER = "match AppStore com.automattic.woocommerce.notificationcontentextension";
1789417894
SKIP_INSTALL = YES;
17895+
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) NOTIFICATION_EXTENSION";
1789517896
SWIFT_EMIT_LOC_STRINGS = YES;
1789617897
SWIFT_VERSION = 5.0;
1789717898
TARGETED_DEVICE_FAMILY = "1,2";
@@ -17919,6 +17920,7 @@
1791917920
PRODUCT_NAME = "$(TARGET_NAME)";
1792017921
PROVISIONING_PROFILE_SPECIFIER = "match InHouse com.automattic.alpha.woocommerce.notificationcontentextension";
1792117922
SKIP_INSTALL = YES;
17923+
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) NOTIFICATION_EXTENSION";
1792217924
SWIFT_EMIT_LOC_STRINGS = YES;
1792317925
SWIFT_VERSION = 5.0;
1792417926
TARGETED_DEVICE_FAMILY = "1,2";
@@ -18565,7 +18567,6 @@
1856518567
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
1856618568
CLANG_WARN_UNREACHABLE_CODE = YES;
1856718569
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
18568-
COPY_PHASE_STRIP = NO;
1856918570
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
1857018571
ENABLE_NS_ASSERTIONS = NO;
1857118572
ENABLE_STRICT_OBJC_MSGSEND = YES;

0 commit comments

Comments
 (0)