Adding tests

Author: adborbas

WooCommerce/Classes/Routing/ProductDetail/NativeProductDetailCoordinator.swift

@@ -0,0 +1,15 @@
+import Yosemite
+import UIKit
+
+class NativeProductDetailCoordinator: ProductDetailCoordinator {
+    func viewController(
+        product: Product,
+        presentationStyle: ProductDetailPresenter.PresentationStyle,
+        forceReadOnly: Bool,
+        onDeleteCompletion: (() -> Void)? = nil) -> UIViewController {
+            return ProductDetailsFactory.productDetails(product: product,
+                                                        presentationStyle: presentationStyle.asProductFormPresentationStyle,
+                                                        forceReadOnly: false,
+                                                        onDeleteCompletion: onDeleteCompletion ?? {})
+        }
+}

WooCommerce/Classes/Routing/ProductDetail/ProductDetailRouter.swift

@@ -0,0 +1,84 @@
+import UIKit
+import Yosemite
+
+final class ProductDetailPresenter {
+    enum PresentationStyle {
+        case undefined
+        case contained(containerViewController: () -> UIViewController?)
+
+        var asProductFormPresentationStyle: ProductFormPresentationStyle {
+            switch self {
+            case .contained(let containerViewController):
+                    .contained(containerViewController: containerViewController)
+            case .undefined:
+                    .navigationStack
+            }
+        }
+    }
+
+    static var shared = ProductDetailPresenter()
+
+    private let ciabChecker: CIABEligibilityCheckerProtocol
+    private let coordinatorFactory: ProductDetailCoordinatorFactoryProtocol
+
+    init(ciabChecker: CIABEligibilityCheckerProtocol = CIABEligibilityChecker(),
+         coordinatorFactory: ProductDetailCoordinatorFactoryProtocol = ProductDetailCoordinatorFactory.default) {
+        self.ciabChecker = ciabChecker
+        self.coordinatorFactory = coordinatorFactory
+    }
+
+    func viewController(product: Product,
+                        presentationStyle: PresentationStyle = .undefined,
+                        forceReadOnly: Bool,
+                        onDeleteCompletion: (() -> Void)? = nil) -> UIViewController {
+
+        let coordinator: ProductDetailCoordinator
+        if shouldOpenInWeb(product: product) {
+            coordinator = coordinatorFactory.webCoordinator()
+        } else {
+            coordinator = coordinatorFactory.nativeCoordinator()
+        }
+
+        let viewController = coordinator.viewController(product: product,
+                                                        presentationStyle: presentationStyle,
+                                                        forceReadOnly: forceReadOnly,
+                                                        onDeleteCompletion: onDeleteCompletion)
+
+        return viewController
+    }
+
+    private func shouldOpenInWeb(product: Product) -> Bool {
+        return ciabChecker.isCurrentSiteCIAB && product.productType == .booking
+    }
+}
+
+protocol ProductDetailCoordinator {
+    func viewController(
+        product: Product,
+        presentationStyle: ProductDetailPresenter.PresentationStyle,
+        forceReadOnly: Bool,
+        onDeleteCompletion: (() -> Void)?) -> UIViewController
+}
+
+protocol ProductDetailCoordinatorFactoryProtocol {
+    func webCoordinator() -> ProductDetailCoordinator
+    func nativeCoordinator() -> ProductDetailCoordinator
+}
+
+class ProductDetailCoordinatorFactory: ProductDetailCoordinatorFactoryProtocol {
+    static let `default` = ProductDetailCoordinatorFactory()
+
+    private let stores: StoresManager
+
+    init(stores: StoresManager = ServiceLocator.stores) {
+        self.stores = stores
+    }
+
+    func webCoordinator() -> ProductDetailCoordinator {
+        return WebViewProductDetailCoordinator(site: stores.sessionManager.defaultSite!)
+    }
+
+    func nativeCoordinator() -> ProductDetailCoordinator {
+        return NativeProductDetailCoordinator()
+    }
+}

WooCommerce/Classes/Routing/ProductDetail/ProductURLProvider.swift

@@ -0,0 +1,16 @@
+import Yosemite
+import Foundation
+
+enum ProductURLProvider {
+    static func editAdminURL(for product: Product, site: Site) -> URL? {
+        guard let base = site.adminURLWithFallback() else { return nil }
+
+        var components = URLComponents(url: base, resolvingAgainstBaseURL: false)!
+        components.queryItems = [
+            URLQueryItem(name: "page", value: "next-admin"),
+            URLQueryItem(name: "p", value: "/woocommerce/products/edit/\(product.productID)")
+        ]
+
+        return components.url
+    }
+}

WooCommerce/Classes/Routing/ProductDetail/WebViewProductDetailCoordinator.swift

@@ -0,0 +1,33 @@
+import UIKit
+import Yosemite
+
+final class WebViewProductDetailCoordinator: NSObject, ProductDetailCoordinator {
+    private var onDismiss: (() -> Void)?
+
+    private let site: Site
+
+    init(site: Site) {
+        self.site = site
+    }
+
+    func viewController(product: Product,
+                        presentationStyle: ProductDetailPresenter.PresentationStyle,
+                        forceReadOnly: Bool,
+                        onDeleteCompletion: (() -> Void)? = nil) -> UIViewController {
+        guard let url = ProductURLProvider.editAdminURL(for: product, site: site) else {
+            return UIViewController()
+        }
+
+        let viewModel = WPAdminWebViewModel(title: product.name, initialURL: url)
+        let webViewController = AuthenticatedWebViewController(viewModel: viewModel)
+
+        return webViewController
+    }
+
+    @objc
+    private func dismissWebView() {
+        let completion = onDismiss
+        onDismiss = nil
+        completion?()
+    }
+}

WooCommerce/Classes/Routing/ProductDetailRouter.swift

@@ -227,7 +227,7 @@ private extension ProductLoaderViewController {
     /// Presents the ProductFormViewController, as a childViewController, for a given Product.
     ///
     func presentProductDetails(for product: Product) {
-        let viewController = ProductDetailRouter.shared.viewController(product: product,
+        let viewController = ProductDetailPresenter.shared.viewController(product: product,
                                                                        presentationStyle: .contained(containerViewController: { [weak self] in self }),
                                                                        forceReadOnly: forceReadOnly)
         attachProductDetailsChildViewController(viewController)

WooCommerce/Classes/ViewRelated/Products/Product Loader/ProductLoaderViewController.swift

@@ -122,7 +122,7 @@ private extension ProductsSplitViewCoordinator {
     }
 
     func showProductForm(product: Product) {
-        let viewController = ProductDetailRouter.shared.viewController(product: product,
+        let viewController = ProductDetailPresenter.shared.viewController(product: product,
                                                                        forceReadOnly: false,
                                                                        onDeleteCompletion: { [weak self] in
             self?.onSecondaryProductFormDeletion()

WooCommerce/Classes/ViewRelated/Products/ProductsSplitViewCoordinator.swift

@@ -1214,7 +1214,7 @@ extension ProductsViewController: UITableViewDelegate {
 private extension ProductsViewController {
     func didSelectProduct(product: Product) {
         guard isSplitViewEnabled else {
-            let viewController = ProductDetailRouter.shared.viewController(product: product,
+            let viewController = ProductDetailPresenter.shared.viewController(product: product,
                                                                            forceReadOnly: false)
             navigationController?.pushViewController(viewController, animated: true)
             return

WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift

@@ -1340,7 +1340,6 @@
 		640DA3482E97DE4F00317FB2 /* SceneDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 640DA3472E97DE4F00317FB2 /* SceneDelegate.swift */; };
 		64D355A52E99048E005F53F7 /* TestingSceneDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 64D355A42E99048E005F53F7 /* TestingSceneDelegate.swift */; };
 		68051E1E2E9DFE5500228196 /* POSNotificationSchedulerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68051E1D2E9DFE5100228196 /* POSNotificationSchedulerTests.swift */; };
-		680BA59A2A4C377900F5559D /* UpgradeViewState.swift in Sources */ = {isa = PBXBuildFile; fileRef = 680BA5992A4C377900F5559D /* UpgradeViewState.swift */; };
 		680E36B52BD8B9B900E8BCEA /* OrderSubscriptionTableViewCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = 680E36B42BD8B9B900E8BCEA /* OrderSubscriptionTableViewCell.xib */; };
 		680E36B72BD8C49F00E8BCEA /* OrderSubscriptionTableViewCellViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 680E36B62BD8C49F00E8BCEA /* OrderSubscriptionTableViewCellViewModel.swift */; };
 		682140AF2E125437005E86AB /* UILabel+SalesChannel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 682140AE2E125430005E86AB /* UILabel+SalesChannel.swift */; };
@@ -5779,6 +5778,7 @@
 		3F09040E2D26A40800D8ACCE /* WordPressAuthenticatorTests */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (3FD28D5E2D271391002EBB3D /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = WordPressAuthenticatorTests; sourceTree = "<group>"; };
 		3FD9BFBE2E0A2533004A8DC8 /* WooCommerceScreenshots */ = {isa = PBXFileSystemSynchronizedRootGroup; exceptions = (3FD9BFC42E0A2534004A8DC8 /* PBXFileSystemSynchronizedBuildFileExceptionSet */, ); explicitFileTypes = {}; explicitFolders = (); path = WooCommerceScreenshots; sourceTree = "<group>"; };
 		646A2C682E9FCD7E003A32A1 /* Routing */ = {isa = PBXFileSystemSynchronizedRootGroup; explicitFileTypes = {}; explicitFolders = (); path = Routing; sourceTree = "<group>"; };
+		6489D8522EA667AC00D96802 /* Routing */ = {isa = PBXFileSystemSynchronizedRootGroup; explicitFileTypes = {}; explicitFolders = (); path = Routing; sourceTree = "<group>"; };
 		DEDB5D342E7A68950022E5A1 /* Bookings */ = {isa = PBXFileSystemSynchronizedRootGroup; explicitFileTypes = {}; explicitFolders = (); path = Bookings; sourceTree = "<group>"; };
 /* End PBXFileSystemSynchronizedRootGroup section */
 
@@ -9649,6 +9649,7 @@
 		B56DB3E02049BFAA00D4AA8E /* WooCommerceTests */ = {
 			isa = PBXGroup;
 			children = (
+				6489D8522EA667AC00D96802 /* Routing */,
 				DEB387962C2E80060025256E /* GoogleAds */,
 				DABF35242C11B40C006AF826 /* POS */,
 				B958A7CF28B527FB00823EEF /* Universal Links */,
@@ -13276,6 +13277,9 @@
 			dependencies = (
 				B56DB3DF2049BFAA00D4AA8E /* PBXTargetDependency */,
 			);
+			fileSystemSynchronizedGroups = (
+				6489D8522EA667AC00D96802 /* Routing */,
+			);
 			name = WooCommerceTests;
 			packageProductDependencies = (
 				3F2B4AEB2DDC319800E5E49C /* XcodeTarget_WooCommerceTests */,