Remove unused code

Author: joshheald

Modules/Sources/NetworkingCore/Model/DotcomError.swift

@@ -177,11 +177,11 @@ public extension NetworkError {
         guard let originalNetworkError = originalNetworkError else {
             // No original NetworkError - this is likely from successful HTTP response with API error content
             let (code, message) = dotcomError.getCodeAndMessage()
-            let errorData = dotcomError.createEnhancedErrorResponseData(originalResponse: nil)
+            let errorData = dotcomError.createEnhancedErrorResponseData()
             return .apiError(code: code, message: message, response: errorData)
         }
 
-        let enhancedErrorData = dotcomError.createEnhancedErrorResponseData(originalResponse: originalNetworkError.response)
+        let enhancedErrorData = dotcomError.createEnhancedErrorResponseData()
 
         switch originalNetworkError {
         case .notFound:
@@ -205,7 +205,7 @@ public extension NetworkError {
 //
 private extension DotcomError {
     /// Creates enhanced JSON error response data that preserves original response while adding structured error details
-    func createEnhancedErrorResponseData(originalResponse: Data?) -> Data? {
+    func createEnhancedErrorResponseData() -> Data? {
         let (code, message) = getCodeAndMessage()
 
         let errorResponse: [String: Any] = [

Modules/Sources/NetworkingCore/Network/NetworkError.swift

@@ -164,6 +164,7 @@ extension NetworkError: CustomStringConvertible {
 
 public extension NetworkError {
     /// Returns true if this error represents a "not found" condition
+    // periphery:ignore - TODO: remove this ignore when we merge NetworkError use
     var isNotFound: Bool {
         switch self {
         case .notFound:
@@ -176,6 +177,7 @@ public extension NetworkError {
     }
 
     /// Returns true if this error represents an authorization issue
+    // periphery:ignore - TODO: remove this ignore when we merge NetworkError use
     var isUnauthorized: Bool {
         switch self {
         case .invalidCookieNonce:
@@ -190,6 +192,7 @@ public extension NetworkError {
     }
 
     /// Returns true if this error represents a timeout
+    // periphery:ignore - TODO: remove this ignore when we merge NetworkError use
     var isTimeout: Bool {
         switch self {
         case .timeout:
@@ -202,6 +205,7 @@ public extension NetworkError {
     }
 
     /// Returns true if this error represents invalid input/parameters
+    // periphery:ignore - TODO: remove this ignore when we merge NetworkError use
     var isInvalidInput: Bool {
         switch self {
         case .unacceptableStatusCode(let statusCode, _):
@@ -212,6 +216,7 @@ public extension NetworkError {
     }
 
     /// Returns a user-friendly error message, preferring API error message over generic description
+    // periphery:ignore - TODO: remove this ignore when we merge NetworkError use
     var userFriendlyMessage: String {
         return apiErrorMessage ?? localizedDescription
     }
@@ -220,12 +225,7 @@ public extension NetworkError {
 // MARK: - Supporting Types
 
 /// Represents error details from API response JSON
-public struct APIErrorDetails: Codable {
-    public let code: String
-    public let message: String?
-
-    public init(code: String, message: String?) {
-        self.code = code
-        self.message = message
-    }
+struct APIErrorDetails: Codable {
+    let code: String
+    let message: String?
 }

Modules/Sources/Yosemite/Tools/CommonReaderConfigProvider.swift

@@ -83,18 +83,3 @@ private extension CardReaderConfigError {
         }
     }
 }
-
-private struct CardReaderConfigNetworkErrorDetails: Decodable {
-    let code: ErrorCode
-    let message: String?
-
-    enum CodingKeys: CodingKey {
-        case code
-        case message
-    }
-
-    enum ErrorCode: String, Decodable {
-        case storeAddressIncomplete = "store_address_is_incomplete"
-        case postalCodeInvalid = "postal_code_invalid"
-    }
-}