Merge pull request #8263 from woocommerce/issue/8224-order-completed-toast-goes-up

Fix Notice View when navigating to a view without tab bar

Author: toupper

WooCommerce/Classes/Tools/Notices/DefaultNoticePresenter.swift

@@ -20,6 +20,8 @@ class DefaultNoticePresenter: NoticePresenter {
     ///
     private var noticeOnScreen: Notice?
 
+    var kvoToken: NSKeyValueObservation?
+
     /// UIViewController to be used as Notice(s) Presenter
     ///
     weak var presentingViewController: UIViewController?
@@ -191,6 +193,7 @@ private extension DefaultNoticePresenter {
     func dismiss() {
         noticeOnScreen = nil
         keyboardFrameObserver = nil
+        kvoToken = nil
         presentNextNoticeIfPossible()
     }
 
@@ -207,7 +210,20 @@ private extension DefaultNoticePresenter {
             fatalError("NoticePresenter requires a presentingViewController!")
         }
 
-        if let tabBarController = presentingViewController as? UITabBarController {
+        if let tabBarController = presentingViewController as? UITabBarController,
+           !tabBarController.tabBar.isHidden {
+            if kvoToken == nil {
+                kvoToken = tabBarController.tabBar.observe(\.isHidden, options: .new) { tabBar, _ in
+                    guard tabBar.isHidden else {
+                        return
+                    }
+
+                    // If the tab bar hides we also hide the notice, as trying to rearrange the notice accordingly might bring unexpected results
+                    // due to the internal logic of UITabBarController e.g they remove/recreate the tab bar when navigation happens
+                    container.isHidden = true
+                }
+            }
+
             return container.bottomAnchor.constraint(equalTo: tabBarController.tabBar.topAnchor)
         }