Skip to content

Commit 651c53a

Browse files
committed
Fix failed tests
1 parent 96e16a3 commit 651c53a

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

Modules/Tests/NetworkingTests/Remote/BookingsRemoteTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ struct BookingsRemoteTests {
4141
@Test func test_loadAllBookings_sends_correct_parameters() async throws {
4242
// Given
4343
let remote = BookingsRemote(network: network)
44-
let startDateBefore = "2024-12-31T23:59:59"
45-
let startDateAfter = "2024-01-01T00:00:00"
44+
let startDateBefore = "2024-12-31T23:59:59Z"
45+
let startDateAfter = "2024-01-01T00:00:00Z"
4646
let searchQuery = "test search"
4747
let filters = BookingFilters(
4848
startDateBefore: startDateBefore,

WooCommerce/WooCommerceTests/ViewRelated/Bookings/BookingListViewModelTests.swift

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,12 @@ struct BookingListViewModelTests {
486486
storage: storageManager,
487487
currentDate: testDate)
488488

489-
// When/Then - should only show bookings within today (startDate > start AND startDate < end)
490-
#expect(viewModel.bookings.count == 2)
491-
#expect(viewModel.bookings.first?.bookingID == withinTodayBooking.bookingID)
489+
// When/Then - should only show bookings within today (startDate >= start AND startDate <= end)
490+
#expect(viewModel.bookings.count == 3)
491+
let bookingIDs = viewModel.bookings.map({ $0.bookingID })
492+
#expect(bookingIDs.contains(withinTodayBooking.bookingID))
493+
#expect(bookingIDs.contains(atStartOfDayBooking.bookingID))
494+
#expect(bookingIDs.contains(startOfNextDayBooking.bookingID))
492495
}
493496

494497
@Test func upcoming_tab_results_controller_filters_local_storage_correctly() {
@@ -511,14 +514,14 @@ struct BookingListViewModelTests {
511514
storage: storageManager,
512515
currentDate: testDate)
513516

514-
// When/Then - should only show bookings after today (startDate > end of today)
515-
#expect(viewModel.bookings.count == 2, "Upcoming tab should show bookings after today")
517+
// When/Then - should only show bookings after today (startDate >= end of today)
518+
#expect(viewModel.bookings.count == 3, "Upcoming tab should show bookings after today")
516519
let bookingIDs = Set(viewModel.bookings.map { $0.bookingID })
517520
#expect(bookingIDs.contains(afterTodayBooking1.bookingID), "Should contain booking after today")
518521
#expect(bookingIDs.contains(afterTodayBooking2.bookingID), "Should contain second booking after today")
519522
#expect(!bookingIDs.contains(withinTodayBooking.bookingID), "Should not contain booking within today")
520523
#expect(!bookingIDs.contains(beforeTodayBooking.bookingID), "Should not contain booking before today")
521-
#expect(!bookingIDs.contains(atEndOfDayBooking.bookingID), "Should not contain booking exactly at end of day")
524+
#expect(bookingIDs.contains(atEndOfDayBooking.bookingID), "Should contain booking exactly at end of day")
522525
}
523526

524527
@Test func all_tab_results_controller_shows_all_bookings_from_local_storage() {

0 commit comments

Comments
 (0)