Skip to content

Commit 654bbee

Browse files
committed
Update bottomshet code to refer to subtitle properly
1 parent b9bd8f4 commit 654bbee

File tree

9 files changed

+16
-10
lines changed

9 files changed

+16
-10
lines changed

WooCommerce/Classes/ViewRelated/BottomSheet/ListSelector/BottomSheetListSelectorViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ UIViewController, UITableViewDataSource, UITableViewDelegate where Command.Model
9393
as? BottomSheetListSelectorSectionHeaderView else {
9494
fatalError()
9595
}
96-
header.configure(text: viewProperties.title)
96+
header.configure(title: viewProperties.title, subtitle: viewProperties.subtitle)
9797
return header
9898
}
9999
}

WooCommerce/Classes/ViewRelated/BottomSheet/ListSelector/BottomSheetListSelectorViewProperties.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,10 @@
22
///
33
struct BottomSheetListSelectorViewProperties {
44
let title: String?
5+
let subtitle: String?
6+
7+
init(title: String? = nil, subtitle: String? = nil) {
8+
self.title = title
9+
self.subtitle = subtitle
10+
}
511
}

WooCommerce/Classes/ViewRelated/Coupons/Add and Edit Coupons/AddEditCoupon.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ struct AddEditCoupon: View {
7373
@State private var showingDiscountType: Bool = false
7474

7575
private var idiom: UIUserInterfaceIdiom { UIDevice.current.userInterfaceIdiom }
76-
private let viewProperties = BottomSheetListSelectorViewProperties(title: Localization.discountTypeSheetTitle)
76+
private let viewProperties = BottomSheetListSelectorViewProperties(subtitle: Localization.discountTypeSheetTitle)
7777

7878
private let categorySelectorConfig = ProductCategorySelector.Configuration.categoriesForCoupons
7979
private let categoryListConfig = ProductCategoryListViewController.Configuration(searchEnabled: true, clearSelectionEnabled: true)

WooCommerce/Classes/ViewRelated/Coupons/CouponListViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ private extension CouponListViewController {
302302

303303
@objc private func displayCouponTypeBottomSheet() {
304304
ServiceLocator.analytics.track(.couponsListCreateTapped)
305-
let viewProperties = BottomSheetListSelectorViewProperties(title: Localization.createCouponAction)
305+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: Localization.createCouponAction)
306306
let command = DiscountTypeBottomSheetListSelectorCommand(selected: nil) { [weak self] selectedType in
307307
guard let self = self else { return }
308308
self.presentedViewController?.dismiss(animated: true, completion: nil)

WooCommerce/Classes/ViewRelated/Orders/Order Creation/FlowCoordinator/AddOrderCoordinator.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ final class AddOrderCoordinator: Coordinator {
5353
// MARK: Navigation
5454
private extension AddOrderCoordinator {
5555
func presentOrderTypeBottomSheet() {
56-
let viewProperties = BottomSheetListSelectorViewProperties(title: nil)
56+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: nil)
5757
let command = OrderTypeBottomSheetListSelectorCommand() { selectedBottomSheetOrderType in
5858
self.navigationController.dismiss(animated: true)
5959
self.presentOrderCreationFlow(bottomSheetOrderType: selectedBottomSheetOrderType)

WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductCoordinator.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ private extension AddProductCoordinator {
8888
func presentProductCreationTypeBottomSheet() {
8989
let title = NSLocalizedString("How do you want to start?",
9090
comment: "Message title of bottom sheet for selecting a template or manual product")
91-
let viewProperties = BottomSheetListSelectorViewProperties(title: title)
91+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: title)
9292
let command = ProductCreationTypeSelectorCommand { selectedCreationType in
9393
self.trackProductCreationType(selectedCreationType)
9494
self.presentProductTypeBottomSheet(creationType: selectedCreationType)
@@ -102,7 +102,7 @@ private extension AddProductCoordinator {
102102
func presentProductTypeBottomSheet(creationType: ProductCreationType) {
103103
let title = NSLocalizedString("Select a product type",
104104
comment: "Message title of bottom sheet for selecting a product type to create a product")
105-
let viewProperties = BottomSheetListSelectorViewProperties(title: title)
105+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: title)
106106
let command = ProductTypeBottomSheetListSelectorCommand(selected: nil) { selectedBottomSheetProductType in
107107
ServiceLocator.analytics.track(.addProductTypeSelected, withProperties: ["product_type": selectedBottomSheetProductType.productType.rawValue])
108108
self.navigationController.dismiss(animated: true) {

WooCommerce/Classes/ViewRelated/Products/Edit Product/Downloadable Files/File List/ProductDownloadListViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ extension ProductDownloadListViewController {
161161

162162
@objc private func addButtonTapped(_ sender: UIButton) {
163163
let title = Localization.bottomSheetTitle
164-
let viewProperties = BottomSheetListSelectorViewProperties(title: title)
164+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: title)
165165
let actions = viewModel.bottomSheetActions
166166
let dataSource = DownloadableFileBottomSheetListSelectorCommand(actions: actions) { [weak self] action in
167167
self?.dismiss(animated: true) { [weak self] in

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ private extension ProductFormViewController {
713713
func moreDetailsButtonTapped(button: UIButton) {
714714
let title = NSLocalizedString("Add more details",
715715
comment: "Title of the bottom sheet from the product form to add more product details.")
716-
let viewProperties = BottomSheetListSelectorViewProperties(title: title)
716+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: title)
717717
let actions = viewModel.actionsFactory.bottomSheetActions()
718718
let dataSource = ProductFormBottomSheetListSelectorCommand(actions: actions) { [weak self] action in
719719
self?.dismiss(animated: true) { [weak self] in
@@ -1151,7 +1151,7 @@ private extension ProductFormViewController {
11511151
func editProductType(cell: UITableViewCell?) {
11521152
let title = NSLocalizedString("Change product type",
11531153
comment: "Message title of bottom sheet for selecting a product type")
1154-
let viewProperties = BottomSheetListSelectorViewProperties(title: title)
1154+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: title)
11551155
let productType = BottomSheetProductType(productType: viewModel.productModel.productType, isVirtual: viewModel.productModel.virtual)
11561156
let command = ProductTypeBottomSheetListSelectorCommand(selected: productType) { [weak self] (selectedProductType) in
11571157
self?.dismiss(animated: true, completion: nil)

WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ private extension ProductsViewController {
665665
ServiceLocator.analytics.track(.productListViewSortingOptionsTapped)
666666
let title = NSLocalizedString("Sort by",
667667
comment: "Message title for sort products action bottom sheet")
668-
let viewProperties = BottomSheetListSelectorViewProperties(title: title)
668+
let viewProperties = BottomSheetListSelectorViewProperties(subtitle: title)
669669
let command = ProductsSortOrderBottomSheetListSelectorCommand(selected: sortOrder) { [weak self] selectedSortOrder in
670670
self?.dismiss(animated: true, completion: nil)
671671
guard let selectedSortOrder = selectedSortOrder as ProductsSortOrder? else {

0 commit comments

Comments
 (0)