test for getPOSSurveyNotificationScheduled

Author: iamgabrielma

Modules/Sources/Yosemite/Stores/AppSettingsStore.swift

@@ -1304,7 +1304,7 @@ private extension AppSettingsStore {
     }
 
     func getPOSSurveyNotificationScheduled(onCompletion: (Bool) -> Void) {
-        // TODO
+        onCompletion(generalAppSettings.value(for: \.isPOSSurveyNotificationScheduled))
     }
 
     func resetPOSSurveyNotificationScheduled(onCompletion: (Result<Void, Error>) -> Void) {

Modules/Tests/StorageTests/Model/AppSettings/GeneralAppSettingsTests.swift

@@ -51,6 +51,14 @@ final class GeneralAppSettingsTests: XCTestCase {
         XCTAssertEqual(newSettings.feedbacks[.general], newFeedback)
     }
 
+    func test_isPOSSurveyNotificationScheduled_defaults_to_false() {
+        // Given
+        let settings = createGeneralAppSettings()
+
+        // Then
+        XCTAssertFalse(settings.isPOSSurveyNotificationScheduled)
+    }
+
     func test_updating_properties_to_generalAppSettings_does_not_breaks_decoding() throws {
         // Given
         let installationDate = Date(timeIntervalSince1970: 1630314000) // Mon Aug 30 2021 09:00:00 UTC+0000
@@ -63,6 +71,7 @@ final class GeneralAppSettingsTests: XCTestCase {
                 FeatureAnnouncementCampaignSettings(dismissedDate: Date(), remindAfter: nil)]
         let sitesWithAtLeastOneIPPTransactionFinished: Set<Int64> = [1234, 123, 12, 1]
         let isCustomFieldsTopBannerDismissed = true
+        let isPOSSurveyNotificationScheduled = true
         let previousSettings = GeneralAppSettings(installationDate: installationDate,
                                                   feedbacks: feedbackSettings,
                                                   isViewAddOnsSwitchEnabled: true,
@@ -74,13 +83,14 @@ final class GeneralAppSettingsTests: XCTestCase {
                                                   sitesWithAtLeastOneIPPTransactionFinished: sitesWithAtLeastOneIPPTransactionFinished,
                                                   isEUShippingNoticeDismissed: false,
                                                   isCustomFieldsTopBannerDismissed: isCustomFieldsTopBannerDismissed,
-                                                  isPOSSurveyNotificationScheduled: false)
+                                                  isPOSSurveyNotificationScheduled: isPOSSurveyNotificationScheduled)
 
         let previousEncodedSettings = try JSONEncoder().encode(previousSettings)
         var previousSettingsJson = try JSONSerialization.jsonObject(with: previousEncodedSettings, options: .allowFragments) as? [String: Any]
 
         // When
         previousSettingsJson?.removeValue(forKey: "isViewAddOnsSwitchEnabled")
+        previousSettingsJson?.removeValue(forKey: "isPOSSurveyNotificationScheduled")
         let newEncodedSettings = try JSONSerialization.data(withJSONObject: previousSettingsJson as Any, options: .fragmentsAllowed)
         let newSettings = try JSONDecoder().decode(GeneralAppSettings.self, from: newEncodedSettings)
 
@@ -94,6 +104,7 @@ final class GeneralAppSettingsTests: XCTestCase {
         assertEqual(newSettings.featureAnnouncementCampaignSettings, featureAnnouncementCampaignSettings)
         assertEqual(newSettings.sitesWithAtLeastOneIPPTransactionFinished, sitesWithAtLeastOneIPPTransactionFinished)
         assertEqual(newSettings.isCustomFieldsTopBannerDismissed, isCustomFieldsTopBannerDismissed)
+        assertEqual(newSettings.isPOSSurveyNotificationScheduled, false)
     }
 }
 

Modules/Tests/YosemiteTests/Stores/AppSettingsStoreTests.swift

@@ -1506,6 +1506,25 @@ extension AppSettingsStoreTests {
         // Then
         XCTAssertNil(loadedOrderStatus)
     }
+
+    // MARK: - Point of Sale Survey Notification
+
+    func test_getPOSSurveyNotificationScheduled_returns_false_on_new_generalAppSettings() throws {
+        // Given
+        try fileStorage?.deleteFile(at: expectedGeneralAppSettingsFileURL)
+
+        // When
+        let result: Bool = waitFor { promise in
+            let action = AppSettingsAction.getPOSSurveyNotificationScheduled { isScheduled in
+                promise(isScheduled)
+            }
+            self.subject?.onAction(action)
+        }
+
+        // Then
+        XCTAssertFalse(result)
+    }
+
 }
 
 // MARK: - Utils